You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2016/12/22 08:35:39 UTC
[GitHub] zeppelin pull request #1791: [ZEPPELIN-1847] fix: Copy only html when html f...
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/1791
[ZEPPELIN-1847] fix: Copy only html when html file changed
### What is this PR for?
Reduce build time by avoiding to copy non-related files. Approx 3~4 secs as you can see below.
### What type of PR is it?
[Improvement]
### Todos
Nothing
### What is the Jira issue?
[ZEPPELIN-1847](https://issues.apache.org/jira/browse/ZEPPELIN-1847)
### How should this be tested?
1. `cd zeppelin-web`
2. `npm install` && `npm run start`
3. change any html file in `src/` and see log.
4. compare the result with master branch's
### Screenshots (if appropriate)
```
Running "watch" task
Waiting...
>> File "src/app/home/home.html" changed.
## before
Execution Time (2016-12-22 08:13:35 UTC)
loading tasks 130ms \u2587\u2587\u2587 3%
htmlhint:src 84ms \u2587\u2587 2%
newer:copy:dev 3.6s \u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587 93%
Total 3.9s
Completed in 5.953s at Thu Dec 22 2016 17:13:39 GMT+0900 (KST) - Waiting\u2026
## after
Execution Time (2016-12-22 08:14:27 UTC)
loading tasks 137ms \u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587 52%
newer:htmlhint 3ms \u2587 1%
newer:htmlhint:src 25ms \u2587\u2587\u2587\u2587\u2587\u2587\u2587 10%
htmlhint:src 89ms \u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587\u2587 34%
newer:copy:html 5ms \u2587\u2587 2%
Total 261ms
Completed in 2.447s at Thu Dec 22 2016 17:14:27 GMT+0900 (KST) - Waiting\u2026
```
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin fix/DONT-copy-all-files-grunt
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1791.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1791
----
commit 03e95f778ddd2d6a13c279a85ff14aa3616b8f05
Author: 1ambda <1a...@gmail.com>
Date: 2016-12-22T08:29:30Z
fix: Copy only html when html file changed
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1791: [ZEPPELIN-1847] fix: Copy only html when html file cha...
Posted by felizbear <gi...@git.apache.org>.
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1791
GOOD
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1791: [ZEPPELIN-1847] fix: Copy only html when html file cha...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1791
Did simple test for applying webpack. Let me share result in short.
- (**IMPORTANT**) It is impossible to handle in a single PR. It requires changing directory structure and this causes sooooooo many rebase. It would be painful if it is not merged quickly.
- angular is more tricky to use webpack. (e.g how to handle ng-include? - [webpack-require-loader])
- we need index.html first.
- webpack configuration is not hard as expected. [we have many references](https://github.com/preboot/angular-webpack/blob/master/webpack.config.js) for it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1791: [ZEPPELIN-1847] fix: Copy only html when html file cha...
Posted by felizbear <gi...@git.apache.org>.
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1791
We totally can but it requires some effort, i.e. migrating code to es6 modules
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1791: [ZEPPELIN-1847] fix: Copy only html when html file cha...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1791
@1ambda Tested this branch and it's faster than master as you described. Nice improvement indeed!
- before
<img width="629" alt="screen shot 2016-12-26 at 1 25 11 am" src="https://cloud.githubusercontent.com/assets/10060731/21472036/01d7b58a-cb0b-11e6-9faf-05c4623255d7.png">
- after
<img width="645" alt="screen shot 2016-12-26 at 1 30 50 am" src="https://cloud.githubusercontent.com/assets/10060731/21472037/08983b6a-cb0b-11e6-805c-dce3e31b2ac8.png">
I think it's good to go now :D
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1791: [ZEPPELIN-1847] fix: Copy only html when html file cha...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1791
\cc @cloverhearts @felizbear for review. Thanks :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1791: [ZEPPELIN-1847] fix: Copy only html when html file cha...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1791
one more question. Can we boost dev mode build using webpack and its useful plugins?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1791: [ZEPPELIN-1847] fix: Copy only html when html file cha...
Posted by felizbear <gi...@git.apache.org>.
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1791
@1ambda thank you for the research. A couple of questions:
1. Why do you think it requires changing dir structure?
2. What do you mean by: "we need index.html first."?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1791: [ZEPPELIN-1847] fix: Copy only html when html file cha...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1791
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1791: [ZEPPELIN-1847] fix: Copy only html when html file cha...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1791
Merge into master if there are no more comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1791: [ZEPPELIN-1847] fix: Copy only html when html file cha...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1791
@1ambda
Thank you for your good fix.
Sure, I will :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1791: [ZEPPELIN-1847] fix: Copy only html when html file cha...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1791
@felizbear
1. I thought webpack-dev-server can serve only one diretory using `contentBase` but they supports multiple dirs. So now it doesn't matter :)
2. It's typo. I updated the comment
@AhyoungRyu
Can we merge this commit? This impacts on our productivity significantly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1791: [ZEPPELIN-1847] fix: Copy only html when html f...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1791
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---