You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2016/11/05 02:11:28 UTC

[GitHub] zeppelin pull request #1603: [HOTFIX] HeliumApplicationFactoryTest fails on ...

GitHub user Leemoonsoo opened a pull request:

    https://github.com/apache/zeppelin/pull/1603

    [HOTFIX] HeliumApplicationFactoryTest fails on master

    ### What is this PR for?
    HeliumApplicationFactoryTest fails on master with following error if i run the test on local machine.
    
    I'm fixing the issue by changing InterpreterFactory loads interpreter properties from interpreter-setting.json file, interpreter-setting.json classresource and Interpreter.register() call 
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    * [x] - Fix the problem
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1624
    
    ### How should this be tested?
    try run HeliumApplicationFactoryTest unittest and see if it successes
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Leemoonsoo/zeppelin fix_helium_application_factory_test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1603.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1603
    
----
commit 89b44a34e56422086ae61fc655f748871fc24adc
Author: Lee moon soo <mo...@apache.org>
Date:   2016-11-05T01:33:35Z

    Make interpreter factory load interpreter-setting from file, classresource, classloading(regacy way)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1603: [ZEPPELIN-1624] HeliumApplicationFactoryTest fails on ...

Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:

    https://github.com/apache/zeppelin/pull/1603
  
    on `mvn clean package -pl \!zeppelin-distribution` I got
    
    ```
    Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.193 sec - in org.apache.zeppelin.search.LuceneSearchTest
    
    Results :
    
    Tests in error:
      HeliumApplicationFactoryTest.testUnloadOnInterpreterUnbind:232 � ClassCast jav...
      HeliumApplicationFactoryTest.testLoadRunUnloadApplication:148 � ClassCast java...
      HeliumApplicationFactoryTest.testUnloadOnInterpreterRestart:299 � ClassCast ja...
      HeliumApplicationFactoryTest.testUnloadOnParagraphRemove:193 � ClassCast java....
    
    Tests run: 116, Failures: 0, Errors: 4, Skipped: 0
    
    [INFO] ------------------------------------------------------------------------
    [INFO] Reactor Summary:
    [INFO]
    [INFO] Zeppelin ........................................... SUCCESS [  6.317 s]
    [INFO] Zeppelin: Interpreter .............................. SUCCESS [02:35 min]
    [INFO] Zeppelin: Zengine .................................. FAILURE [02:48 min]
    ```
    Am I doing something wrong? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1603: [ZEPPELIN-1624] HeliumApplicationFactoryTest fails on ...

Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:

    https://github.com/apache/zeppelin/pull/1603
  
    2 weeks ping @Leemoonsoo 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1603: [ZEPPELIN-1624] HeliumApplicationFactoryTest fails on ...

Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:

    https://github.com/apache/zeppelin/pull/1603
  
    @Leemoonsoo do you think it's worth re-basing on latest master?
    
    Tried `mvn clean package -pl \!zeppelin-distribution` on this branch again, got:
    
    ```
    Results :
    
    Tests in error:
      HeliumApplicationFactoryTest.testUnloadOnInterpreterUnbind:232 � ClassCast jav...
      HeliumApplicationFactoryTest.testLoadRunUnloadApplication:148 � ClassCast java...
      HeliumApplicationFactoryTest.testUnloadOnInterpreterRestart:299 � ClassCast ja...
      HeliumApplicationFactoryTest.testUnloadOnParagraphRemove:193 � ClassCast java....
    
    Tests run: 116, Failures: 0, Errors: 4, Skipped: 0
    
    [INFO] ------------------------------------------------------------------------
    [INFO] Zeppelin ........................................... SUCCESS [  8.249 s]
    [INFO] Zeppelin: Interpreter .............................. SUCCESS [02:30 min]
    [INFO] Zeppelin: Zengine .................................. FAILURE [02:47 min]
    [INFO] Zeppelin: Display system apis ...................... SKIPPED
    ```
    
    My env
    
    ```
    Apache Maven 3.3.3 (7994120775791599e205a5524ec3e0dfe41d4a06; 2015-04-22T20:57:37+09:00)
    Maven home: /usr/local/Cellar/maven/3.3.3/libexec
    Java version: 1.7.0_45, vendor: Oracle Corporation
    Java home: /Library/Java/JavaVirtualMachines/jdk1.7.0_45.jdk/Contents/Home/jre
    Default locale: en_US, platform encoding: UTF-8
    OS name: "mac os x", version: "10.10.5", arch: "x86_64", family: "mac"
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1603: [ZEPPELIN-1624] HeliumApplicationFactoryTest fa...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1603


---

[GitHub] zeppelin issue #1603: [ZEPPELIN-1624] HeliumApplicationFactoryTest fails on ...

Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:

    https://github.com/apache/zeppelin/pull/1603
  
    ping @Leemoonsoo 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---