You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ian Downes <ia...@gmail.com> on 2014/10/02 20:29:10 UTC

Re: Review Request 25864: Add 'Future cgroups::empty()'.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25864/
-----------------------------------------------------------

(Updated Oct. 2, 2014, 11:29 a.m.)


Review request for mesos, Jie Yu and Vinod Kone.


Changes
-------

Minor clean ups.


Repository: mesos-git


Description
-------

Polls cgroups.procs until no processes in the cgroup. Poll interval and timeout can be specified.


Diffs (updated)
-----

  src/linux/cgroups.hpp abf31df1b4dbf6f715f93256b83c9996a45099cf 
  src/linux/cgroups.cpp 62df4b7645c6ab061a47634058d79ca849caa6b9 

Diff: https://reviews.apache.org/r/25864/diff/


Testing
-------


Thanks,

Ian Downes

Re: Review Request 25864: Add 'Future cgroups::empty()'.

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25864/#review56567
-----------------------------------------------------------



src/linux/cgroups.cpp
<https://reviews.apache.org/r/25864/#comment96913>

    It will be nice if you also print the interval.


- Timothy Chen


On Oct. 14, 2014, 8:31 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25864/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2014, 8:31 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Polls cgroups.procs until no processes in the cgroup. Poll interval and timeout can be specified.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.hpp abf31df1b4dbf6f715f93256b83c9996a45099cf 
>   src/linux/cgroups.cpp 62df4b7645c6ab061a47634058d79ca849caa6b9 
> 
> Diff: https://reviews.apache.org/r/25864/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Re: Review Request 25864: Add 'Future cgroups::empty()'.

Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25864/
-----------------------------------------------------------

(Updated Oct. 14, 2014, 1:31 p.m.)


Review request for mesos, Jie Yu and Vinod Kone.


Changes
-------

Missing semicolon.


Repository: mesos-git


Description
-------

Polls cgroups.procs until no processes in the cgroup. Poll interval and timeout can be specified.


Diffs (updated)
-----

  src/linux/cgroups.hpp abf31df1b4dbf6f715f93256b83c9996a45099cf 
  src/linux/cgroups.cpp 62df4b7645c6ab061a47634058d79ca849caa6b9 

Diff: https://reviews.apache.org/r/25864/diff/


Testing
-------


Thanks,

Ian Downes