You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by nikhilkh <gi...@git.apache.org> on 2015/10/24 02:57:33 UTC

[GitHub] cordova-plugin-whitelist pull request: Update whitelist version to...

GitHub user nikhilkh opened a pull request:

    https://github.com/apache/cordova-plugin-whitelist/pull/14

    Update whitelist version to 2.0.0 to support older versions of the CLI

    Older versions of the CLI using cordova-app-hello-world template that references v1 of this plugin and adding a cordova-ios 4.x requirement will cause warnings to show up on existing projects. This is rated as one of the most voted cordova problems on stack overflow:
    http://stackoverflow.com/questions/30991828/cordova-plugin-whitelist-failed-asking-for-cordova-ios-4/30992364#30992364
    I know it's just a warning but users get confused.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nikhilkh/cordova-plugin-whitelist version-bump

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-whitelist/pull/14.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #14
    
----
commit 3078c72c36d1b081de5da7b367ebbded32b046d6
Author: Nikhil Khandelwal <ni...@microsoft.com>
Date:   2015-10-24T00:52:27Z

    Update whitelist version to 2.0.0 as older versions of cordova CLI refernce v1 of this plugin and adding a cordova-ios 4.x requirement will cause warnings to show up on existing projects

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-whitelist pull request: Update whitelist version to...

Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:

    https://github.com/apache/cordova-plugin-whitelist/pull/14#issuecomment-157131444
  
    Thanks, Shaz! This is not needed now. Closing it!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-whitelist pull request: Update whitelist version to...

Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh closed the pull request at:

    https://github.com/apache/cordova-plugin-whitelist/pull/14


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-whitelist pull request: Update whitelist version to...

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-plugin-whitelist/pull/14#issuecomment-157020871
  
    PR Not needed anymore since cordova-ios-4.x will have need of this plugin.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org