You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/02/23 20:59:39 UTC
[GitHub] [tvm] jwfromm opened a new pull request #7509: [Relay][Frontend][Onnx] Fix GEMM converter when C is not a parameter.
jwfromm opened a new pull request #7509:
URL: https://github.com/apache/tvm/pull/7509
The change made to the Onnx gemm converter in #7489 assumes that the value of C will always be a parameter. When it is a constant or an expression, the special case handling will fail. This very tiny PR makes the handling of C more general and adds test cases that would otherwise fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jwfromm commented on pull request #7509: [Relay][Frontend][Onnx] Fix GEMM converter when C is not a parameter.
Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #7509:
URL: https://github.com/apache/tvm/pull/7509#issuecomment-784509291
@mbrookhart @xutianming @masahi can one of you take a look at this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #7509: [Relay][Frontend][Onnx] Fix GEMM converter when C is not a parameter.
Posted by GitBox <gi...@apache.org>.
masahi merged pull request #7509:
URL: https://github.com/apache/tvm/pull/7509
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org