You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "ricardozanini (via GitHub)" <gi...@apache.org> on 2024/11/15 23:24:04 UTC

[PR] [sonataflow-operator] - Migrate SonataFlow operator from incubator-kie-kogito-serverless-operator [incubator-kie-tools]

ricardozanini opened a new pull request, #2747:
URL: https://github.com/apache/incubator-kie-tools/pull/2747

   WIP - A few things left we might have to fix.
   
   @tiagobento it seems that we brought very old commits that I think we should squash; They are related to the `bddframework` that I've removed during the migration. That said, I don't think this unrelated history should be here. Instead, I'd squash until this commit: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] [sonataflow-operator] - Migrate SonataFlow operator from incubator-kie-kogito-serverless-operator [incubator-kie-tools]

Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on PR #2747:
URL: https://github.com/apache/incubator-kie-tools/pull/2747#issuecomment-2489692896

   BIG Mental note for **NOT SQUASHING** this PR when merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] [sonataflow-operator] - Migrate SonataFlow operator from incubator-kie-kogito-serverless-operator [incubator-kie-tools]

Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on PR #2747:
URL: https://github.com/apache/incubator-kie-tools/pull/2747#issuecomment-2484346075

   I will fix the windows problem tomorrow.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] [sonataflow-operator] - Migrate SonataFlow operator from incubator-kie-kogito-serverless-operator [incubator-kie-tools]

Posted by "treblereel (via GitHub)" <gi...@apache.org>.
treblereel commented on code in PR #2747:
URL: https://github.com/apache/incubator-kie-tools/pull/2747#discussion_r1854387913


##########
packages/kn-plugin-workflow/README.md:
##########
@@ -29,7 +29,7 @@ All the commands in this section should be performed in the monorepo root.
 
 - Node `>= 20.14.0` _(To install, follow these instructions: https://nodejs.org/en/download/package-manager/)_
 - pnpm `9.3.0` _(To install, follow these instructions: https://pnpm.io/installation)_
-- Go `1.21.13` _(To install, follow these instructions: https://go.dev/doc/install)_
+- Go `1.22.9` _(To install, follow these instructions: https://go.dev/doc/install)_

Review Comment:
   Maybe it should be go1.23.2 like in the go.mod?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] [sonataflow-operator] - Migrate SonataFlow operator from incubator-kie-kogito-serverless-operator [incubator-kie-tools]

Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento merged PR #2747:
URL: https://github.com/apache/incubator-kie-tools/pull/2747


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] [sonataflow-operator] - Migrate SonataFlow operator from incubator-kie-kogito-serverless-operator [incubator-kie-tools]

Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on code in PR #2747:
URL: https://github.com/apache/incubator-kie-tools/pull/2747#discussion_r1854470655


##########
packages/kn-plugin-workflow/README.md:
##########
@@ -29,7 +29,7 @@ All the commands in this section should be performed in the monorepo root.
 
 - Node `>= 20.14.0` _(To install, follow these instructions: https://nodejs.org/en/download/package-manager/)_
 - pnpm `9.3.0` _(To install, follow these instructions: https://pnpm.io/installation)_
-- Go `1.21.13` _(To install, follow these instructions: https://go.dev/doc/install)_
+- Go `1.22.9` _(To install, follow these instructions: https://go.dev/doc/install)_

Review Comment:
   From what @ricardozanini explained to me, 1.23.2 is only being used for Go's toolchain, which doesn't affect compilation. He'll see if it's worth aligning everything in a future PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] [sonataflow-operator] - Migrate SonataFlow operator from incubator-kie-kogito-serverless-operator [incubator-kie-tools]

Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on PR #2747:
URL: https://github.com/apache/incubator-kie-tools/pull/2747#issuecomment-2489836697

   **DO NOT SQUASH**
   **DO NOT SQUASH**
   **DO NOT SQUASH**
   **DO NOT SQUASH**
   **DO NOT SQUASH**
   **DO NOT SQUASH**
   **DO NOT SQUASH**
   **DO NOT SQUASH**
   **DO NOT SQUASH**
   **DO NOT SQUASH**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] [sonataflow-operator] - Migrate SonataFlow operator from incubator-kie-kogito-serverless-operator [incubator-kie-tools]

Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on PR #2747:
URL: https://github.com/apache/incubator-kie-tools/pull/2747#issuecomment-2489692567

   Mental note for not merging it before squashing the new commits.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] [sonataflow-operator] - Migrate SonataFlow operator from incubator-kie-kogito-serverless-operator [incubator-kie-tools]

Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on PR #2747:
URL: https://github.com/apache/incubator-kie-tools/pull/2747#issuecomment-2491912439

   @wmedvede @treblereel @jakubschwan wanna take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org