[GitHub] [airflow] ryanahamilton commented on a change in pull request #15073: turn off autocomplete for connection forms

[GitBox <gi...@apache.org>]

ryanahamilton commented on a change in pull request #15073:
URL: https://github.com/apache/airflow/pull/15073#discussion_r603521523



##########
File path: airflow/www/static/js/connection_form.js
##########
@@ -59,6 +59,8 @@ function getControlsContainer() {
 $(document).ready(function () {
   const fieldBehavioursElem = document.getElementById('field_behaviours');
   const config = JSON.parse(decode(fieldBehavioursElem.textContent));
+  const form = document.getElementById('model_form');

Review comment:
       Maybe add a comment to make the intensions here clear?
   ```suggestion
     // Prevent login/password fields from triggering browser auth extensions
     const form = document.getElementById('model_form');
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org