You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/13 16:48:38 UTC

[GitHub] [airflow] TobKed commented on pull request #11374: [WIP] Add drain option when canceling Dataflow pipelines

TobKed commented on pull request #11374:
URL: https://github.com/apache/airflow/pull/11374#issuecomment-707873375


   
   >     * Would users generally decide on drain vs cancel when they are starting the operation? (Would they change their minds before onkill?)
   
   Users define this parameter in the code which defines the DAG. AFAIK when DAG is running it is not possible to change this parameters afterwards. User can edit DAG and run it again with the new parameters.
   @turbaszek could you confirm am I right, please?
   
   >     * Would they want to wait until drain is completed? Drain may or may not fully complete in 5 minutes timeout window.
   
   I created separate PR to handle timeout, I think it is good idea to allow configure it so users could decide what timeout is suitable for them.
   https://github.com/apache/airflow/pull/11501
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org