You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/09/07 10:05:12 UTC
[GitHub] [druid] abhishekagarwal87 opened a new pull request, #13043: Reverting #12659 from 24.0 release
abhishekagarwal87 opened a new pull request, #13043:
URL: https://github.com/apache/druid/pull/13043
https://github.com/apache/druid/pull/13027 highlights an issue with current filter matching that was introduced in #12659. Since tackling that can take time, I am going to revert this change from 24 release. So we don't have to worry about backward compatibility as we find the right solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky commented on pull request #13043: Reverting #12659 from 24.0 release
Posted by GitBox <gi...@apache.org>.
vogievetsky commented on PR #13043:
URL: https://github.com/apache/druid/pull/13043#issuecomment-1239457205
I think you also want to remove it from the web console. You need to remove the lines:
https://github.com/apache/druid/blob/master/web-console/src/druid-models/ingestion-spec/ingestion-spec.tsx#L654
https://github.com/apache/druid/blob/master/web-console/src/druid-models/ingestion-spec/ingestion-spec.tsx#L816
https://github.com/apache/druid/blob/master/web-console/src/druid-models/ingestion-spec/ingestion-spec.tsx#L875
https://github.com/apache/druid/blob/master/web-console/src/druid-models/input-source/input-source.tsx#L437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] lgtm-com[bot] commented on pull request #13043: Reverting #12659 from 24.0 release
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on PR #13043:
URL: https://github.com/apache/druid/pull/13043#issuecomment-1239749996
This pull request **introduces 1 alert** when merging 23ec6ba6d60df7411e6e7e3650ec94ec7333406d into 033ae233e8787787473b8eff17e2272db8597f5a - [view on LGTM.com](https://lgtm.com/projects/g/apache/druid/rev/pr-1c92694e4dfb3d70869c9e7f2824e8ff97748191)
**new alerts:**
* 1 for Unused variable, import, function or class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky commented on a diff in pull request #13043: Reverting #12659 from 24.0 release
Posted by GitBox <gi...@apache.org>.
vogievetsky commented on code in PR #13043:
URL: https://github.com/apache/druid/pull/13043#discussion_r964902715
##########
docs/ingestion/native-batch-input-source.md:
##########
@@ -29,7 +29,7 @@ For general information on native batch indexing and parallel task indexing, see
## S3 input source
-> You need to include the [`druid-s3-extensions`](../development/extensions-core/s3.md) as an extension to use the S3 input source.
+> You need to include the [`druid-s3-extensions`](../development/extensions-core/s3.md) as an extension to use the S3 input source.
Review Comment:
This change is a typo right? There is no need for the trailing space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 commented on pull request #13043: Reverting #12659 from 24.0 release
Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 commented on PR #13043:
URL: https://github.com/apache/druid/pull/13043#issuecomment-1239484793
thanks for catching that @vogievetsky. I have removed them in latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky closed pull request #13043: Reverting #12659 from 24.0 release
Posted by GitBox <gi...@apache.org>.
vogievetsky closed pull request #13043: Reverting #12659 from 24.0 release
URL: https://github.com/apache/druid/pull/13043
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky commented on pull request #13043: Reverting #12659 from 24.0 release
Posted by GitBox <gi...@apache.org>.
vogievetsky commented on PR #13043:
URL: https://github.com/apache/druid/pull/13043#issuecomment-1239777125
the alert about `const inputSourceFilter: Field<IoConfig> = {` not being needed is obviously a nothing burger but it might fail CI due to our tslint validation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky commented on pull request #13043: Reverting #12659 from 24.0 release
Posted by GitBox <gi...@apache.org>.
vogievetsky commented on PR #13043:
URL: https://github.com/apache/druid/pull/13043#issuecomment-1239838966
closing this PR in favor of: https://github.com/apache/druid/pull/13046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky commented on pull request #13043: Reverting #12659 from 24.0 release
Posted by GitBox <gi...@apache.org>.
vogievetsky commented on PR #13043:
URL: https://github.com/apache/druid/pull/13043#issuecomment-1239812016
Ok I can confirm that it will fail. But if you remove https://github.com/abhishekagarwal87/druid/blob/revert_glob_filter_2/web-console/src/druid-models/ingestion-spec/ingestion-spec.tsx#L457 then it will pass all web console tests (unit and e2e), just confirmed locally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] kfaraz commented on a diff in pull request #13043: Reverting #12659 from 24.0 release
Posted by GitBox <gi...@apache.org>.
kfaraz commented on code in PR #13043:
URL: https://github.com/apache/druid/pull/13043#discussion_r964908343
##########
docs/ingestion/native-batch-input-source.md:
##########
@@ -29,7 +29,7 @@ For general information on native batch indexing and parallel task indexing, see
## S3 input source
-> You need to include the [`druid-s3-extensions`](../development/extensions-core/s3.md) as an extension to use the S3 input source.
+> You need to include the [`druid-s3-extensions`](../development/extensions-core/s3.md) as an extension to use the S3 input source.
Review Comment:
Yeah, the trailing space was removed in the original PR. Reverting that commit would have brought back this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org