You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/04/21 09:49:25 UTC

[GitHub] [echarts] randomCards opened a new issue #14735: line overlap label in simple chart

randomCards opened a new issue #14735:
URL: https://github.com/apache/echarts/issues/14735


   ### Version
   5.1.0
   
   ### Steps to reproduce
   open the editor on https://echarts.apache.org/examples/en/editor.html an paste:
   
   option = {
       xAxis: {
           data: ['周一', '周二', '周三', '周四', '周五', '周六', '周一', '周二', '周三', '周四', '周五', '周六','周一', '周二', '周三', '周四', '周五', '周六','周一', '周二', '周三', '周四', '周五', '周六','周一', '周二', '周三', '周四', '周五', '周六','周一', '周二', '周三', '周四', '周五', '周六',],
           axisPointer: {
             show: true,
           }
       },
       yAxis: {
           type: 'value',
       },
       series: [
           {
               type: 'line',
               data: [120, 132, 101, 134, 90, 230, 120, 132, 101, 134, 90, 230,120, 132, 101, 134, 90, 230,120, 132, 101, 134, 90, 230,120, 132, 101, 134, 90, 230,120, 132, 101, 134, 90, 230,120, 132, 101, 134, 90, 230,120, 132, 101, 134, 90, 230,120, 132, 101, 134, 90, 230,120, 132, 101, 134, 90, 230,120, 132, 101, 134, 90, 230,],
               showSymbol: false,
               label: {
                   show: true,
               },
           },
       ]
   };
   
   ### What is expected?
   the line does not overlap the label
   
   ### What is actually happening?
   the line overlaps the label
   
   <!-- This issue is generated by echarts-issue-helper. DO NOT REMOVE -->
   <!-- This issue is in English. DO NOT REMOVE -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] pissang closed issue #14735: line overlap label in simple chart

Posted by GitBox <gi...@apache.org>.
pissang closed issue #14735:
URL: https://github.com/apache/echarts/issues/14735


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] plainheart edited a comment on issue #14735: line overlap label in simple chart

Posted by GitBox <gi...@apache.org>.
plainheart edited a comment on issue #14735:
URL: https://github.com/apache/echarts/issues/14735#issuecomment-842866302


   @pissang The symbol is temporary, it's not controlled by echarts#updateZ. Whatever the z value is large, it takes no effect. Maybe we should set z rather than z2, or in some other way?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] echarts-bot[bot] commented on issue #14735: line overlap label in simple chart

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #14735:
URL: https://github.com/apache/echarts/issues/14735#issuecomment-823932853






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] pissang commented on issue #14735: line overlap label in simple chart

Posted by GitBox <gi...@apache.org>.
pissang commented on issue #14735:
URL: https://github.com/apache/echarts/issues/14735#issuecomment-842225859


   @plainheart z2 of label will be updated automatically in the https://github.com/apache/echarts/blob/master/src/core/echarts.ts#L2233


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] pissang edited a comment on issue #14735: line overlap label in simple chart

Posted by GitBox <gi...@apache.org>.
pissang edited a comment on issue #14735:
URL: https://github.com/apache/echarts/issues/14735#issuecomment-843698146


   @plainheart Sorry I mistake it. You are right, `z` and `zlevel` should all be set. They can be either got from `this._polyline.z` or from `seriesModel.get('z')`. And the original `z2` code is also needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] pissang edited a comment on issue #14735: line overlap label in simple chart

Posted by GitBox <gi...@apache.org>.
pissang edited a comment on issue #14735:
URL: https://github.com/apache/echarts/issues/14735#issuecomment-843698146


   @plainheart Sorry I mistake it. You are right, `z` and `zlevel` should all be set. They can be got either from `this._polyline.z` or from `seriesModel.get('z')`. And the original `z2` code is also needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] plainheart edited a comment on issue #14735: line overlap label in simple chart

Posted by GitBox <gi...@apache.org>.
plainheart edited a comment on issue #14735:
URL: https://github.com/apache/echarts/issues/14735#issuecomment-842866302


   @pissang The symbol is temporary, it's not controlled by echarts#updateZ. Whatever the z value is large, it takes no effect. Maybe we should set z rather than z2, or in some other way?
   
   ```ts
   const symbolLabel = symbol.getSymbolPath().getTextContent();
   symbolLabel && (symbolLabel.z = this._polyline.z);
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] pissang commented on issue #14735: line overlap label in simple chart

Posted by GitBox <gi...@apache.org>.
pissang commented on issue #14735:
URL: https://github.com/apache/echarts/issues/14735#issuecomment-842225859


   @plainheart z2 of label will be updated automatically in the https://github.com/apache/echarts/blob/master/src/core/echarts.ts#L2233


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] plainheart edited a comment on issue #14735: line overlap label in simple chart

Posted by GitBox <gi...@apache.org>.
plainheart edited a comment on issue #14735:
URL: https://github.com/apache/echarts/issues/14735#issuecomment-823942307


   Related to #14541. It seems #14542 didn't solve it yet. [src/chart/line/LineView.ts#L844-L846](https://github.com/apache/echarts/blob/master/src/chart/line/LineView.ts#L844-L846)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] plainheart commented on issue #14735: line overlap label in simple chart

Posted by GitBox <gi...@apache.org>.
plainheart commented on issue #14735:
URL: https://github.com/apache/echarts/issues/14735#issuecomment-842866302


   @pissang The symbol is temporal, it's not controlled by echarts#updateZ. Whatever the z value is large, it takes no effect. Maybe we should set z rather than z2, or in some other way?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] pissang commented on issue #14735: line overlap label in simple chart

Posted by GitBox <gi...@apache.org>.
pissang commented on issue #14735:
URL: https://github.com/apache/echarts/issues/14735#issuecomment-843698146


   @plainheart Sorry I mistake it. You are right, `z` and `zlevel` should all be set. The can be got from `this._polyline.z` or `seriesModel.get('z')`. And the original `z2` code is also needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] plainheart commented on issue #14735: line overlap label in simple chart

Posted by GitBox <gi...@apache.org>.
plainheart commented on issue #14735:
URL: https://github.com/apache/echarts/issues/14735#issuecomment-823942307


   Related to #14541. It seems #14542 didn't solve it yet.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] plainheart edited a comment on issue #14735: line overlap label in simple chart

Posted by GitBox <gi...@apache.org>.
plainheart edited a comment on issue #14735:
URL: https://github.com/apache/echarts/issues/14735#issuecomment-842866302


   @pissang The symbol is temporary, it's not controlled by echarts#updateZ. Whatever the z2 value is large, it takes no effect. Maybe we should set z rather than z2, or in some other way?
   
   ```ts
   const symbolLabel = symbol.getSymbolPath().getTextContent();
   symbolLabel && (symbolLabel.z = this._polyline.z);
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org