You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/05/10 10:12:17 UTC

[GitHub] [hudi] MyLanPangzi commented on a change in pull request #2930: [HUDI-1818] Validate and check required option for HoodieTable (Azure…

MyLanPangzi commented on a change in pull request #2930:
URL: https://github.com/apache/hudi/pull/2930#discussion_r629237005



##########
File path: hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableFactory.java
##########
@@ -98,6 +102,33 @@ public String factoryIdentifier() {
   //  Utilities
   // -------------------------------------------------------------------------
 
+  /** Validate required options. e.g record key and pre combine key.
+   *
+   * @param conf The table options
+   * @param schema The table schema
+   */
+  private void validateRequiredOptions(Configuration conf, TableSchema schema) {

Review comment:
       good, rename the method.
   partitioned table needn't validate.it has default partiton value.we just verify hoodie required fields.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org