[GitHub] [camel-k] squakez commented on a diff in pull request #4162: fix(cli): Remove CamelCatalogs CR on kamel uninstall

["squakez (via GitHub)" <gi...@apache.org>]

squakez commented on code in PR #4162:
URL: https://github.com/apache/camel-k/pull/4162#discussion_r1147457200


##########
pkg/cmd/uninstall.go:
##########
@@ -62,6 +63,7 @@ func newCmdUninstall(rootCmdOptions *RootCmdOptions) (*cobra.Command, *uninstall
 	cmd.Flags().Bool("skip-config-maps", false, "Do not uninstall the Camel K Config Maps in the current namespace")
 	cmd.Flags().Bool("skip-registry-secret", false, "Do not uninstall the Camel K Registry Secret in the current namespace")
 	cmd.Flags().Bool("skip-kamelets", false, "Do not uninstall the Kamelets in the current namespace")
+	cmd.Flags().Bool("skip-camel-catalogs", false, "Do not uninstall the Camel Catalogs in the current namespace")

Review Comment:
   +1 for this. Really good idea, thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org