You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/11/04 22:11:18 UTC
[GitHub] [kafka] hgeraldino opened a new pull request, #12825: KAFKA-14354: Add deleted() callback method to Connector
hgeraldino opened a new pull request, #12825:
URL: https://github.com/apache/kafka/pull/12825
This PR contains a small change to the Connector public API, and a few tweaks on the Worker/WorkerConnector and Herder classes - all this in context of [KIP-893](https://cwiki.apache.org/confluence/display/KAFKA/KIP-883%3A+Add+delete+callback+method+to+Connector+API). Since this KIP is still under discussion, this PR should not be merged to trunk.
Main changes include:
* Adds a new public void `deleted()` callback method to the `org.apache.kafka.connect.connector.Connector` class
* Changes some internal methods of the Worker and WorkerConnector classes to invoke this method when the connector has been stopped due to a deletion.
* Similarly, updates the Standalone and Distributed Herder classes to pass the `deleted` flag when deleting connectors.
* Updated unit tests to validate the new behavior.
The change is relatively small in nature.; please let me know if you think more tests should be added.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hgeraldino closed pull request #12825: KAFKA-14354: Add isDeleted parameter to Connector#stop()
Posted by "hgeraldino (via GitHub)" <gi...@apache.org>.
hgeraldino closed pull request #12825: KAFKA-14354: Add isDeleted parameter to Connector#stop()
URL: https://github.com/apache/kafka/pull/12825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org