You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2017/03/24 05:08:04 UTC
Re: Review Request 57860: Docker environment gets passed on docker run
command.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57860/
-----------------------------------------------------------
(Updated March 24, 2017, 5:08 a.m.)
Review request for mesos, Adam B, Alexander Rukletsov, Gilbert Song, James DeFelice, Jie Yu, and Joseph Wu.
Changes
-------
Removed unrelated patch that snuck in.
Bugs: MESOS-6951
https://issues.apache.org/jira/browse/MESOS-6951
Repository: mesos
Description
-------
Removes the use of --env_file as that does not support newlines in
environment variable values.
Removes leaking of possibly sensitive environment variables to the log.
Manually backported for 1.2.x.
Diffs (updated)
-----
src/docker/docker.cpp 68042fd6f3b19c12cddd0d2e74ae064ceceb6a8c
Diff: https://reviews.apache.org/r/57860/diff/3/
Changes: https://reviews.apache.org/r/57860/diff/2-3/
Testing
-------
make check & sudo ./bin/mesos-tests.sh
Functional testing.
Thanks,
Till Toenshoff
Re: Review Request 57860: Docker environment gets passed on docker run
command.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57860/#review169980
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On March 24, 2017, 5:08 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57860/
> -----------------------------------------------------------
>
> (Updated March 24, 2017, 5:08 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rukletsov, Gilbert Song, James DeFelice, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-6951
> https://issues.apache.org/jira/browse/MESOS-6951
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removes the use of --env_file as that does not support newlines
> in environment variable values. Also avoids leaking of possibly
> sensitive environment variables to the log.
>
> Manually backported for 1.2.x.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp 68042fd6f3b19c12cddd0d2e74ae064ceceb6a8c
>
>
> Diff: https://reviews.apache.org/r/57860/diff/4/
>
>
> Testing
> -------
>
> make check & sudo ./bin/mesos-tests.sh
>
> Functional testing.
>
>
> Thanks,
>
> Till Toenshoff
>
>