[GitHub] [solr] cpoerschke commented on pull request #248: SOLR-6156: Fix NullPointerException if group.field grouping is used with rows=0 and timeAllowed

[GitBox <gi...@apache.org>]

cpoerschke commented on pull request #248:
URL: https://github.com/apache/solr/pull/248#issuecomment-900419308


   selected code path links that may be helpful when code reviewing this change:
   
   * `CommandHandler.searchWithTimeLimiter` is passed a null `collector` if called from https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.9.0/solr/core/src/java/org/apache/solr/search/grouping/CommandHandler.java#L164
   
   * `null` is passed if the https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.9.0/solr/core/src/java/org/apache/solr/search/grouping/CommandHandler.java#L149-L151 loop left the `collectors` list empty.
   
   * `CommandHandler.execute` is called by `QueryComponent.doProcessGroupedDistributedSearchFirstPhase` code: https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.9.0/solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java#L1330
   
   * `SearchGroupsFieldCommand.create` can return an empty list as per https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.9.0/solr/core/src/java/org/apache/solr/search/grouping/distributed/command/SearchGroupsFieldCommand.java#L100-L122
   
   https://issues.apache.org/jira/browse/SOLR-6156 also has more context.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org