You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/13 03:31:29 UTC
[GitHub] [iceberg] felixYyu opened a new issue, #4762: API: The return value of method is always null in IndexById
felixYyu opened a new issue, #4762:
URL: https://github.com/apache/iceberg/issues/4762
I'm looking at the index code, The override method in IndexByName or IndexParents all return the corresponding variables, but IndexById is not, I think it should also needs to return the corresponding variable? cc: @rdblue
The last version:
```
@Override
public Map<Integer, Types.NestedField> field(
Types.NestedField field, Map<Integer, Types.NestedField> fieldResult) {
index.put(field.fieldId(), field);
return null;
}
@Override
public Map<Integer, Types.NestedField> list(Types.ListType list, Map<Integer, Types.NestedField> elementResult) {
for (Types.NestedField field : list.fields()) {
index.put(field.fieldId(), field);
}
return null;
}
@Override
public Map<Integer, Types.NestedField> map(
Types.MapType map, Map<Integer, Types.NestedField> keyResult, Map<Integer, Types.NestedField> valueResult) {
for (Types.NestedField field : map.fields()) {
index.put(field.fieldId(), field);
}
return null;
}
```
>
The return value may not always return null:
```
@Override
public Map<Integer, Types.NestedField> field(
Types.NestedField field, Map<Integer, Types.NestedField> fieldResult) {
index.put(field.fieldId(), field);
return index;
}
@Override
public Map<Integer, Types.NestedField> list(Types.ListType list, Map<Integer, Types.NestedField> elementResult) {
for (Types.NestedField field : list.fields()) {
index.put(field.fieldId(), field);
}
return index;
}
@Override
public Map<Integer, Types.NestedField> map(
Types.MapType map, Map<Integer, Types.NestedField> keyResult, Map<Integer, Types.NestedField> valueResult) {
for (Types.NestedField field : map.fields()) {
index.put(field.fieldId(), field);
}
return index;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] github-actions[bot] commented on issue #4762: API: The return value of method is always null in IndexById
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #4762:
URL: https://github.com/apache/iceberg/issues/4762#issuecomment-1311066602
This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] github-actions[bot] commented on issue #4762: API: The return value of method is always null in IndexById
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #4762:
URL: https://github.com/apache/iceberg/issues/4762#issuecomment-1327937124
This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] github-actions[bot] closed issue #4762: API: The return value of method is always null in IndexById
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed issue #4762: API: The return value of method is always null in IndexById
URL: https://github.com/apache/iceberg/issues/4762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] felixYyu commented on issue #4762: API: The return value of method is always null in IndexById
Posted by GitBox <gi...@apache.org>.
felixYyu commented on issue #4762:
URL: https://github.com/apache/iceberg/issues/4762#issuecomment-1126601430
cc @mccheah
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org