[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4233: Remove depependency on Kafka stream implementation classes from pinot-core and pinot-controller tests

[GitBox <gi...@apache.org>]

kishoreg commented on a change in pull request #4233: Remove depependency on Kafka stream implementation classes from pinot-core and pinot-controller tests
URL: https://github.com/apache/incubator-pinot/pull/4233#discussion_r287017047
 
 

 ##########
 File path: pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/sharding/SegmentAssignmentStrategyTest.java
 ##########
 @@ -255,15 +253,20 @@ public void testRealtimeReplicaGroupPartitionAssignment() {
 
     Map<String, String> streamConfigMap = new HashMap<>();
     String type = "kafka";
+    String consumerFactoryClass = "com.test.TestConsumerFactoryClass";
 
 Review comment:
   looks like this class does not exist. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org