[GitHub] [spark] holdenk commented on a change in pull request #30155: [SPARK-33231][CORE] Make pod allocation executor timeouts configurable

[GitBox <gi...@apache.org>]

holdenk commented on a change in pull request #30155:
URL: https://github.com/apache/spark/pull/30155#discussion_r512336669



##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
##########
@@ -214,10 +216,9 @@ private[spark] class ExecutorPodsAllocator(
     }
 
     if (newlyCreatedExecutors.isEmpty
-        && currentPendingExecutors.isEmpty
-        && currentRunningCount < currentTotalExpectedExecutors) {
+        && knownPodCount < currentTotalExpectedExecutors) {

Review comment:
       So it's not unrelated, but I can give it a second JIRA? Having more time available means that depending on currentRunningCount can be stale information.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org