You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Gary Dusbabek (JIRA)" <ji...@apache.org> on 2011/02/08 19:06:57 UTC

[jira] Created: (CASSANDRA-2140) versioning isn't going to work when forwarding messages

versioning isn't going to work when forwarding messages
-------------------------------------------------------

                 Key: CASSANDRA-2140
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2140
             Project: Cassandra
          Issue Type: Bug
          Components: Core
            Reporter: Gary Dusbabek
            Assignee: Gary Dusbabek
             Fix For: 0.8


SP.sendToHintedEndpoints needs to take care to create properly versioned messages that get forwarded to other nodes.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CASSANDRA-2140) versioning isn't going to work when forwarding messages

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12992703#comment-12992703 ] 

Hudson commented on CASSANDRA-2140:
-----------------------------------

Integrated in Cassandra #719 (See [https://hudson.apache.org/hudson/job/Cassandra/719/])
    MessageProducer int to Integer. patch by gdusbabek, reviewed by jbellis. CASSANDRA-2140
fix misspeeling. patch by gdusbabek, reviewed by jbellis. CASSANDRA-2140
cache versioned messages in StorageProxy. patch by gdusbabek, reviewed by jbellis. CASSANDRA-2140


> versioning isn't going to work when forwarding messages
> -------------------------------------------------------
>
>                 Key: CASSANDRA-2140
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2140
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Gary Dusbabek
>            Assignee: Gary Dusbabek
>             Fix For: 0.8
>
>         Attachments: v2-0001-cache-versioned-messages-in-StorageProxy.txt, v2-0002-fix-misspeeling.txt, v2-0003-MessageProducer-int-to-Integer.txt
>
>
> SP.sendToHintedEndpoints needs to take care to create properly versioned messages that get forwarded to other nodes.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (CASSANDRA-2140) versioning isn't going to work when forwarding messages

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Dusbabek updated CASSANDRA-2140:
-------------------------------------

    Attachment: v2-0003-MessageProducer-int-to-Integer.txt
                v2-0002-fix-misspeeling.txt
                v2-0001-cache-versioned-messages-in-StorageProxy.txt

> versioning isn't going to work when forwarding messages
> -------------------------------------------------------
>
>                 Key: CASSANDRA-2140
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2140
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Gary Dusbabek
>            Assignee: Gary Dusbabek
>             Fix For: 0.8
>
>         Attachments: v2-0001-cache-versioned-messages-in-StorageProxy.txt, v2-0002-fix-misspeeling.txt, v2-0003-MessageProducer-int-to-Integer.txt
>
>
> SP.sendToHintedEndpoints needs to take care to create properly versioned messages that get forwarded to other nodes.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (CASSANDRA-2140) versioning isn't going to work when forwarding messages

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Dusbabek updated CASSANDRA-2140:
-------------------------------------

    Attachment:     (was: v1-0001-cache-versioned-messages-in-StorageProxy.txt)

> versioning isn't going to work when forwarding messages
> -------------------------------------------------------
>
>                 Key: CASSANDRA-2140
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2140
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Gary Dusbabek
>            Assignee: Gary Dusbabek
>             Fix For: 0.8
>
>         Attachments: v2-0001-cache-versioned-messages-in-StorageProxy.txt, v2-0002-fix-misspeeling.txt, v2-0003-MessageProducer-int-to-Integer.txt
>
>
> SP.sendToHintedEndpoints needs to take care to create properly versioned messages that get forwarded to other nodes.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CASSANDRA-2140) versioning isn't going to work when forwarding messages

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12992576#comment-12992576 ] 

Jonathan Ellis commented on CASSANDRA-2140:
-------------------------------------------

+1 to the approach.  a couple possible improvements:

- I think all the calls to sendRR(prod.getMessage(Gossiper..), endpoint, handler) can be replaced with sendRR(prod, endpoint, handler)?
- Let's make CMP less wasteful by giving initialcapacity of 2 (common case: everyone is on same versio -- it gets multipled by load factor, so 2 gets rounded down to 1) and making getMessage take an Integer (so we auto[un]box zero times instead of 4)


> versioning isn't going to work when forwarding messages
> -------------------------------------------------------
>
>                 Key: CASSANDRA-2140
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2140
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Gary Dusbabek
>            Assignee: Gary Dusbabek
>             Fix For: 0.8
>
>         Attachments: v1-0001-cache-versioned-messages-in-StorageProxy.txt, v1-0002-fix-misspeeling.txt
>
>
> SP.sendToHintedEndpoints needs to take care to create properly versioned messages that get forwarded to other nodes.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (CASSANDRA-2140) versioning isn't going to work when forwarding messages

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Dusbabek updated CASSANDRA-2140:
-------------------------------------

    Attachment: v1-0002-fix-misspeeling.txt
                v1-0001-cache-versioned-messages-in-StorageProxy.txt

> versioning isn't going to work when forwarding messages
> -------------------------------------------------------
>
>                 Key: CASSANDRA-2140
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2140
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Gary Dusbabek
>            Assignee: Gary Dusbabek
>             Fix For: 0.8
>
>         Attachments: v1-0001-cache-versioned-messages-in-StorageProxy.txt, v1-0002-fix-misspeeling.txt
>
>
> SP.sendToHintedEndpoints needs to take care to create properly versioned messages that get forwarded to other nodes.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (CASSANDRA-2140) versioning isn't going to work when forwarding messages

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Dusbabek updated CASSANDRA-2140:
-------------------------------------

    Attachment:     (was: v1-0002-fix-misspeeling.txt)

> versioning isn't going to work when forwarding messages
> -------------------------------------------------------
>
>                 Key: CASSANDRA-2140
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2140
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Gary Dusbabek
>            Assignee: Gary Dusbabek
>             Fix For: 0.8
>
>         Attachments: v2-0001-cache-versioned-messages-in-StorageProxy.txt, v2-0002-fix-misspeeling.txt, v2-0003-MessageProducer-int-to-Integer.txt
>
>
> SP.sendToHintedEndpoints needs to take care to create properly versioned messages that get forwarded to other nodes.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CASSANDRA-2140) versioning isn't going to work when forwarding messages

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12992649#comment-12992649 ] 

Gary Dusbabek commented on CASSANDRA-2140:
------------------------------------------

v2 makes suggested improvements.

> versioning isn't going to work when forwarding messages
> -------------------------------------------------------
>
>                 Key: CASSANDRA-2140
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2140
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Gary Dusbabek
>            Assignee: Gary Dusbabek
>             Fix For: 0.8
>
>         Attachments: v2-0001-cache-versioned-messages-in-StorageProxy.txt, v2-0002-fix-misspeeling.txt, v2-0003-MessageProducer-int-to-Integer.txt
>
>
> SP.sendToHintedEndpoints needs to take care to create properly versioned messages that get forwarded to other nodes.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CASSANDRA-2140) versioning isn't going to work when forwarding messages

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-2140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12992664#comment-12992664 ] 

Jonathan Ellis commented on CASSANDRA-2140:
-------------------------------------------

+1

> versioning isn't going to work when forwarding messages
> -------------------------------------------------------
>
>                 Key: CASSANDRA-2140
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2140
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Gary Dusbabek
>            Assignee: Gary Dusbabek
>             Fix For: 0.8
>
>         Attachments: v2-0001-cache-versioned-messages-in-StorageProxy.txt, v2-0002-fix-misspeeling.txt, v2-0003-MessageProducer-int-to-Integer.txt
>
>
> SP.sendToHintedEndpoints needs to take care to create properly versioned messages that get forwarded to other nodes.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira