You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2017/05/09 14:46:19 UTC
Re: Review Request 58952: Added test helper to disambiguate allocator
method call.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58952/
-----------------------------------------------------------
(Updated May 9, 2017, 4:46 p.m.)
Review request for mesos, Benjamin Mahler, Jie Yu, and Jan Schlicht.
Changes
-------
Rebased.
Summary (updated)
-----------------
Added test helper to disambiguate allocator method call.
Bugs: MESOS-7388
https://issues.apache.org/jira/browse/MESOS-7388
Repository: mesos
Description
-------
In a subsequent commit we will transitionally introduce a second
'addFramework' allocator method overload where the 'used' set refers
to 'ResourceProviderID's instead of 'SlaveID's. Introduce a test
helper here to remove a future ambiguity when an empty set '{}' is
passed. We introduce this in a separate patch so that this change can
more easily be removed one the old allocator method is removed and the
ambiguity vanishes.
Diffs (updated)
-----
src/tests/hierarchical_allocator_tests.cpp 08180b9975869de328f0c095dd3cddf0c84fbecf
Diff: https://reviews.apache.org/r/58952/diff/2/
Changes: https://reviews.apache.org/r/58952/diff/1-2/
Testing
-------
`make check`
Thanks,
Benjamin Bannier