You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2020/08/25 00:17:00 UTC
Re: Review Request 72799: Fixed a bug in CSI server initialization.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72799/
-----------------------------------------------------------
(Updated Aug. 25, 2020, 12:16 a.m.)
Review request for mesos, Andrei Budnik and Qian Zhang.
Summary (updated)
-----------------
Fixed a bug in CSI server initialization.
Repository: mesos
Description (updated)
-------
Previously, the CSI server would initialize the service
managers before the auth token was generated, meaning
that requests made by the service managers to an agent
which requires HTTP authentication would fail.
This patch changes the order of initialization so that
the service managers will be initialized with a valid
auth token when necessary.
Diffs (updated)
-----
src/slave/csi_server.cpp 0ffe020412dd3170d34052ebbbdc7f320c4cb31a
Diff: https://reviews.apache.org/r/72799/diff/2/
Changes: https://reviews.apache.org/r/72799/diff/1-2/
Testing
-------
`make check`
Thanks,
Greg Mann
Re: Review Request 72799: Fixed a bug in CSI server initialization.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72799/#review221700
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Zhang
On Aug. 25, 2020, 8:16 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72799/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2020, 8:16 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, the CSI server would initialize the service
> managers before the auth token was generated, meaning
> that requests made by the service managers to an agent
> which requires HTTP authentication would fail.
>
> This patch changes the order of initialization so that
> the service managers will be initialized with a valid
> auth token when necessary.
>
>
> Diffs
> -----
>
> src/slave/csi_server.cpp 0ffe020412dd3170d34052ebbbdc7f320c4cb31a
>
>
> Diff: https://reviews.apache.org/r/72799/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72799: Fixed a bug in CSI server initialization.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72799/
-----------------------------------------------------------
(Updated Aug. 25, 2020, 1:02 a.m.)
Review request for mesos, Andrei Budnik and Qian Zhang.
Repository: mesos
Description
-------
Previously, the CSI server would initialize the service
managers before the auth token was generated, meaning
that requests made by the service managers to an agent
which requires HTTP authentication would fail.
This patch changes the order of initialization so that
the service managers will be initialized with a valid
auth token when necessary.
Diffs
-----
src/slave/csi_server.cpp 0ffe020412dd3170d34052ebbbdc7f320c4cb31a
Diff: https://reviews.apache.org/r/72799/diff/2/
Testing
-------
`make check`
Thanks,
Greg Mann