You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@streampipes.apache.org by ze...@apache.org on 2024/07/30 16:11:42 UTC
(streampipes) branch dev updated: fix(#3076): Correctly close dialogs when use clicks somewhere on the screen (#3077)
This is an automated email from the ASF dual-hosted git repository.
zehnder pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/streampipes.git
The following commit(s) were added to refs/heads/dev by this push:
new 58559f7f05 fix(#3076): Correctly close dialogs when use clicks somewhere on the screen (#3077)
58559f7f05 is described below
commit 58559f7f05ebfb05a0a784c22680a4bfc7253e02
Author: Philipp Zehnder <te...@users.noreply.github.com>
AuthorDate: Tue Jul 30 18:11:36 2024 +0200
fix(#3076): Correctly close dialogs when use clicks somewhere on the screen (#3077)
* fix(#3076): Correctly close dialogs when use clicks somewhere on the screen
* fix(#3076): Fix linting
---
.../shared-ui/src/lib/dialog/base-dialog/base-dialog.service.ts | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/ui/projects/streampipes/shared-ui/src/lib/dialog/base-dialog/base-dialog.service.ts b/ui/projects/streampipes/shared-ui/src/lib/dialog/base-dialog/base-dialog.service.ts
index f7e38cea61..5c29a16d2a 100644
--- a/ui/projects/streampipes/shared-ui/src/lib/dialog/base-dialog/base-dialog.service.ts
+++ b/ui/projects/streampipes/shared-ui/src/lib/dialog/base-dialog/base-dialog.service.ts
@@ -102,8 +102,12 @@ export class DialogService {
overlayRef.dispose();
}
});
+
if (!config.disableClose) {
- overlayRef.backdropClick().subscribe(() => overlayRef.dispose());
+ overlayRef.backdropClick().subscribe(() => {
+ panelDialogComponentRef.instance.close();
+ overlayRef.dispose();
+ });
}
}