You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wookie.apache.org by "Steve Lee (JIRA)" <ji...@apache.org> on 2012/09/06 22:16:08 UTC

[jira] [Created] (WOOKIE-366) Update to the Walkthrough template and test widget

Steve Lee created WOOKIE-366:
--------------------------------

             Summary: Update to the Walkthrough template and test widget
                 Key: WOOKIE-366
                 URL: https://issues.apache.org/jira/browse/WOOKIE-366
             Project: Wookie
          Issue Type: Improvement
          Components: Template
            Reporter: Steve Lee
            Priority: Minor
         Attachments: walkthough.diff

Here is a patch for the Walkthrough Template and test widget. New features include

* Improved the 'Save Actions' to be a web page rather than alert. This includes a print button
* Can specify question set in URL query string
* Various bug fixes  
* Test widget is now both a list of the tests and a data set to try them on
* Readme updated with details on creating a widget form the template

I have also created a simple demo widget with the 'grape' question set. How do I get this to be included as a demo widget?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WOOKIE-366) Update to the Walkthrough template and test widget

Posted by "Steve Lee (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WOOKIE-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450600#comment-13450600 ] 

Steve Lee commented on WOOKIE-366:
----------------------------------

Thank you

> I've applied this patch but it was pretty hard work because of the numjber of unconnected fixes within it. Please provide smaller patches, each tackling a single item, so they are easier to review and apply.

Understood

> Also note that you upgraded the version of JQuery and JQuery Mobile used but this patch did not remove the old ones or add the new ones. I fixed that.
> The comment indicates there is a new data set in the test widget but I do not see that in the patch - forgot to add?

My mistake as svn diffs naturally ignores new files in the workspace. I will provide another patch to fix

> The test widget, however, was still configured to use the old JQuery versions and so it failed. I fixed that.

Thanks - that was an oversight. The upgrade was mainly to hopefully fix some problems with old IE versions, unfortunately has little impact. Still we should move on from the RC version we were using. 

                
> Update to the Walkthrough template and test widget
> --------------------------------------------------
>
>                 Key: WOOKIE-366
>                 URL: https://issues.apache.org/jira/browse/WOOKIE-366
>             Project: Wookie
>          Issue Type: Improvement
>          Components: Template
>    Affects Versions: 0.11.0
>            Reporter: Steve Lee
>            Priority: Minor
>              Labels: patch
>         Attachments: walkthough.diff
>
>
> Here is a patch for the Walkthrough Template and test widget. New features include
> * Improved the 'Save Actions' to be a web page rather than alert. This includes a print button
> * Can specify question set in URL query string
> * Various bug fixes  
> * Test widget is now both a list of the tests and a data set to try them on
> * Readme updated with details on creating a widget form the template
> I have also created a simple demo widget with the 'grape' question set. How do I get this to be included as a demo widget?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (WOOKIE-366) Update to the Walkthrough template and test widget

Posted by "Scott Wilson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WOOKIE-366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Wilson updated WOOKIE-366:
--------------------------------

    Fix Version/s: 0.13.0

Marking as fixed in 0.13.0
                
> Update to the Walkthrough template and test widget
> --------------------------------------------------
>
>                 Key: WOOKIE-366
>                 URL: https://issues.apache.org/jira/browse/WOOKIE-366
>             Project: Wookie
>          Issue Type: Improvement
>          Components: Template
>    Affects Versions: 0.11.0
>            Reporter: Steve Lee
>            Priority: Minor
>              Labels: patch
>             Fix For: 0.13.0
>
>         Attachments: walkthough.diff
>
>
> Here is a patch for the Walkthrough Template and test widget. New features include
> * Improved the 'Save Actions' to be a web page rather than alert. This includes a print button
> * Can specify question set in URL query string
> * Various bug fixes  
> * Test widget is now both a list of the tests and a data set to try them on
> * Readme updated with details on creating a widget form the template
> I have also created a simple demo widget with the 'grape' question set. How do I get this to be included as a demo widget?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (WOOKIE-366) Update to the Walkthrough template and test widget

Posted by "Steve Lee (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WOOKIE-366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Lee updated WOOKIE-366:
-----------------------------

    Attachment: walkthough.diff

Patch
                
> Update to the Walkthrough template and test widget
> --------------------------------------------------
>
>                 Key: WOOKIE-366
>                 URL: https://issues.apache.org/jira/browse/WOOKIE-366
>             Project: Wookie
>          Issue Type: Improvement
>          Components: Template
>            Reporter: Steve Lee
>            Priority: Minor
>              Labels: patch
>         Attachments: walkthough.diff
>
>
> Here is a patch for the Walkthrough Template and test widget. New features include
> * Improved the 'Save Actions' to be a web page rather than alert. This includes a print button
> * Can specify question set in URL query string
> * Various bug fixes  
> * Test widget is now both a list of the tests and a data set to try them on
> * Readme updated with details on creating a widget form the template
> I have also created a simple demo widget with the 'grape' question set. How do I get this to be included as a demo widget?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WOOKIE-366) Update to the Walkthrough template and test widget

Posted by "Ross Gardler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WOOKIE-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450476#comment-13450476 ] 

Ross Gardler commented on WOOKIE-366:
-------------------------------------

I've applied this patch but it was pretty hard work because of the numjber of unconnected fixes within it. Please provide smaller patches, each tackling a single item, so they are easier to review and apply.

Also note that you upgraded the version of JQuery and JQuery Mobile used but this patch did not remove the old ones or add the new ones. I fixed that.

The test widget, however, was still configured to use the old JQuery versions and so it failed. I fixed that.

The comment indicates there is a new data set in the test widget but I do not see that in the patch - forgot to add?
                
> Update to the Walkthrough template and test widget
> --------------------------------------------------
>
>                 Key: WOOKIE-366
>                 URL: https://issues.apache.org/jira/browse/WOOKIE-366
>             Project: Wookie
>          Issue Type: Improvement
>          Components: Template
>    Affects Versions: 0.11.0
>            Reporter: Steve Lee
>            Priority: Minor
>              Labels: patch
>         Attachments: walkthough.diff
>
>
> Here is a patch for the Walkthrough Template and test widget. New features include
> * Improved the 'Save Actions' to be a web page rather than alert. This includes a print button
> * Can specify question set in URL query string
> * Various bug fixes  
> * Test widget is now both a list of the tests and a data set to try them on
> * Readme updated with details on creating a widget form the template
> I have also created a simple demo widget with the 'grape' question set. How do I get this to be included as a demo widget?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira