You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "Josh Elser (JIRA)" <ji...@apache.org> on 2015/10/24 23:42:27 UTC

[jira] [Assigned] (ACCUMULO-4037) avoid a key copy in TimeSettingIterator

     [ https://issues.apache.org/jira/browse/ACCUMULO-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Josh Elser reassigned ACCUMULO-4037:
------------------------------------

    Assignee: Josh Elser

> avoid a key copy in TimeSettingIterator
> ---------------------------------------
>
>                 Key: ACCUMULO-4037
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4037
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.7.0
>            Reporter: Adam Fuchs
>            Assignee: Josh Elser
>            Priority: Minor
>              Labels: performance
>
> In org.apache.accumulo.core.iterators.system.TimeSettingIterator we make a copy of the key before setting the time. Seems like this is a completely superfluous copy, and we should avoid it. In the current code we do the following:
> {code}
>   @Override
>   public Key getTopKey() {
>     Key key = new Key(source.getTopKey());
>     key.setTimestamp(time);
>     return key;
>   }
> {code}
> Instead we should do this:
> {code}
>   @Override
>   public Key getTopKey() {
>     Key key = source.getTopKey();
>     key.setTimestamp(time);
>     return key;
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)