You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/04/28 21:36:46 UTC

[GitHub] [tvm] tkonolige commented on a change in pull request #7935: [SPARSE] Improve sparse performance on ROCM

tkonolige commented on a change in pull request #7935:
URL: https://github.com/apache/tvm/pull/7935#discussion_r622580205



##########
File path: python/tvm/topi/cuda/sparse.py
##########
@@ -170,6 +170,16 @@ def gen_ir(data, w_data, w_indices, w_indptr, out):
         # TODO(tkonolige): seperate implementation for large block sizes
         ib = tvm.tir.ir_builder.create()
 
+        if tvm.target.Target.current(allow_none=False).kind.name == "rocm":

Review comment:
       I've defaulted to not using warp storage unless we are on cuda.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org