You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "zhouyuan (via GitHub)" <gi...@apache.org> on 2025/09/01 22:16:54 UTC

[PR] [GLUTEN-10599][VL] Fix centos7/8 docker image build [incubator-gluten]

zhouyuan opened a new pull request, #10600:
URL: https://github.com/apache/incubator-gluten/pull/10600

   <!--
   Thank you for submitting a pull request! Here are some tips:
   
   1. For first-time contributors, please read our contributing guide:
      https://github.com/apache/incubator-gluten/blob/main/CONTRIBUTING.md
   2. If necessary, create a GitHub issue for discussion beforehand to avoid duplicate work.
   3. If the PR is specific to a single backend, include [VL] or [CH] in the PR title to indicate the
      Velox or ClickHouse backend, respectively.
   4. If the PR is not ready for review, please mark it as a draft.
   -->
   
   ## What changes are proposed in this pull request?
   
   This patch fixes the centos7/8 docker image build
   
   <!--
   Provide a clear and concise description of the changes introduced in this PR.
   Ensure the PR description aligns with the code changes, especially after updates.
   If applicable, include "Fixes #<GitHub_Issue_ID>" to automatically close the corresponding issue
   when the PR is merged.
   -->
   
   ## How was this patch tested?
   
   Pass GHA
   
   <!--
   Describe how the changes were tested, if applicable.
   Include new tests to validate the functionality, if necessary.
   For UI-related changes, attach screenshots to demonstrate the updates.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [GLUTEN-10599][VL] Fix centos7/8 docker image build [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10600:
URL: https://github.com/apache/incubator-gluten/pull/10600#issuecomment-3243322678

   https://github.com/apache/incubator-gluten/issues/10599


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [GLUTEN-10599][VL] Fix centos7/8 dev docker image build [incubator-gluten]

Posted by "zhouyuan (via GitHub)" <gi...@apache.org>.
zhouyuan commented on code in PR #10600:
URL: https://github.com/apache/incubator-gluten/pull/10600#discussion_r2314628566


##########
.github/workflows/docker_image.yml:
##########
@@ -16,6 +16,9 @@
 name: Build and Push Docker Image
 
 on:
+  pull_request:

Review Comment:
   will revert these changes later



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [GLUTEN-10599][VL] Fix Centos dev docker image build [incubator-gluten]

Posted by "zhouyuan (via GitHub)" <gi...@apache.org>.
zhouyuan commented on code in PR #10600:
URL: https://github.com/apache/incubator-gluten/pull/10600#discussion_r2315402478


##########
dev/vcpkg/setup-build-depends.sh:
##########
@@ -99,9 +99,9 @@ install_centos_7() {
     # Requires git >= 2.7.4
     if [[ "$(git --version)" != "git version 2."* ]]; then
         yum -y remove git
-        # Requires 'centos-release-scl' package to be installed.
-        yum -y install rh-git227
-        source /opt/rh/rh-git227/enable

Review Comment:
   @PHILO-HE Thanks. Updated to use rh-git227
    it looks like we need to enable the rh-git227 in the docker file instead in the setup script. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [GLUTEN-10599][VL] Fix Centos dev docker image build [incubator-gluten]

Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on code in PR #10600:
URL: https://github.com/apache/incubator-gluten/pull/10600#discussion_r2315519307


##########
dev/builddeps-veloxbe.sh:
##########
@@ -208,6 +208,8 @@ fi
 concat_velox_param
 
 function build_arrow {
+  get_velox
+  setup_dependencies

Review Comment:
   If we add them here, they will be executed two times in the following complete build at line 306.
   ```
   get_velox
   setup_dependencies
   build_velox_backend
   ```
   
   Can we move `get_velox` into `setup_dependencies` and explicitly add `setup_dependencies` in dockerfile?
   
   `./dev/builddeps-veloxbe.sh --run_setup_script=ON setup_dependencies build_arrow`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [GLUTEN-10599][VL] Fix Centos dev docker image build [incubator-gluten]

Posted by "zhouyuan (via GitHub)" <gi...@apache.org>.
zhouyuan merged PR #10600:
URL: https://github.com/apache/incubator-gluten/pull/10600


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [GLUTEN-10599][VL] Fix centos7/8 dev docker image build [incubator-gluten]

Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on code in PR #10600:
URL: https://github.com/apache/incubator-gluten/pull/10600#discussion_r2314829709


##########
dev/vcpkg/setup-build-depends.sh:
##########
@@ -99,9 +99,9 @@ install_centos_7() {
     # Requires git >= 2.7.4
     if [[ "$(git --version)" != "git version 2."* ]]; then
         yum -y remove git
-        # Requires 'centos-release-scl' package to be installed.
-        yum -y install rh-git227
-        source /opt/rh/rh-git227/enable

Review Comment:
   We already installed git 2.27.0, which can satisfy the minimum requirement 2.7.4. But according to the CI failure, this new git version is not found in later execution. 
   
   The root cause is the above command doesn't change the environment for other subshell execution like `bash xxx.sh`. Maybe, we can simply add the following command to persist the version changes.
   
   ```
   echo "source /opt/rh/rh-git227/enable" >> ~/.bashrc
   ```
   
   This git comes from `centos-release-scl`, which should be more stable, meaning it should be always available for future use.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [GLUTEN-10599][VL] Fix Centos dev docker image build [incubator-gluten]

Posted by "zhouyuan (via GitHub)" <gi...@apache.org>.
zhouyuan commented on code in PR #10600:
URL: https://github.com/apache/incubator-gluten/pull/10600#discussion_r2315577973


##########
dev/builddeps-veloxbe.sh:
##########
@@ -208,6 +208,8 @@ fi
 concat_velox_param
 
 function build_arrow {
+  get_velox
+  setup_dependencies

Review Comment:
   let me add a flag to check if we need to run get_velox



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org