You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucy.apache.org by ma...@apache.org on 2016/02/25 23:40:22 UTC
[07/17] lucy-clownfish git commit: Stub out some placeholders for Py
bindings.
Stub out some placeholders for Py bindings.
Subclassing from Python won't be supported until these are fully
implemented.
Project: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/commit/33189df1
Tree: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/tree/33189df1
Diff: http://git-wip-us.apache.org/repos/asf/lucy-clownfish/diff/33189df1
Branch: refs/heads/master
Commit: 33189df152305583c976b2701396eff940b992a1
Parents: 2b37cc1
Author: Marvin Humphrey <ma...@rectangular.com>
Authored: Mon Feb 1 15:49:29 2016 -0800
Committer: Marvin Humphrey <ma...@rectangular.com>
Committed: Wed Feb 24 15:20:37 2016 -0800
----------------------------------------------------------------------
runtime/python/cfext/CFBind.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucy-clownfish/blob/33189df1/runtime/python/cfext/CFBind.c
----------------------------------------------------------------------
diff --git a/runtime/python/cfext/CFBind.c b/runtime/python/cfext/CFBind.c
index f73b76a..69ab9bd 100644
--- a/runtime/python/cfext/CFBind.c
+++ b/runtime/python/cfext/CFBind.c
@@ -912,23 +912,26 @@ CFISH_Class_Init_Obj_IMP(cfish_Class *self, void *allocation) {
void
cfish_Class_register_with_host(cfish_Class *singleton, cfish_Class *parent) {
+ // FIXME
CFISH_UNUSED_VAR(singleton);
CFISH_UNUSED_VAR(parent);
- CFISH_THROW(CFISH_ERR, "TODO");
}
cfish_Vector*
cfish_Class_fresh_host_methods(cfish_String *class_name) {
+ // FIXME Scan Python class for host methods which override. Until this is
+ // implemented, it will be impossible to override Clownfish methods from
+ // Python.
CFISH_UNUSED_VAR(class_name);
- CFISH_THROW(CFISH_ERR, "TODO");
- CFISH_UNREACHABLE_RETURN(cfish_Vector*);
+ return cfish_Vec_new(0);
}
cfish_String*
cfish_Class_find_parent_class(cfish_String *class_name) {
+ // FIXME Until this is implemented, subclassing from Python will be
+ // impossible.
CFISH_UNUSED_VAR(class_name);
- CFISH_THROW(CFISH_ERR, "TODO");
- CFISH_UNREACHABLE_RETURN(cfish_String*);
+ return NULL;
}
/**** Method ***************************************************************/