You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2012/08/08 11:57:21 UTC

[Bug 53679] New: Constant Throughput Timer bug with localization

https://issues.apache.org/bugzilla/show_bug.cgi?id=53679

          Priority: P2
            Bug ID: 53679
          Assignee: issues@jmeter.apache.org
           Summary: Constant Throughput Timer bug with localization
          Severity: normal
    Classification: Unclassified
          Reporter: kanilachoud@gmail.com
          Hardware: PC
            Status: NEW
           Version: 2.7
         Component: Main
           Product: JMeter

Created attachment 29186
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=29186&action=edit
How to reproduce Bug

I'm using Apache Jmeter 2.7, and as my system language is French, Jmeter set
the language to French but if I designed my test plan in English, the value for
"Calculate Throughput based on " changes when switching between French and
English.

The attachment describe this bug, and the "workaround" I use.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 53679] Constant Throughput Timer bug with localization

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53679

--- Comment #8 from Sebb <se...@apache.org> ---
See Bug 55432 for tracking changes to CSV Data Set.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 53679] Constant Throughput Timer bug with localization

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53679

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |p.mouawad@ubik-ingenierie.c
                   |                            |om
                 OS|                            |All

--- Comment #1 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Same issue affects:
- CSV Data Set Config (but as NOT_OTHER is set to false, selected value stays
in english as an additional one)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 53679] Constant Throughput Timer bug with localization

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53679

--- Comment #5 from Antonio Gomes Rodrigues <ra...@gmail.com> ---
Hi Philippe,

I have seen it but I think it will be better to add it in "component reference"
to have it with JMeter help button

Antonio

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 53679] Constant Throughput Timer bug with localization

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53679

--- Comment #2 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
A simple fix would be not to translate values in ComboStringEditor but this
would imply breaking existing test plan made in other languages as English
which would get default value of TAGS.
If there wasn't the break, this option would not hurt me as:
- in component reference, translated values are not explained.
- in code matching value of Test Bean property from label is not great and is
currently identified in code as so by comment : "TODO need to find better way
to do this"

A more complex fix would be to introduce a more complex ComboEditor which takes
id,label. Test Bean would use id and this would solve this issue. But what
about compatibility ? can it be handled ? is it worth ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 53679] Constant Throughput Timer bug with localization

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53679

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Hardware|PC                          |All
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 53679] Constant Throughput Timer bug with localization

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53679

--- Comment #3 from Antonio Gomes Rodrigues <ra...@gmail.com> ---
Hi,

It will be great to put a link to this issue in the documentation of JMeter (I
have waste 2 days with this bug before to see this issue).
There are another problems in the documentation (not up to date) and if I can
have a login to modify it, I will do it. Instead I will open issues

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 53679] Constant Throughput Timer bug with localization

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53679

--- Comment #4 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Hello Antonio,
There is a mention of this bug here:
- http://jmeter.apache.org/changes.html

Known bugs section
 Changing language can break part of the configuration of the following
elements (see Bug 53679 ):

    CSV Data Set Config (sharing mode will be lost)
    Constant Throughput Timer (Calculate throughput based on will be lost)

Maybe it's not visible enough

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 53679] Constant Throughput Timer bug with localization

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53679

Sebb <se...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from Sebb <se...@apache.org> ---
Fixed Constant Throughput Timer.

Bug 55432 will track CSV Dataset fixes.

URL: http://svn.apache.org/r1514714
Log:
Constant Throughput Timer bug with localization
Bugzilla Id: 53679

Added:
    jmeter/trunk/bin/testfiles/GenTest27_original.jmx   (with props)
Modified:
    jmeter/trunk/bin/testfiles/GenTest210.jmx
    jmeter/trunk/bin/testfiles/GenTest27.jmx
    jmeter/trunk/bin/testfiles/GuiTest231.jmx
   
jmeter/trunk/src/components/org/apache/jmeter/timers/ConstantThroughputTimer.java
   
jmeter/trunk/src/components/org/apache/jmeter/timers/ConstantThroughputTimerBeanInfo.java
    jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java
    jmeter/trunk/test/src/org/apache/jmeter/timers/PackageTest.java
    jmeter/trunk/xdocs/changes.xml
    jmeter/trunk/xdocs/usermanual/component_reference.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 53679] Constant Throughput Timer bug with localization

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53679

--- Comment #6 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Date: Sun Jun 30 13:06:53 2013
New Revision: 1498113

URL: http://svn.apache.org/r1498113
Log:
Bug 53679 - Constant Throughput Timer bug with localization
Added mention on  elements impacted by this bug in documentation
Bugzilla Id: 53679

Modified:
    jmeter/trunk/xdocs/usermanual/component_reference.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 53679] Constant Throughput Timer bug with localization

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53679

--- Comment #7 from Sebb <se...@apache.org> ---
There are at least two ways to fix this:

* use the property name rather than the translated value in the JMX file
* use a number (or enum) for the mode, and translate from the mode as needed

Whichever approach is taken, care needs to be taken that existing test plans
are still handled correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.