You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by ce...@apache.org on 2017/09/16 08:23:02 UTC
svn commit: r1808510 [1/2] - in /poi/trunk/src:
examples/src/org/apache/poi/hssf/usermodel/examples/
examples/src/org/apache/poi/hssf/view/
examples/src/org/apache/poi/ss/examples/
examples/src/org/apache/poi/xssf/eventusermodel/ examples/src/org/apach...
Author: centic
Date: Sat Sep 16 08:22:59 2017
New Revision: 1808510
URL: http://svn.apache.org/viewvc?rev=1808510&view=rev
Log:
Remove unnecessary initialization of members
Modified:
poi/trunk/src/examples/src/org/apache/poi/hssf/usermodel/examples/AddDimensionedImage.java
poi/trunk/src/examples/src/org/apache/poi/hssf/usermodel/examples/InCellLists.java
poi/trunk/src/examples/src/org/apache/poi/hssf/view/SVBorder.java
poi/trunk/src/examples/src/org/apache/poi/hssf/view/SVTableCellRenderer.java
poi/trunk/src/examples/src/org/apache/poi/hssf/view/SVTableModel.java
poi/trunk/src/examples/src/org/apache/poi/hssf/view/SViewer.java
poi/trunk/src/examples/src/org/apache/poi/ss/examples/AddDimensionedImage.java
poi/trunk/src/examples/src/org/apache/poi/ss/examples/ToCSV.java
poi/trunk/src/examples/src/org/apache/poi/xssf/eventusermodel/XLSX2CSV.java
poi/trunk/src/examples/src/org/apache/poi/xwpf/usermodel/examples/UpdateEmbeddedDoc.java
poi/trunk/src/excelant/java/org/apache/poi/ss/excelant/ExcelAntEvaluateCell.java
poi/trunk/src/excelant/java/org/apache/poi/ss/excelant/ExcelAntTask.java
poi/trunk/src/excelant/java/org/apache/poi/ss/excelant/ExcelAntTest.java
poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/MockExcelAntWorkbookHandler.java
poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/util/TestExcelAntEvaluationResult.java
poi/trunk/src/integrationtest/org/apache/poi/stress/HPSFFileHandler.java
poi/trunk/src/java/org/apache/poi/POITextExtractor.java
poi/trunk/src/java/org/apache/poi/ddf/EscherClientAnchorRecord.java
poi/trunk/src/java/org/apache/poi/ddf/EscherColorRef.java
poi/trunk/src/java/org/apache/poi/hpsf/ClipboardData.java
poi/trunk/src/java/org/apache/poi/hpsf/Thumbnail.java
poi/trunk/src/java/org/apache/poi/hssf/dev/FormulaViewer.java
poi/trunk/src/java/org/apache/poi/hssf/eventusermodel/EventWorkbookBuilder.java
poi/trunk/src/java/org/apache/poi/hssf/extractor/EventBasedExcelExtractor.java
poi/trunk/src/java/org/apache/poi/hssf/extractor/ExcelExtractor.java
poi/trunk/src/java/org/apache/poi/hssf/model/InternalSheet.java
poi/trunk/src/java/org/apache/poi/hssf/model/WorkbookRecordList.java
poi/trunk/src/java/org/apache/poi/hssf/record/FontRecord.java
poi/trunk/src/java/org/apache/poi/hssf/record/FtCfSubRecord.java
poi/trunk/src/java/org/apache/poi/hssf/record/FtPioGrbitSubRecord.java
poi/trunk/src/java/org/apache/poi/hssf/record/RecordFactoryInputStream.java
poi/trunk/src/java/org/apache/poi/hssf/record/aggregates/RowRecordsAggregate.java
poi/trunk/src/java/org/apache/poi/hssf/record/aggregates/ValueRecordsAggregate.java
poi/trunk/src/java/org/apache/poi/hssf/record/cf/ColorGradientFormatting.java
poi/trunk/src/java/org/apache/poi/hssf/record/cf/DataBarFormatting.java
poi/trunk/src/java/org/apache/poi/hssf/record/crypto/Biff8DecryptingStream.java
poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFAnchor.java
poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFDataFormat.java
poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFDataValidation.java
poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java
poi/trunk/src/java/org/apache/poi/poifs/crypt/ChunkedCipherInputStream.java
poi/trunk/src/java/org/apache/poi/poifs/crypt/ChunkedCipherOutputStream.java
poi/trunk/src/java/org/apache/poi/poifs/crypt/DataSpaceMapUtils.java
poi/trunk/src/java/org/apache/poi/poifs/crypt/xor/XORDecryptor.java
poi/trunk/src/java/org/apache/poi/poifs/crypt/xor/XOREncryptor.java
poi/trunk/src/java/org/apache/poi/poifs/eventfilesystem/POIFSReader.java
poi/trunk/src/java/org/apache/poi/poifs/filesystem/DocumentDescriptor.java
poi/trunk/src/java/org/apache/poi/poifs/filesystem/Ole10Native.java
poi/trunk/src/java/org/apache/poi/poifs/filesystem/POIFSDocumentPath.java
poi/trunk/src/java/org/apache/poi/ss/format/CellDateFormatter.java
poi/trunk/src/java/org/apache/poi/ss/util/SheetBuilder.java
poi/trunk/src/java/org/apache/poi/ss/util/cellwalk/CellWalk.java
poi/trunk/src/java/org/apache/poi/util/BoundedInputStream.java
poi/trunk/src/java/org/apache/poi/util/CommonsLogger.java
poi/trunk/src/java/org/apache/poi/util/IntList.java
poi/trunk/src/java/org/apache/poi/util/LittleEndianCP950Reader.java
poi/trunk/src/java/org/apache/poi/util/POILogFactory.java
poi/trunk/src/java/org/apache/poi/util/ReplacingInputStream.java
poi/trunk/src/java/org/apache/poi/util/StringUtil.java
poi/trunk/src/ooxml/java/org/apache/poi/POIXMLDocumentPart.java
poi/trunk/src/ooxml/java/org/apache/poi/openxml4j/opc/OPCPackage.java
poi/trunk/src/ooxml/java/org/apache/poi/openxml4j/opc/internal/marshallers/PackagePropertiesMarshaller.java
poi/trunk/src/ooxml/java/org/apache/poi/openxml4j/util/ZipSecureFile.java
poi/trunk/src/ooxml/java/org/apache/poi/poifs/crypt/dsig/SignatureConfig.java
poi/trunk/src/ooxml/java/org/apache/poi/poifs/crypt/dsig/SignatureInfo.java
poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/XDGFDocument.java
poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/XDGFMaster.java
poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/XDGFPage.java
poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/XDGFShape.java
poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/XDGFSheet.java
poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/CharacterSection.java
poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/CombinedIterable.java
poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/GeometrySection.java
poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/ArcTo.java
poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/Ellipse.java
poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/EllipticalArcTo.java
poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/InfiniteLine.java
poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/LineTo.java
poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/MoveTo.java
poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/NURBSTo.java
poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/PolyLineTo.java
poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/RelCubBezTo.java
poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/RelEllipticalArcTo.java
poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/RelLineTo.java
poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/RelMoveTo.java
poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/RelQuadBezTo.java
poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/SplineKnot.java
poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/SplineStart.java
poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/shape/ShapeDebuggerRenderer.java
poi/trunk/src/ooxml/java/org/apache/poi/xslf/extractor/XSLFPowerPointExtractor.java
poi/trunk/src/ooxml/java/org/apache/poi/xslf/usermodel/XSLFPictureData.java
poi/trunk/src/ooxml/java/org/apache/poi/xslf/usermodel/XSLFTableCell.java
poi/trunk/src/ooxml/java/org/apache/poi/xssf/binary/XSSFBCommentsTable.java
poi/trunk/src/ooxml/java/org/apache/poi/xssf/binary/XSSFBSheetHandler.java
poi/trunk/src/ooxml/java/org/apache/poi/xssf/binary/XSSFBStylesTable.java
poi/trunk/src/ooxml/java/org/apache/poi/xssf/eventusermodel/XSSFBReader.java
poi/trunk/src/ooxml/java/org/apache/poi/xssf/extractor/XSSFBEventBasedExcelExtractor.java
poi/trunk/src/ooxml/java/org/apache/poi/xssf/extractor/XSSFEventBasedExcelExtractor.java
poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/AutoSizeColumnTracker.java
poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFRow.java
poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFSheet.java
poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/BaseXSSFEvaluationWorkbook.java
poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFConnector.java
poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFDrawing.java
poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFGraphicFrame.java
poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFObjectData.java
poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFPicture.java
poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFShapeGroup.java
poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFSimpleShape.java
poi/trunk/src/ooxml/java/org/apache/poi/xssf/usermodel/extensions/XSSFHeaderFooter.java
poi/trunk/src/ooxml/java/org/apache/poi/xwpf/extractor/XWPFWordExtractor.java
poi/trunk/src/ooxml/java/org/apache/poi/xwpf/usermodel/PositionInParagraph.java
poi/trunk/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFTableCell.java
poi/trunk/src/ooxml/testcases/org/apache/poi/poifs/crypt/TestSignatureInfo.java
poi/trunk/src/ooxml/testcases/org/apache/poi/sl/draw/TestDrawPictureShape.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestPPTX2PNG.java
poi/trunk/src/ooxml/testcases/org/apache/poi/xslf/usermodel/TestXSLFTextShape.java
poi/trunk/src/scratchpad/src/org/apache/poi/hdgf/HDGFLZWCompressor.java
poi/trunk/src/scratchpad/src/org/apache/poi/hdgf/streams/CompressedStreamStore.java
poi/trunk/src/scratchpad/src/org/apache/poi/hemf/extractor/HemfExtractor.java
poi/trunk/src/scratchpad/src/org/apache/poi/hpbf/extractor/PublisherTextExtractor.java
poi/trunk/src/scratchpad/src/org/apache/poi/hslf/blip/Metafile.java
poi/trunk/src/scratchpad/src/org/apache/poi/hslf/extractor/PowerPointExtractor.java
poi/trunk/src/scratchpad/src/org/apache/poi/hslf/model/textproperties/TextPropCollection.java
poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/EscherPlaceholder.java
poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/OEPlaceholderAtom.java
poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/SSSlideInfoAtom.java
poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/StyleTextPropAtom.java
poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/TextSpecInfoRun.java
poi/trunk/src/scratchpad/src/org/apache/poi/hslf/usermodel/HSLFFontInfo.java
poi/trunk/src/scratchpad/src/org/apache/poi/hslf/usermodel/HSLFSlideShowEncrypted.java
poi/trunk/src/scratchpad/src/org/apache/poi/hslf/usermodel/HSLFSlideShowImpl.java
poi/trunk/src/scratchpad/src/org/apache/poi/hslf/usermodel/HSLFTextParagraph.java
poi/trunk/src/scratchpad/src/org/apache/poi/hsmf/MAPIMessage.java
poi/trunk/src/scratchpad/src/org/apache/poi/hssf/converter/AbstractExcelConverter.java
poi/trunk/src/scratchpad/src/org/apache/poi/hssf/converter/ExcelToHtmlConverter.java
poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/draw/HwmfDrawProperties.java
poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/draw/HwmfSLImageRenderer.java
poi/trunk/src/scratchpad/src/org/apache/poi/hwmf/record/HwmfBitmapDib.java
poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/converter/WordToFoConverter.java
poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/converter/WordToTextConverter.java
poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/model/FontTable.java
poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/BookmarksImpl.java
poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/HWPFList.java
poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/HeaderStories.java
poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/NotesImpl.java
poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/ParagraphProperties.java
poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/PictureRunMapper.java
poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/Table.java
poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/usermodel/TableRow.java
poi/trunk/src/scratchpad/testcases/org/apache/poi/hdgf/streams/StreamTest.java
poi/trunk/src/scratchpad/testcases/org/apache/poi/hwmf/TestHwmfParsing.java
poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/model/TestCHPBinTable.java
poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/model/TestDocumentProperties.java
poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/model/TestFileInformationBlock.java
poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/model/TestFontTable.java
poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/model/TestPlexOfCps.java
poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/model/TestStyleSheet.java
poi/trunk/src/scratchpad/testcases/org/apache/poi/hwpf/usermodel/TestBorderCode.java
poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestCellStyle.java
poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestFormulaEvaluatorBugs.java
poi/trunk/src/testcases/org/apache/poi/poifs/storage/TestRawDataBlock.java
poi/trunk/src/testcases/org/apache/poi/ss/util/cellwalk/TestCellWalk.java
poi/trunk/src/testcases/org/apache/poi/util/TestIOUtils.java
poi/trunk/src/testcases/org/apache/poi/util/TestPOILogger.java
Modified: poi/trunk/src/examples/src/org/apache/poi/hssf/usermodel/examples/AddDimensionedImage.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/examples/src/org/apache/poi/hssf/usermodel/examples/AddDimensionedImage.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/examples/src/org/apache/poi/hssf/usermodel/examples/AddDimensionedImage.java (original)
+++ poi/trunk/src/examples/src/org/apache/poi/hssf/usermodel/examples/AddDimensionedImage.java Sat Sep 16 08:22:59 2017
@@ -794,9 +794,9 @@ public class AddDimensionedImage {
*/
public class ClientAnchorDetail {
- public int fromIndex = 0;
- public int toIndex = 0;
- public int inset = 0;
+ public int fromIndex;
+ public int toIndex;
+ public int inset;
/**
* Create a new instance of the ClientAnchorDetail class using the
Modified: poi/trunk/src/examples/src/org/apache/poi/hssf/usermodel/examples/InCellLists.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/examples/src/org/apache/poi/hssf/usermodel/examples/InCellLists.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/examples/src/org/apache/poi/hssf/usermodel/examples/InCellLists.java (original)
+++ poi/trunk/src/examples/src/org/apache/poi/hssf/usermodel/examples/InCellLists.java Sat Sep 16 08:22:59 2017
@@ -512,8 +512,8 @@ public class InCellLists {
*/
public final class MultiLevelListItem {
- private String itemText = null;
- private ArrayList<String> lowerLevelItems = null;
+ private String itemText;
+ private ArrayList<String> lowerLevelItems;
/**
* Create a new instance of the MultiLevelListItem class using the
Modified: poi/trunk/src/examples/src/org/apache/poi/hssf/view/SVBorder.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/examples/src/org/apache/poi/hssf/view/SVBorder.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/examples/src/org/apache/poi/hssf/view/SVBorder.java (original)
+++ poi/trunk/src/examples/src/org/apache/poi/hssf/view/SVBorder.java Sat Sep 16 08:22:59 2017
@@ -33,19 +33,19 @@ import org.apache.poi.ss.usermodel.Borde
* @author Jason Height
*/
public class SVBorder extends AbstractBorder {
- private Color northColor = null;
- private Color eastColor = null;
- private Color southColor = null;
- private Color westColor = null;
+ private Color northColor;
+ private Color eastColor;
+ private Color southColor;
+ private Color westColor;
private BorderStyle northBorderType = BorderStyle.NONE;
private BorderStyle eastBorderType = BorderStyle.NONE;
private BorderStyle southBorderType = BorderStyle.NONE;
private BorderStyle westBorderType = BorderStyle.NONE;
- private boolean northBorder=false;
- private boolean eastBorder=false;
- private boolean southBorder=false;
- private boolean westBorder=false;
- private boolean selected = false;
+ private boolean northBorder;
+ private boolean eastBorder;
+ private boolean southBorder;
+ private boolean westBorder;
+ private boolean selected;
public void setBorder(Color northColor, Color eastColor,
Color southColor, Color westColor,
Modified: poi/trunk/src/examples/src/org/apache/poi/hssf/view/SVTableCellRenderer.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/examples/src/org/apache/poi/hssf/view/SVTableCellRenderer.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/examples/src/org/apache/poi/hssf/view/SVTableCellRenderer.java (original)
+++ poi/trunk/src/examples/src/org/apache/poi/hssf/view/SVTableCellRenderer.java Sat Sep 16 08:22:59 2017
@@ -56,7 +56,7 @@ public class SVTableCellRenderer extends
protected SVBorder cellBorder = new SVBorder();
- private HSSFWorkbook wb = null;
+ private HSSFWorkbook wb;
/** This class holds the references to the predefined cell formats.
*/
Modified: poi/trunk/src/examples/src/org/apache/poi/hssf/view/SVTableModel.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/examples/src/org/apache/poi/hssf/view/SVTableModel.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/examples/src/org/apache/poi/hssf/view/SVTableModel.java (original)
+++ poi/trunk/src/examples/src/org/apache/poi/hssf/view/SVTableModel.java Sat Sep 16 08:22:59 2017
@@ -34,8 +34,8 @@ import org.apache.poi.hssf.usermodel.HSS
*/
public class SVTableModel extends AbstractTableModel {
- private HSSFSheet st = null;
- int maxcol = 0;
+ private HSSFSheet st;
+ int maxcol;
public SVTableModel(HSSFSheet st, int maxcol) {
this.st = st;
Modified: poi/trunk/src/examples/src/org/apache/poi/hssf/view/SViewer.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/examples/src/org/apache/poi/hssf/view/SViewer.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/examples/src/org/apache/poi/hssf/view/SViewer.java (original)
+++ poi/trunk/src/examples/src/org/apache/poi/hssf/view/SViewer.java Sat Sep 16 08:22:59 2017
@@ -40,8 +40,8 @@ import org.apache.poi.hssf.usermodel.HSS
*/
public class SViewer extends JApplet {
private SViewerPanel panel;
- boolean isStandalone = false;
- String filename = null;
+ boolean isStandalone;
+ String filename;
/**Get a parameter value*/
public String getParameter(String key, String def) {
Modified: poi/trunk/src/examples/src/org/apache/poi/ss/examples/AddDimensionedImage.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/examples/src/org/apache/poi/ss/examples/AddDimensionedImage.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/examples/src/org/apache/poi/ss/examples/AddDimensionedImage.java (original)
+++ poi/trunk/src/examples/src/org/apache/poi/ss/examples/AddDimensionedImage.java Sat Sep 16 08:22:59 2017
@@ -864,9 +864,9 @@ public class AddDimensionedImage {
*/
public class ClientAnchorDetail {
- public int fromIndex = 0;
- public int toIndex = 0;
- public int inset = 0;
+ public int fromIndex;
+ public int toIndex;
+ public int inset;
/**
* Create a new instance of the ClientAnchorDetail class using the
Modified: poi/trunk/src/examples/src/org/apache/poi/ss/examples/ToCSV.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/examples/src/org/apache/poi/ss/examples/ToCSV.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/examples/src/org/apache/poi/ss/examples/ToCSV.java (original)
+++ poi/trunk/src/examples/src/org/apache/poi/ss/examples/ToCSV.java Sat Sep 16 08:22:59 2017
@@ -132,13 +132,13 @@ import org.apache.poi.ss.usermodel.Workb
*/
public class ToCSV {
- private Workbook workbook = null;
- private ArrayList<ArrayList<String>> csvData = null;
- private int maxRowWidth = 0;
- private int formattingConvention = 0;
- private DataFormatter formatter = null;
- private FormulaEvaluator evaluator = null;
- private String separator = null;
+ private Workbook workbook;
+ private ArrayList<ArrayList<String>> csvData;
+ private int maxRowWidth;
+ private int formattingConvention;
+ private DataFormatter formatter;
+ private FormulaEvaluator evaluator;
+ private String separator;
private static final String CSV_FILE_EXTENSION = ".csv";
private static final String DEFAULT_SEPARATOR = ",";
Modified: poi/trunk/src/examples/src/org/apache/poi/xssf/eventusermodel/XLSX2CSV.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/examples/src/org/apache/poi/xssf/eventusermodel/XLSX2CSV.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/examples/src/org/apache/poi/xssf/eventusermodel/XLSX2CSV.java (original)
+++ poi/trunk/src/examples/src/org/apache/poi/xssf/eventusermodel/XLSX2CSV.java Sat Sep 16 08:22:59 2017
@@ -70,7 +70,7 @@ public class XLSX2CSV {
* as a (basic) CSV.
*/
private class SheetToCSV implements SheetContentsHandler {
- private boolean firstCellOfRow = false;
+ private boolean firstCellOfRow;
private int currentRow = -1;
private int currentCol = -1;
Modified: poi/trunk/src/examples/src/org/apache/poi/xwpf/usermodel/examples/UpdateEmbeddedDoc.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/examples/src/org/apache/poi/xwpf/usermodel/examples/UpdateEmbeddedDoc.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/examples/src/org/apache/poi/xwpf/usermodel/examples/UpdateEmbeddedDoc.java (original)
+++ poi/trunk/src/examples/src/org/apache/poi/xwpf/usermodel/examples/UpdateEmbeddedDoc.java Sat Sep 16 08:22:59 2017
@@ -49,8 +49,8 @@ import org.apache.poi.xwpf.usermodel.XWP
*/
public class UpdateEmbeddedDoc {
- private XWPFDocument doc = null;
- private File docFile = null;
+ private XWPFDocument doc;
+ private File docFile;
private static final int SHEET_NUM = 0;
private static final int ROW_NUM = 0;
Modified: poi/trunk/src/excelant/java/org/apache/poi/ss/excelant/ExcelAntEvaluateCell.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/excelant/java/org/apache/poi/ss/excelant/ExcelAntEvaluateCell.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/excelant/java/org/apache/poi/ss/excelant/ExcelAntEvaluateCell.java (original)
+++ poi/trunk/src/excelant/java/org/apache/poi/ss/excelant/ExcelAntEvaluateCell.java Sat Sep 16 08:22:59 2017
@@ -42,14 +42,14 @@ public class ExcelAntEvaluateCell extend
private double precision ;
private double precisionToUse ;
private double globalPrecision ;
- private boolean requiredToPass = false ;
+ private boolean requiredToPass;
private ExcelAntEvaluationResult result ;
private ExcelAntWorkbookUtil wbUtil ;
- private boolean showDelta = false ;
+ private boolean showDelta;
public ExcelAntEvaluateCell() {}
Modified: poi/trunk/src/excelant/java/org/apache/poi/ss/excelant/ExcelAntTask.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/excelant/java/org/apache/poi/ss/excelant/ExcelAntTask.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/excelant/java/org/apache/poi/ss/excelant/ExcelAntTask.java (original)
+++ poi/trunk/src/excelant/java/org/apache/poi/ss/excelant/ExcelAntTask.java Sat Sep 16 08:22:59 2017
@@ -37,7 +37,7 @@ public class ExcelAntTask extends Task {
private String excelFileName ;
- private boolean failOnError = false ;
+ private boolean failOnError;
private ExcelAntWorkbookUtil workbookUtil ;
Modified: poi/trunk/src/excelant/java/org/apache/poi/ss/excelant/ExcelAntTest.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/excelant/java/org/apache/poi/ss/excelant/ExcelAntTest.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/excelant/java/org/apache/poi/ss/excelant/ExcelAntTest.java (original)
+++ poi/trunk/src/excelant/java/org/apache/poi/ss/excelant/ExcelAntTest.java Sat Sep 16 08:22:59 2017
@@ -44,9 +44,9 @@ public class ExcelAntTest extends Task{
private double globalPrecision;
- private boolean showSuccessDetails = false;
+ private boolean showSuccessDetails;
- private boolean showFailureDetail = false;
+ private boolean showFailureDetail;
LinkedList<String> failureMessages;
Modified: poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/MockExcelAntWorkbookHandler.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/MockExcelAntWorkbookHandler.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/MockExcelAntWorkbookHandler.java (original)
+++ poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/MockExcelAntWorkbookHandler.java Sat Sep 16 08:22:59 2017
@@ -22,8 +22,8 @@ import static org.junit.Assert.assertNot
import org.apache.poi.ss.usermodel.Workbook;
public class MockExcelAntWorkbookHandler implements IExcelAntWorkbookHandler {
- public static boolean executed = false;
- public static Workbook workbook = null;
+ public static boolean executed;
+ public static Workbook workbook;
@Override
Modified: poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/util/TestExcelAntEvaluationResult.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/util/TestExcelAntEvaluationResult.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/util/TestExcelAntEvaluationResult.java (original)
+++ poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/util/TestExcelAntEvaluationResult.java Sat Sep 16 08:22:59 2017
@@ -26,8 +26,8 @@ import org.junit.Test;
public class TestExcelAntEvaluationResult {
private ExcelAntEvaluationResult fixture;
- private boolean completedWithError = false;
- private boolean passed = false;
+ private boolean completedWithError;
+ private boolean passed;
private double retValue = 1.1;
private String errMessage = "error message";
private double delta = 2.2;
Modified: poi/trunk/src/integrationtest/org/apache/poi/stress/HPSFFileHandler.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/integrationtest/org/apache/poi/stress/HPSFFileHandler.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/integrationtest/org/apache/poi/stress/HPSFFileHandler.java (original)
+++ poi/trunk/src/integrationtest/org/apache/poi/stress/HPSFFileHandler.java Sat Sep 16 08:22:59 2017
@@ -46,7 +46,7 @@ import org.junit.Test;
public class HPSFFileHandler extends POIFSFileHandler {
private static final String NL = System.getProperty("line.separator");
- private static File copyOutput = null;
+ private static File copyOutput;
static final Set<String> EXCLUDES_HANDLE_ADD = unmodifiableHashSet(
"spreadsheet/45290.xls",
@@ -92,8 +92,8 @@ public class HPSFFileHandler extends POI
try {
return PropertySet.isPropertySetStream(dis);
} finally {
- dis.close();;
- }
+ dis.close();
+ }
}
@Override
Modified: poi/trunk/src/java/org/apache/poi/POITextExtractor.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/POITextExtractor.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/POITextExtractor.java (original)
+++ poi/trunk/src/java/org/apache/poi/POITextExtractor.java Sat Sep 16 08:22:59 2017
@@ -32,7 +32,7 @@ import java.io.IOException;
* @see org.apache.poi.hwpf.extractor.WordExtractor
*/
public abstract class POITextExtractor implements Closeable {
- private Closeable fsToClose = null;
+ private Closeable fsToClose;
/**
* Retrieves all the text from the document.
Modified: poi/trunk/src/java/org/apache/poi/ddf/EscherClientAnchorRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ddf/EscherClientAnchorRecord.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ddf/EscherClientAnchorRecord.java (original)
+++ poi/trunk/src/java/org/apache/poi/ddf/EscherClientAnchorRecord.java Sat Sep 16 08:22:59 2017
@@ -51,7 +51,7 @@ public class EscherClientAnchorRecord
private short field_8_row2;
private short field_9_dy2;
private byte[] remainingData = new byte[0];
- private boolean shortRecord = false;
+ private boolean shortRecord;
@Override
public int fillFields(byte[] data, int offset, EscherRecordFactory recordFactory) {
Modified: poi/trunk/src/java/org/apache/poi/ddf/EscherColorRef.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ddf/EscherColorRef.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ddf/EscherColorRef.java (original)
+++ poi/trunk/src/java/org/apache/poi/ddf/EscherColorRef.java Sat Sep 16 08:22:59 2017
@@ -26,7 +26,7 @@ import org.apache.poi.util.LittleEndian;
public class EscherColorRef {
@SuppressWarnings("unused")
private int opid = -1;
- private int colorRef = 0;
+ private int colorRef;
public enum SysIndexSource {
/** Use the fill color of the shape. */
Modified: poi/trunk/src/java/org/apache/poi/hpsf/ClipboardData.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hpsf/ClipboardData.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hpsf/ClipboardData.java (original)
+++ poi/trunk/src/java/org/apache/poi/hpsf/ClipboardData.java Sat Sep 16 08:22:59 2017
@@ -28,7 +28,7 @@ import org.apache.poi.util.POILogger;
class ClipboardData {
private static final POILogger LOG = POILogFactory.getLogger( ClipboardData.class );
- private int _format = 0;
+ private int _format;
private byte[] _value;
ClipboardData() {}
Modified: poi/trunk/src/java/org/apache/poi/hpsf/Thumbnail.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hpsf/Thumbnail.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hpsf/Thumbnail.java (original)
+++ poi/trunk/src/java/org/apache/poi/hpsf/Thumbnail.java Sat Sep 16 08:22:59 2017
@@ -123,7 +123,7 @@ public final class Thumbnail {
* <p>A <code>byte[]</code> to hold a thumbnail image in ({@link
* Variant#VT_CF VT_CF}) format.</p>
*/
- private byte[] _thumbnailData = null;
+ private byte[] _thumbnailData;
Modified: poi/trunk/src/java/org/apache/poi/hssf/dev/FormulaViewer.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/dev/FormulaViewer.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/dev/FormulaViewer.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/dev/FormulaViewer.java Sat Sep 16 08:22:59 2017
@@ -42,7 +42,7 @@ import org.apache.poi.ss.formula.ptg.Ptg
public class FormulaViewer
{
private String file;
- private boolean list=false;
+ private boolean list;
/** Creates new FormulaViewer */
Modified: poi/trunk/src/java/org/apache/poi/hssf/eventusermodel/EventWorkbookBuilder.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/eventusermodel/EventWorkbookBuilder.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/eventusermodel/EventWorkbookBuilder.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/eventusermodel/EventWorkbookBuilder.java Sat Sep 16 08:22:59 2017
@@ -116,7 +116,7 @@ public class EventWorkbookBuilder {
private final HSSFListener childListener;
private final List<BoundSheetRecord> boundSheetRecords = new ArrayList<BoundSheetRecord>();
private final List<ExternSheetRecord> externSheetRecords = new ArrayList<ExternSheetRecord>();
- private SSTRecord sstRecord = null;
+ private SSTRecord sstRecord;
public SheetRecordCollectingListener(HSSFListener childListener) {
this.childListener = childListener;
Modified: poi/trunk/src/java/org/apache/poi/hssf/extractor/EventBasedExcelExtractor.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/extractor/EventBasedExcelExtractor.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/extractor/EventBasedExcelExtractor.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/extractor/EventBasedExcelExtractor.java Sat Sep 16 08:22:59 2017
@@ -63,7 +63,7 @@ import org.apache.poi.poifs.filesystem.P
public class EventBasedExcelExtractor extends POIOLE2TextExtractor implements org.apache.poi.ss.extractor.ExcelExtractor {
private DirectoryNode _dir;
boolean _includeSheetNames = true;
- boolean _formulasNotResults = false;
+ boolean _formulasNotResults;
public EventBasedExcelExtractor( DirectoryNode dir )
{
@@ -167,7 +167,7 @@ public class EventBasedExcelExtractor ex
private int sheetNum = -1;
private int rowNum;
- private boolean outputNextStringValue = false;
+ private boolean outputNextStringValue;
private int nextRow = -1;
public TextListener() {
Modified: poi/trunk/src/java/org/apache/poi/hssf/extractor/ExcelExtractor.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/extractor/ExcelExtractor.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/extractor/ExcelExtractor.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/extractor/ExcelExtractor.java Sat Sep 16 08:22:59 2017
@@ -58,8 +58,8 @@ public class ExcelExtractor extends POIO
private final HSSFDataFormatter _formatter;
private boolean _includeSheetNames = true;
private boolean _shouldEvaluateFormulas = true;
- private boolean _includeCellComments = false;
- private boolean _includeBlankCells = false;
+ private boolean _includeCellComments;
+ private boolean _includeBlankCells;
private boolean _includeHeadersFooters = true;
public ExcelExtractor(HSSFWorkbook wb) {
Modified: poi/trunk/src/java/org/apache/poi/hssf/model/InternalSheet.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/model/InternalSheet.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/model/InternalSheet.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/model/InternalSheet.java Sat Sep 16 08:22:59 2017
@@ -66,9 +66,9 @@ public final class InternalSheet {
private static POILogger log = POILogFactory.getLogger(InternalSheet.class);
private List<RecordBase> _records;
- protected PrintGridlinesRecord printGridlines = null;
- protected PrintHeadersRecord printHeaders = null;
- protected GridsetRecord gridset = null;
+ protected PrintGridlinesRecord printGridlines;
+ protected PrintHeadersRecord printHeaders;
+ protected GridsetRecord gridset;
private GutsRecord _gutsRecord;
protected DefaultColWidthRecord defaultcolwidth = new DefaultColWidthRecord();
protected DefaultRowHeightRecord defaultrowheight = new DefaultRowHeightRecord();
@@ -80,8 +80,8 @@ public final class InternalSheet {
*/
private final WorksheetProtectionBlock _protectionBlock = new WorksheetProtectionBlock();
- protected WindowTwoRecord windowTwo = null;
- protected SelectionRecord _selection = null;
+ protected WindowTwoRecord windowTwo;
+ protected SelectionRecord _selection;
/** java object always present, but if empty no BIFF records are written */
private final MergedCellsTable _mergedCellsTable;
/** always present in this POI object, not always written to Excel file */
@@ -90,13 +90,13 @@ public final class InternalSheet {
private DimensionsRecord _dimensions;
/** always present */
protected final RowRecordsAggregate _rowsAggregate;
- private DataValidityTable _dataValidityTable= null;
+ private DataValidityTable _dataValidityTable;
private ConditionalFormattingTable condFormatting;
- private Iterator<RowRecord> rowRecIterator = null;
+ private Iterator<RowRecord> rowRecIterator;
/** Add an UncalcedRecord if not true indicating formulas have not been calculated */
- protected boolean _isUncalced = false;
+ protected boolean _isUncalced;
public static final byte PANE_LOWER_RIGHT = (byte)0;
public static final byte PANE_UPPER_RIGHT = (byte)1;
Modified: poi/trunk/src/java/org/apache/poi/hssf/model/WorkbookRecordList.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/model/WorkbookRecordList.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/model/WorkbookRecordList.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/model/WorkbookRecordList.java Sat Sep 16 08:22:59 2017
@@ -26,23 +26,23 @@ public final class WorkbookRecordList {
private List<Record> records = new ArrayList<Record>();
/** holds the position of the protect record */
- private int protpos = 0;
+ private int protpos;
/** holds the position of the last bound sheet */
- private int bspos = 0;
+ private int bspos;
/** holds the position of the tabid record */
- private int tabpos = 0;
+ private int tabpos;
/** hold the position of the last font record */
- private int fontpos = 0;
+ private int fontpos;
/** hold the position of the last extended font record */
- private int xfpos = 0;
+ private int xfpos;
/** holds the position of the backup record */
- private int backuppos = 0;
+ private int backuppos;
/** holds the position of last name record */
- private int namepos = 0;
+ private int namepos;
/** holds the position of sup book */
- private int supbookpos = 0;
+ private int supbookpos;
/** holds the position of the extern sheet */
- private int externsheetPos = 0;
+ private int externsheetPos;
/** hold the position of the palette, if applicable */
private int palettepos = -1;
Modified: poi/trunk/src/java/org/apache/poi/hssf/record/FontRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/record/FontRecord.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/record/FontRecord.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/record/FontRecord.java Sat Sep 16 08:22:59 2017
@@ -58,7 +58,7 @@ public final class FontRecord extends St
private byte field_6_underline; // 00none/01single/02double/21singleaccounting/22doubleaccounting
private byte field_7_family; // ?? defined by windows api logfont structure?
private byte field_8_charset; // ?? defined by windows api logfont structure?
- private byte field_9_zero = 0; // must be 0
+ private byte field_9_zero; // must be 0
/** possibly empty string never <code>null</code> */
private String field_11_font_name;
Modified: poi/trunk/src/java/org/apache/poi/hssf/record/FtCfSubRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/record/FtCfSubRecord.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/record/FtCfSubRecord.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/record/FtCfSubRecord.java Sat Sep 16 08:22:59 2017
@@ -46,7 +46,7 @@ public final class FtCfSubRecord extends
*/
public static final short UNSPECIFIED_BIT = (short)0xFFFF;
- private short flags = 0;
+ private short flags;
/**
* Construct a new <code>FtPioGrbitSubRecord</code> and
Modified: poi/trunk/src/java/org/apache/poi/hssf/record/FtPioGrbitSubRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/record/FtPioGrbitSubRecord.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/record/FtPioGrbitSubRecord.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/record/FtPioGrbitSubRecord.java Sat Sep 16 08:22:59 2017
@@ -83,7 +83,7 @@ public final class FtPioGrbitSubRecord e
public static final int AUTO_LOAD_BIT = 1 << 9;
- private short flags = 0;
+ private short flags;
/**
* Construct a new <code>FtPioGrbitSubRecord</code> and
Modified: poi/trunk/src/java/org/apache/poi/hssf/record/RecordFactoryInputStream.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/record/RecordFactoryInputStream.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/record/RecordFactoryInputStream.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/record/RecordFactoryInputStream.java Sat Sep 16 08:22:59 2017
@@ -163,7 +163,7 @@ public final class RecordFactoryInputStr
/**
* The most recent record that we gave to the user
*/
- private Record _lastRecord = null;
+ private Record _lastRecord;
/**
* The most recent DrawingRecord seen
*/
Modified: poi/trunk/src/java/org/apache/poi/hssf/record/aggregates/RowRecordsAggregate.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/record/aggregates/RowRecordsAggregate.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/record/aggregates/RowRecordsAggregate.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/record/aggregates/RowRecordsAggregate.java Sat Sep 16 08:22:59 2017
@@ -43,7 +43,7 @@ public final class RowRecordsAggregate e
// Cache values to speed up performance of
// getStartRowNumberForBlock / getEndRowNumberForBlock, see Bugzilla 47405
- private RowRecord[] _rowRecordValues = null;
+ private RowRecord[] _rowRecordValues;
/** Creates a new instance of ValueRecordsAggregate */
public RowRecordsAggregate() {
Modified: poi/trunk/src/java/org/apache/poi/hssf/record/aggregates/ValueRecordsAggregate.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/record/aggregates/ValueRecordsAggregate.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/record/aggregates/ValueRecordsAggregate.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/record/aggregates/ValueRecordsAggregate.java Sat Sep 16 08:22:59 2017
@@ -307,8 +307,8 @@ public final class ValueRecordsAggregate
*/
class ValueIterator implements Iterator<CellValueRecordInterface> {
- int curRowIndex = 0, curColIndex = -1;
- int nextRowIndex = 0, nextColIndex = -1;
+ int curRowIndex, curColIndex = -1;
+ int nextRowIndex, nextColIndex = -1;
public ValueIterator() {
getNextPos();
Modified: poi/trunk/src/java/org/apache/poi/hssf/record/cf/ColorGradientFormatting.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/record/cf/ColorGradientFormatting.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/record/cf/ColorGradientFormatting.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/record/cf/ColorGradientFormatting.java Sat Sep 16 08:22:59 2017
@@ -33,7 +33,7 @@ import org.apache.poi.util.POILogger;
public final class ColorGradientFormatting implements Cloneable {
private static POILogger log = POILogFactory.getLogger(ColorGradientFormatting.class);
- private byte options = 0;
+ private byte options;
private ColorGradientThreshold[] thresholds;
private ExtendedColor[] colors;
Modified: poi/trunk/src/java/org/apache/poi/hssf/record/cf/DataBarFormatting.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/record/cf/DataBarFormatting.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/record/cf/DataBarFormatting.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/record/cf/DataBarFormatting.java Sat Sep 16 08:22:59 2017
@@ -31,9 +31,9 @@ import org.apache.poi.util.POILogger;
public final class DataBarFormatting implements Cloneable {
private static POILogger log = POILogFactory.getLogger(DataBarFormatting.class);
- private byte options = 0;
- private byte percentMin = 0;
- private byte percentMax = 0;
+ private byte options;
+ private byte percentMin;
+ private byte percentMax;
private ExtendedColor color;
private DataBarThreshold thresholdMin;
private DataBarThreshold thresholdMax;
Modified: poi/trunk/src/java/org/apache/poi/hssf/record/crypto/Biff8DecryptingStream.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/record/crypto/Biff8DecryptingStream.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/record/crypto/Biff8DecryptingStream.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/record/crypto/Biff8DecryptingStream.java Sat Sep 16 08:22:59 2017
@@ -39,7 +39,7 @@ public final class Biff8DecryptingStream
private final EncryptionInfo info;
private ChunkedCipherInputStream ccis;
private final byte buffer[] = new byte[LittleEndianConsts.LONG_SIZE];
- private boolean shouldSkipEncryptionOnCurrentRecord = false;
+ private boolean shouldSkipEncryptionOnCurrentRecord;
public Biff8DecryptingStream(InputStream in, int initialOffset, EncryptionInfo info) throws RecordFormatException {
try {
Modified: poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFAnchor.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFAnchor.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFAnchor.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFAnchor.java Sat Sep 16 08:22:59 2017
@@ -30,8 +30,8 @@ import org.apache.poi.ss.usermodel.Child
*/
public abstract class HSSFAnchor implements ChildAnchor {
- protected boolean _isHorizontallyFlipped = false;
- protected boolean _isVerticallyFlipped = false;
+ protected boolean _isHorizontallyFlipped;
+ protected boolean _isVerticallyFlipped;
public HSSFAnchor() {
createEscherAnchor();
@@ -47,10 +47,10 @@ public abstract class HSSFAnchor impleme
public static HSSFAnchor createAnchorFromEscher(EscherContainerRecord container){
if (null != container.getChildById(EscherChildAnchorRecord.RECORD_ID)){
- return new HSSFChildAnchor((EscherChildAnchorRecord) container.getChildById(EscherChildAnchorRecord.RECORD_ID));
+ return new HSSFChildAnchor(container.getChildById(EscherChildAnchorRecord.RECORD_ID));
} else {
if (null != container.getChildById(EscherClientAnchorRecord.RECORD_ID)){
- return new HSSFClientAnchor((EscherClientAnchorRecord) container.getChildById(EscherClientAnchorRecord.RECORD_ID));
+ return new HSSFClientAnchor(container.getChildById(EscherClientAnchorRecord.RECORD_ID));
}
return null;
}
Modified: poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFDataFormat.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFDataFormat.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFDataFormat.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFDataFormat.java Sat Sep 16 08:22:59 2017
@@ -44,7 +44,7 @@ public final class HSSFDataFormat implem
private final Vector<String> _formats = new Vector<String>();
private final InternalWorkbook _workbook;
- private boolean _movedBuiltins = false; // Flag to see if need to
+ private boolean _movedBuiltins; // Flag to see if need to
// check the built in list
// or if the regular list
// has all entries.
Modified: poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFDataValidation.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFDataValidation.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFDataValidation.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFDataValidation.java Sat Sep 16 08:22:59 2017
@@ -35,7 +35,7 @@ public final class HSSFDataValidation im
private int _errorStyle = ErrorStyle.STOP;
private boolean _emptyCellAllowed = true;
- private boolean _suppress_dropdown_arrow = false;
+ private boolean _suppress_dropdown_arrow;
private boolean _showPromptBox = true;
private boolean _showErrorBox = true;
private CellRangeAddressList _regions;
Modified: poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java Sat Sep 16 08:22:59 2017
@@ -960,7 +960,7 @@ public final class HSSFWorkbook extends
private final class SheetIterator<T extends Sheet> implements Iterator<T> {
final private Iterator<T> it;
- private T cursor = null;
+ private T cursor;
@SuppressWarnings("unchecked")
public SheetIterator() {
it = (Iterator<T>) _sheets.iterator();
Modified: poi/trunk/src/java/org/apache/poi/poifs/crypt/ChunkedCipherInputStream.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/poifs/crypt/ChunkedCipherInputStream.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/poifs/crypt/ChunkedCipherInputStream.java (original)
+++ poi/trunk/src/java/org/apache/poi/poifs/crypt/ChunkedCipherInputStream.java Sat Sep 16 08:22:59 2017
@@ -41,7 +41,7 @@ public abstract class ChunkedCipherInput
private int lastIndex;
private long pos;
- private boolean chunkIsValid = false;
+ private boolean chunkIsValid;
public ChunkedCipherInputStream(InputStream stream, long size, int chunkSize)
throws GeneralSecurityException {
Modified: poi/trunk/src/java/org/apache/poi/poifs/crypt/ChunkedCipherOutputStream.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/poifs/crypt/ChunkedCipherOutputStream.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/poifs/crypt/ChunkedCipherOutputStream.java (original)
+++ poi/trunk/src/java/org/apache/poi/poifs/crypt/ChunkedCipherOutputStream.java Sat Sep 16 08:22:59 2017
@@ -64,7 +64,7 @@ public abstract class ChunkedCipherOutpu
// the cipher can't be final, because for the last chunk we change the padding
// and therefore need to change the cipher too
private Cipher cipher;
- private boolean isClosed = false;
+ private boolean isClosed;
public ChunkedCipherOutputStream(DirectoryNode dir, int chunkSize) throws IOException, GeneralSecurityException {
super(null);
Modified: poi/trunk/src/java/org/apache/poi/poifs/crypt/DataSpaceMapUtils.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/poifs/crypt/DataSpaceMapUtils.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/poifs/crypt/DataSpaceMapUtils.java (original)
+++ poi/trunk/src/java/org/apache/poi/poifs/crypt/DataSpaceMapUtils.java Sat Sep 16 08:22:59 2017
@@ -203,9 +203,9 @@ public class DataSpaceMapUtils {
int transformType;
String transformerId;
String transformerName;
- int readerVersionMajor = 1, readerVersionMinor = 0;
- int updaterVersionMajor = 1, updaterVersionMinor = 0;
- int writerVersionMajor = 1, writerVersionMinor = 0;
+ int readerVersionMajor = 1, readerVersionMinor;
+ int updaterVersionMajor = 1, updaterVersionMinor;
+ int writerVersionMajor = 1, writerVersionMinor;
public TransformInfoHeader(
int transformType,
@@ -257,9 +257,9 @@ public class DataSpaceMapUtils {
public static class DataSpaceVersionInfo implements EncryptionRecord {
String featureIdentifier;
- int readerVersionMajor = 1, readerVersionMinor = 0;
- int updaterVersionMajor = 1, updaterVersionMinor = 0;
- int writerVersionMajor = 1, writerVersionMinor = 0;
+ int readerVersionMajor = 1, readerVersionMinor;
+ int updaterVersionMajor = 1, updaterVersionMinor;
+ int writerVersionMajor = 1, writerVersionMinor;
public DataSpaceVersionInfo(LittleEndianInput is) {
featureIdentifier = readUnicodeLPP4(is);
Modified: poi/trunk/src/java/org/apache/poi/poifs/crypt/xor/XORDecryptor.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/poifs/crypt/xor/XORDecryptor.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/poifs/crypt/xor/XORDecryptor.java (original)
+++ poi/trunk/src/java/org/apache/poi/poifs/crypt/xor/XORDecryptor.java Sat Sep 16 08:22:59 2017
@@ -101,8 +101,8 @@ public class XORDecryptor extends Decryp
private class XORCipherInputStream extends ChunkedCipherInputStream {
private final int initialOffset;
- private int recordStart = 0;
- private int recordEnd = 0;
+ private int recordStart;
+ private int recordEnd;
public XORCipherInputStream(InputStream stream, int initialPos)
throws GeneralSecurityException {
Modified: poi/trunk/src/java/org/apache/poi/poifs/crypt/xor/XOREncryptor.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/poifs/crypt/xor/XOREncryptor.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/poifs/crypt/xor/XOREncryptor.java (original)
+++ poi/trunk/src/java/org/apache/poi/poifs/crypt/xor/XOREncryptor.java Sat Sep 16 08:22:59 2017
@@ -88,8 +88,8 @@ public class XOREncryptor extends Encryp
}
private class XORCipherOutputStream extends ChunkedCipherOutputStream {
- private int recordStart = 0;
- private int recordEnd = 0;
+ private int recordStart;
+ private int recordEnd;
public XORCipherOutputStream(OutputStream stream, int initialPos) throws IOException, GeneralSecurityException {
super(stream, -1);
Modified: poi/trunk/src/java/org/apache/poi/poifs/eventfilesystem/POIFSReader.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/poifs/eventfilesystem/POIFSReader.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/poifs/eventfilesystem/POIFSReader.java (original)
+++ poi/trunk/src/java/org/apache/poi/poifs/eventfilesystem/POIFSReader.java Sat Sep 16 08:22:59 2017
@@ -51,7 +51,7 @@ public class POIFSReader
{
private final POIFSReaderRegistry registry;
private boolean registryClosed;
- private boolean notifyEmptyDirectories = false;
+ private boolean notifyEmptyDirectories;
/**
* Create a POIFSReader
Modified: poi/trunk/src/java/org/apache/poi/poifs/filesystem/DocumentDescriptor.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/poifs/filesystem/DocumentDescriptor.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/poifs/filesystem/DocumentDescriptor.java (original)
+++ poi/trunk/src/java/org/apache/poi/poifs/filesystem/DocumentDescriptor.java Sat Sep 16 08:22:59 2017
@@ -30,7 +30,7 @@ public class DocumentDescriptor
{
private POIFSDocumentPath path;
private String name;
- private int hashcode = 0;
+ private int hashcode;
/**
* Trivial constructor
Modified: poi/trunk/src/java/org/apache/poi/poifs/filesystem/Ole10Native.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/poifs/filesystem/Ole10Native.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/poifs/filesystem/Ole10Native.java (original)
+++ poi/trunk/src/java/org/apache/poi/poifs/filesystem/Ole10Native.java Sat Sep 16 08:22:59 2017
@@ -42,11 +42,11 @@ public class Ole10Native {
private short flags1 = 2; // 2 bytes, unknown, mostly [02 00]
private String label; // ASCIIZ, stored in this field without the terminating zero
private String fileName; // ASCIIZ, stored in this field without the terminating zero
- private short flags2 = 0; // 2 bytes, unknown, mostly [00 00]
+ private short flags2; // 2 bytes, unknown, mostly [00 00]
private short unknown1 = 3; // see below
private String command; // ASCIIZ, stored in this field without the terminating zero
private byte[] dataBuffer; // varying size, the actual native data
- private short flags3 = 0; // some final flags? or zero terminators?, sometimes not there
+ private short flags3; // some final flags? or zero terminators?, sometimes not there
/**
* the field encoding mode - merely a try-and-error guess ...
Modified: poi/trunk/src/java/org/apache/poi/poifs/filesystem/POIFSDocumentPath.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/poifs/filesystem/POIFSDocumentPath.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/poifs/filesystem/POIFSDocumentPath.java (original)
+++ poi/trunk/src/java/org/apache/poi/poifs/filesystem/POIFSDocumentPath.java Sat Sep 16 08:22:59 2017
@@ -36,7 +36,7 @@ public class POIFSDocumentPath
private static final POILogger log = POILogFactory.getLogger(POIFSDocumentPath.class);
private final String[] components;
- private int hashcode = 0; //lazy-compute hashCode
+ private int hashcode; //lazy-compute hashCode
/**
* constructor for the path of a document that is not in the root
Modified: poi/trunk/src/java/org/apache/poi/ss/format/CellDateFormatter.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/format/CellDateFormatter.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ss/format/CellDateFormatter.java (original)
+++ poi/trunk/src/java/org/apache/poi/ss/format/CellDateFormatter.java Sat Sep 16 08:22:59 2017
@@ -41,7 +41,7 @@ public class CellDateFormatter extends C
private final Calendar EXCEL_EPOCH_CAL =
LocaleUtil.getLocaleCalendar(1904, 0, 1);
- private static /* final */ CellDateFormatter SIMPLE_DATE = null;
+ private static /* final */ CellDateFormatter SIMPLE_DATE;
private class DatePartHandler implements CellFormatPart.PartHandler {
private int mStart = -1;
Modified: poi/trunk/src/java/org/apache/poi/ss/util/SheetBuilder.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/util/SheetBuilder.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ss/util/SheetBuilder.java (original)
+++ poi/trunk/src/java/org/apache/poi/ss/util/SheetBuilder.java Sat Sep 16 08:22:59 2017
@@ -35,8 +35,8 @@ public class SheetBuilder {
private final Workbook workbook;
private final Object[][] cells;
- private boolean shouldCreateEmptyCells = false;
- private String sheetName = null;
+ private boolean shouldCreateEmptyCells;
+ private String sheetName;
public SheetBuilder(Workbook workbook, Object[][] cells) {
this.workbook = workbook;
Modified: poi/trunk/src/java/org/apache/poi/ss/util/cellwalk/CellWalk.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/util/cellwalk/CellWalk.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ss/util/cellwalk/CellWalk.java (original)
+++ poi/trunk/src/java/org/apache/poi/ss/util/cellwalk/CellWalk.java Sat Sep 16 08:22:59 2017
@@ -110,9 +110,9 @@ public class CellWalk {
* @author Roman Kashitsyn
*/
private static class SimpleCellWalkContext implements CellWalkContext {
- public long ordinalNumber = 0;
- public int rowNumber = 0;
- public int colNumber = 0;
+ public long ordinalNumber;
+ public int rowNumber;
+ public int colNumber;
public long getOrdinalNumber() {
return ordinalNumber;
Modified: poi/trunk/src/java/org/apache/poi/util/BoundedInputStream.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/util/BoundedInputStream.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/util/BoundedInputStream.java (original)
+++ poi/trunk/src/java/org/apache/poi/util/BoundedInputStream.java Sat Sep 16 08:22:59 2017
@@ -42,7 +42,7 @@ public class BoundedInputStream extends
private final long max;
/** the number of bytes already returned */
- private long pos = 0;
+ private long pos;
/** the marked position */
private long mark = -1;
Modified: poi/trunk/src/java/org/apache/poi/util/CommonsLogger.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/util/CommonsLogger.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/util/CommonsLogger.java (original)
+++ poi/trunk/src/java/org/apache/poi/util/CommonsLogger.java Sat Sep 16 08:22:59 2017
@@ -31,7 +31,7 @@ import org.apache.commons.logging.LogFac
public class CommonsLogger extends POILogger
{
private static final LogFactory _creator = LogFactory.getFactory();
- private Log log = null;
+ private Log log;
@Override
public void initialize(final String cat)
Modified: poi/trunk/src/java/org/apache/poi/util/IntList.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/util/IntList.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/util/IntList.java (original)
+++ poi/trunk/src/java/org/apache/poi/util/IntList.java Sat Sep 16 08:22:59 2017
@@ -47,7 +47,7 @@ public class IntList
{
private int[] _array;
private int _limit;
- private int fillval = 0;
+ private int fillval;
private static final int _default_size = 128;
/**
Modified: poi/trunk/src/java/org/apache/poi/util/LittleEndianCP950Reader.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/util/LittleEndianCP950Reader.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/util/LittleEndianCP950Reader.java (original)
+++ poi/trunk/src/java/org/apache/poi/util/LittleEndianCP950Reader.java Sat Sep 16 08:22:59 2017
@@ -54,7 +54,7 @@ public class LittleEndianCP950Reader ext
private int offset;
private int trailing;
private int leading;
- int cnt = 0;
+ int cnt;
//the char that is logically trailing in Big5 encoding
//however in LittleEndian order, this is the first encountered.
public LittleEndianCP950Reader(byte[] data) {
Modified: poi/trunk/src/java/org/apache/poi/util/POILogFactory.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/util/POILogFactory.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/util/POILogFactory.java (original)
+++ poi/trunk/src/java/org/apache/poi/util/POILogFactory.java Sat Sep 16 08:22:59 2017
@@ -46,7 +46,7 @@ public final class POILogFactory {
* The name of the class to use. Initialised the
* first time we need it
*/
- static String _loggerClassName = null;
+ static String _loggerClassName;
/**
* Construct a POILogFactory.
Modified: poi/trunk/src/java/org/apache/poi/util/ReplacingInputStream.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/util/ReplacingInputStream.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/util/ReplacingInputStream.java (original)
+++ poi/trunk/src/java/org/apache/poi/util/ReplacingInputStream.java Sat Sep 16 08:22:59 2017
@@ -35,9 +35,9 @@ public class ReplacingInputStream extend
// while matching, this is where the bytes go.
final int[] buf;
- private int matchedIndex=0;
- private int unbufferIndex=0;
- private int replacedIndex=0;
+ private int matchedIndex;
+ private int unbufferIndex;
+ private int replacedIndex;
private final byte[] pattern;
private final byte[] replacement;
Modified: poi/trunk/src/java/org/apache/poi/util/StringUtil.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/util/StringUtil.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/util/StringUtil.java (original)
+++ poi/trunk/src/java/org/apache/poi/util/StringUtil.java Sat Sep 16 08:22:59 2017
@@ -315,7 +315,7 @@ public class StringUtil {
*/
public static class StringsIterator implements Iterator<String> {
private String[] strings = {};
- private int position = 0;
+ private int position;
public StringsIterator(String[] strings) {
if (strings != null) {
this.strings = strings.clone();
Modified: poi/trunk/src/ooxml/java/org/apache/poi/POIXMLDocumentPart.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/POIXMLDocumentPart.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/POIXMLDocumentPart.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/POIXMLDocumentPart.java Sat Sep 16 08:22:59 2017
@@ -93,7 +93,7 @@ public class POIXMLDocumentPart {
* Counter that provides the amount of incoming relations from other parts
* to this part.
*/
- private int relationCounter = 0;
+ private int relationCounter;
int incrementRelationCounter() {
relationCounter++;
Modified: poi/trunk/src/ooxml/java/org/apache/poi/openxml4j/opc/OPCPackage.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/openxml4j/opc/OPCPackage.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/openxml4j/opc/OPCPackage.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/openxml4j/opc/OPCPackage.java Sat Sep 16 08:22:59 2017
@@ -116,7 +116,7 @@ public abstract class OPCPackage impleme
/**
* Flag if a modification is done to the document.
*/
- protected boolean isDirty = false;
+ protected boolean isDirty;
/**
* File path of this package.
Modified: poi/trunk/src/ooxml/java/org/apache/poi/openxml4j/opc/internal/marshallers/PackagePropertiesMarshaller.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/openxml4j/opc/internal/marshallers/PackagePropertiesMarshaller.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/openxml4j/opc/internal/marshallers/PackagePropertiesMarshaller.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/openxml4j/opc/internal/marshallers/PackagePropertiesMarshaller.java Sat Sep 16 08:22:59 2017
@@ -80,7 +80,7 @@ public class PackagePropertiesMarshaller
PackagePropertiesPart propsPart;
// The document
- Document xmlDoc = null;
+ Document xmlDoc;
/**
* Marshall package core properties to an XML document. Always return
Modified: poi/trunk/src/ooxml/java/org/apache/poi/openxml4j/util/ZipSecureFile.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/openxml4j/util/ZipSecureFile.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/openxml4j/util/ZipSecureFile.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/openxml4j/util/ZipSecureFile.java Sat Sep 16 08:22:59 2017
@@ -197,8 +197,8 @@ public class ZipSecureFile extends ZipFi
}
public static class ThresholdInputStream extends PushbackInputStream {
- long counter = 0;
- long markPos = 0;
+ long counter;
+ long markPos;
ThresholdInputStream cis;
public ThresholdInputStream(InputStream is, ThresholdInputStream cis) {
Modified: poi/trunk/src/ooxml/java/org/apache/poi/poifs/crypt/dsig/SignatureConfig.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/poifs/crypt/dsig/SignatureConfig.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/poifs/crypt/dsig/SignatureConfig.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/poifs/crypt/dsig/SignatureConfig.java Sat Sep 16 08:22:59 2017
@@ -83,12 +83,12 @@ public class SignatureConfig {
* the optional signature policy service used for XAdES-EPES.
*/
private SignaturePolicyService signaturePolicyService;
- private URIDereferencer uriDereferencer = null;
+ private URIDereferencer uriDereferencer;
private String canonicalizationMethod = CanonicalizationMethod.INCLUSIVE;
private boolean includeEntireCertificateChain = true;
- private boolean includeIssuerSerial = false;
- private boolean includeKeyValue = false;
+ private boolean includeIssuerSerial;
+ private boolean includeKeyValue;
/**
* the time-stamp service used for XAdES-T and XAdES-X.
@@ -98,11 +98,11 @@ public class SignatureConfig {
* timestamp service provider URL
*/
private String tspUrl;
- private boolean tspOldProtocol = false;
+ private boolean tspOldProtocol;
/**
* if not defined, it's the same as the main digest
*/
- private HashAlgorithm tspDigestAlgo = null;
+ private HashAlgorithm tspDigestAlgo;
private String tspUser;
private String tspPass;
private TimeStampServiceValidator tspValidator;
@@ -121,8 +121,8 @@ public class SignatureConfig {
/**
* if not defined, it's the same as the main digest
*/
- private HashAlgorithm xadesDigestAlgo = null;
- private String xadesRole = null;
+ private HashAlgorithm xadesDigestAlgo;
+ private String xadesRole;
private String xadesSignatureId = "idSignedProperties";
private boolean xadesSignaturePolicyImplied = true;
private String xadesCanonicalizationMethod = CanonicalizationMethod.EXCLUSIVE;
@@ -150,7 +150,7 @@ public class SignatureConfig {
* with certain namespaces, so this EventListener is used to interfere
* with the marshalling process.
*/
- EventListener signatureMarshalListener = null;
+ EventListener signatureMarshalListener;
/**
* Map of namespace uris to prefix
Modified: poi/trunk/src/ooxml/java/org/apache/poi/poifs/crypt/dsig/SignatureInfo.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/poifs/crypt/dsig/SignatureInfo.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/poifs/crypt/dsig/SignatureInfo.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/poifs/crypt/dsig/SignatureInfo.java Sat Sep 16 08:22:59 2017
@@ -171,7 +171,7 @@ import org.xml.sax.SAXException;
public class SignatureInfo implements SignatureConfigurable {
private static final POILogger LOG = POILogFactory.getLogger(SignatureInfo.class);
- private static boolean isInitialized = false;
+ private static boolean isInitialized;
private SignatureConfig signatureConfig;
@@ -376,8 +376,8 @@ public class SignatureInfo implements Si
OPCPackage pkg = signatureConfig.getOpcPackage();
Iterator<PackageRelationship> sigOrigRels =
pkg.getRelationshipsByType(PackageRelationshipTypes.DIGITAL_SIGNATURE_ORIGIN).iterator();
- Iterator<PackageRelationship> sigRels = null;
- PackagePart sigPart = null;
+ Iterator<PackageRelationship> sigRels;
+ PackagePart sigPart;
public boolean hasNext() {
while (sigRels == null || !sigRels.hasNext()) {
Modified: poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/XDGFDocument.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/XDGFDocument.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/XDGFDocument.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/XDGFDocument.java Sat Sep 16 08:22:59 2017
@@ -40,10 +40,10 @@ public class XDGFDocument {
Map<Long, XDGFStyleSheet> _styleSheets = new HashMap<Long, XDGFStyleSheet>();
// defaults
- long _defaultFillStyle = 0;
- long _defaultGuideStyle = 0;
- long _defaultLineStyle = 0;
- long _defaultTextStyle = 0;
+ long _defaultFillStyle;
+ long _defaultGuideStyle;
+ long _defaultLineStyle;
+ long _defaultTextStyle;
public XDGFDocument(VisioDocumentType document) {
Modified: poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/XDGFMaster.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/XDGFMaster.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/XDGFMaster.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/XDGFMaster.java Sat Sep 16 08:22:59 2017
@@ -29,7 +29,7 @@ public class XDGFMaster {
private MasterType _master;
protected XDGFMasterContents _content;
- protected XDGFSheet _pageSheet = null;
+ protected XDGFSheet _pageSheet;
public XDGFMaster(MasterType master, XDGFMasterContents content,
XDGFDocument document) {
Modified: poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/XDGFPage.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/XDGFPage.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/XDGFPage.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/XDGFPage.java Sat Sep 16 08:22:59 2017
@@ -34,7 +34,7 @@ public class XDGFPage {
private PageType _page;
protected XDGFPageContents _content;
protected XDGFPages _pages;
- protected XDGFSheet _pageSheet = null;
+ protected XDGFSheet _pageSheet;
public XDGFPage(PageType page, XDGFPageContents content,
XDGFDocument document, XDGFPages pages) {
Modified: poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/XDGFShape.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/XDGFShape.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/XDGFShape.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/XDGFShape.java Sat Sep 16 08:22:59 2017
@@ -49,58 +49,58 @@ public class XDGFShape extends XDGFSheet
XDGFBaseContents _parentPage;
XDGFShape _parent; // only non-null if a subshape
- XDGFMaster _master = null;
- XDGFShape _masterShape = null;
+ XDGFMaster _master;
+ XDGFShape _masterShape;
- XDGFText _text = null;
+ XDGFText _text;
// subshapes if they exist
- List<XDGFShape> _shapes = null;
+ List<XDGFShape> _shapes;
// properties specific to shapes
// center of rotation relative to origin of parent
- Double _pinX = null;
- Double _pinY = null;
+ Double _pinX;
+ Double _pinY;
- Double _width = null;
- Double _height = null;
+ Double _width;
+ Double _height;
// center of rotation relative to self
- Double _locPinX = null;
- Double _locPinY = null;
+ Double _locPinX;
+ Double _locPinY;
// start x coordinate, relative to parent
// -> one dimensional shapes only
- Double _beginX = null;
- Double _beginY = null;
+ Double _beginX;
+ Double _beginY;
// end x coordinate, relative to parent
// -> one dimensional shapes only
- Double _endX = null;
- Double _endY = null;
+ Double _endX;
+ Double _endY;
- Double _angle = null;
- Double _rotationXAngle = null;
- Double _rotationYAngle = null;
- Double _rotationZAngle = null;
+ Double _angle;
+ Double _rotationXAngle;
+ Double _rotationYAngle;
+ Double _rotationZAngle;
// end x coordinate, relative to parent
- Boolean _flipX = null;
- Boolean _flipY = null;
+ Boolean _flipX;
+ Boolean _flipY;
// center of text relative to this shape
- Double _txtPinX = null;
- Double _txtPinY = null;
+ Double _txtPinX;
+ Double _txtPinY;
// center of text relative to text block
- Double _txtLocPinX = null;
- Double _txtLocPinY = null;
+ Double _txtLocPinX;
+ Double _txtLocPinY;
- Double _txtAngle = null;
+ Double _txtAngle;
- Double _txtWidth = null;
- Double _txtHeight = null;
+ Double _txtWidth;
+ Double _txtHeight;
public XDGFShape(ShapeSheetType shapeSheet, XDGFBaseContents parentPage,
XDGFDocument document) {
Modified: poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/XDGFSheet.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/XDGFSheet.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/XDGFSheet.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/XDGFSheet.java Sat Sep 16 08:22:59 2017
@@ -52,7 +52,7 @@ public abstract class XDGFSheet {
protected SortedMap<Long, GeometrySection> _geometry = new TreeMap<Long, GeometrySection>();
// special: character section
- protected CharacterSection _character = null;
+ protected CharacterSection _character;
public XDGFSheet(SheetType sheet, XDGFDocument document) {
try {
Modified: poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/CharacterSection.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/CharacterSection.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/CharacterSection.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/CharacterSection.java Sat Sep 16 08:22:59 2017
@@ -30,8 +30,8 @@ import com.microsoft.schemas.office.visi
public class CharacterSection extends XDGFSection {
- Double _fontSize = null;
- Color _fontColor = null;
+ Double _fontSize;
+ Color _fontColor;
Map<String, XDGFCell> _characterCells = new HashMap<String, XDGFCell>();
Modified: poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/CombinedIterable.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/CombinedIterable.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/CombinedIterable.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/CombinedIterable.java Sat Sep 16 08:22:59 2017
@@ -56,8 +56,8 @@ public class CombinedIterable<T> impleme
Long lastI = Long.MIN_VALUE;
- Entry<Long, T> currentBase = null;
- Entry<Long, T> currentMaster = null;
+ Entry<Long, T> currentBase;
+ Entry<Long, T> currentMaster;
// grab the iterator for both
Iterator<Entry<Long, T>> baseI = _baseItems.entrySet().iterator();
Modified: poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/GeometrySection.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/GeometrySection.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/GeometrySection.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/GeometrySection.java Sat Sep 16 08:22:59 2017
@@ -40,7 +40,7 @@ import com.microsoft.schemas.office.visi
public class GeometrySection extends XDGFSection {
- GeometrySection _master = null;
+ GeometrySection _master;
// rows
SortedMap<Long, GeometryRow> _rows = new TreeMap<Long, GeometryRow>();
Modified: poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/ArcTo.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/ArcTo.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/ArcTo.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/ArcTo.java Sat Sep 16 08:22:59 2017
@@ -31,18 +31,18 @@ import com.microsoft.schemas.office.visi
public class ArcTo implements GeometryRow {
- ArcTo _master = null;
+ ArcTo _master;
// The x-coordinate of the ending vertex of an arc.
- Double x = null;
+ Double x;
// The y-coordinate of the ending vertex of an arc.
- Double y = null;
+ Double y;
// The distance from the arc's midpoint to the midpoint of its chord.
- Double a = null;
+ Double a;
- Boolean deleted = null;
+ Boolean deleted;
// TODO: support formulas
Modified: poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/Ellipse.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/Ellipse.java?rev=1808510&r1=1808509&r2=1808510&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/Ellipse.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/Ellipse.java Sat Sep 16 08:22:59 2017
@@ -30,24 +30,24 @@ import com.microsoft.schemas.office.visi
public class Ellipse implements GeometryRow {
- Ellipse _master = null;
+ Ellipse _master;
// x coordinate of center point
- Double x = null;
+ Double x;
// y coordinate of center point
- Double y = null;
+ Double y;
// x coordinate of first point on ellipse
- Double a = null;
+ Double a;
// y coordinate of first point on ellipse
- Double b = null;
+ Double b;
// x coordinate of second point on ellipse
- Double c = null;
+ Double c;
// y coordinate of second point on ellipse
- Double d = null;
+ Double d;
- Boolean deleted = null;
+ Boolean deleted;
// TODO: support formulas
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org