You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "davsclaus (via GitHub)" <gi...@apache.org> on 2026/07/20 07:34:57 UTC
[PR] CAMEL-24176: camel-cxfrs - Fix async producer never mapping HTTP errors to CxfOperationException [camel]
davsclaus opened a new pull request, #24924:
URL: https://github.com/apache/camel/pull/24924
_Claude Code on behalf of davsclaus_
## Summary
Fix two bugs in the async CXF-RS producer's `fail()` callback in both `CxfInvocationCallback` and `CxfProxyInvocationCallback`:
1. **Reversed `isInstance` check** — `throwable.getClass().isInstance(WebApplicationException.class)` always evaluates to `false` because it tests whether the `Class` object is an instance of the throwable's class (which it never is). Both `if` branches were dead code, so every async failure fell through to `exchange.setException(throwable)` with the raw JAX-RS exception instead of wrapping it in `CxfOperationException`. Fixed by replacing with `throwable instanceof WebApplicationException` (same for `ResponseProcessingException`).
2. **Silent exception swallowing** — When `shouldHandleError()` returned `false` (e.g., `throwExceptionOnFailure=false` or status ≤ 207), neither `handleError()` nor `exchange.setException()` was called — the exception was silently dropped. Added `else { exchange.setException(throwable); }` fallback in each branch.
## Impact
With the default `synchronous=false`, a server error (404/500) now correctly yields a `CxfOperationException` (carrying status code, response headers and body) — matching the synchronous path behavior. `onException(CxfOperationException.class)` handlers now work consistently regardless of sync/async mode.
## Test plan
- [x] Added `testAsyncProxyProducerServerErrorMappedToCxfOperationException` — calls via the proxy client API with an invalid ID that triggers a 500 on the server; verifies the exchange exception is `CxfOperationException` with status 500 (not a raw `InternalServerErrorException`)
- [x] All 18 existing `CxfRsAsyncProducerTest` tests pass
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.6 <no...@anthropic.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24176: camel-cxfrs - Fix async producer never mapping HTTP errors to CxfOperationException [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #24924:
URL: https://github.com/apache/camel/pull/24924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24176: camel-cxfrs - Fix async producer never mapping HTTP errors to CxfOperationException [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24924:
URL: https://github.com/apache/camel/pull/24924#issuecomment-5020112548
<!-- ci-tested-modules -->
:test_tube: **CI tested the following changed modules:**
- `components/camel-cxf/camel-cxf-rest`
- `components/camel-cxf/camel-cxf-spring-rest`
---
<details><summary>:microscope: Scalpel shadow comparison — Scalpel: 16 tested, 29 compile-only — current: 16 all tested</summary>
[Maveniverse Scalpel](https://github.com/maveniverse/scalpel) detected **45 affected modules** (current approach: 16).
<details><summary>:warning: Modules only in Scalpel (29)</summary>
- `apache-camel`
- `camel-allcomponents`
- `camel-catalog`
- `camel-catalog-console`
- `camel-catalog-lucene`
- `camel-catalog-maven`
- `camel-catalog-suggest`
- `camel-componentdsl`
- `camel-csimple-maven-plugin`
- `camel-endpointdsl`
- `camel-endpointdsl-support`
- `camel-itest`
- `camel-jbang-core`
- `camel-jbang-it`
- `camel-jbang-main`
- `camel-jbang-plugin-edit`
- `camel-jbang-plugin-generate`
- `camel-jbang-plugin-kubernetes`
- `camel-jbang-plugin-test`
- `camel-kamelet-main`
- `camel-launcher`
- `camel-report-maven-plugin`
- `camel-route-parser`
- `camel-yaml-dsl`
- `camel-yaml-dsl-deserializers`
- `camel-yaml-dsl-maven-plugin`
- `coverage`
- `docs`
- `dummy-component`
</details>
**Skip-tests mode would test 16 modules** (2 direct + 14 downstream), **skip tests for 29** (generated code, meta-modules)
<details><summary>Modules Scalpel would test (16)</summary>
- `camel-cxf-rest`
- `camel-cxf-spring-rest`
- `camel-jbang-mcp`
- `camel-jbang-plugin-mcp`
- `camel-jbang-plugin-route-parser`
- `camel-jbang-plugin-tui`
- `camel-jbang-plugin-validate`
- `camel-launcher-container`
- `camel-micrometer-observability`
- `camel-observability-services`
- `camel-opentelemetry`
- `camel-opentelemetry2`
- `camel-telemetry`
- `camel-telemetry-dev`
- `camel-yaml-dsl-validator`
- `camel-yaml-dsl-validator-maven-plugin`
</details>
<details><summary>Modules with tests skipped (29)</summary>
- `apache-camel`
- `camel-allcomponents`
- `camel-catalog`
- `camel-catalog-console`
- `camel-catalog-lucene`
- `camel-catalog-maven`
- `camel-catalog-suggest`
- `camel-componentdsl`
- `camel-csimple-maven-plugin`
- `camel-endpointdsl`
- `camel-endpointdsl-support`
- `camel-itest`
- `camel-jbang-core`
- `camel-jbang-it`
- `camel-jbang-main`
- `camel-jbang-plugin-edit`
- `camel-jbang-plugin-generate`
- `camel-jbang-plugin-kubernetes`
- `camel-jbang-plugin-test`
- `camel-kamelet-main`
- `camel-launcher`
- `camel-report-maven-plugin`
- `camel-route-parser`
- `camel-yaml-dsl`
- `camel-yaml-dsl-deserializers`
- `camel-yaml-dsl-maven-plugin`
- `coverage`
- `docs`
- `dummy-component`
</details>
> :information_source: Shadow mode — Scalpel observes but does not affect test execution. [Learn more](https://github.com/maveniverse/scalpel)
</details>
<details><summary>All tested modules (45 modules)</summary>
- Camel :: All Components Sync point
- Camel :: Assembly
- Camel :: CXF :: REST
- Camel :: CXF :: REST :: Spring
- Camel :: Catalog :: CSimple Maven Plugin (deprecated)
- Camel :: Catalog :: Camel Catalog
- Camel :: Catalog :: Camel Report Maven Plugin
- Camel :: Catalog :: Camel Route Parser
- Camel :: Catalog :: Console
- Camel :: Catalog :: Dummy Component
- Camel :: Catalog :: Lucene (deprecated)
- Camel :: Catalog :: Maven
- Camel :: Catalog :: Suggest
- Camel :: Common Telemetry
- Camel :: Component DSL
- Camel :: Coverage
- Camel :: Docs
- Camel :: Endpoint DSL
- Camel :: Endpoint DSL :: Support
- Camel :: Integration Tests
- Camel :: JBang :: Core
- Camel :: JBang :: Integration tests
- Camel :: JBang :: MCP
- Camel :: JBang :: Main
- Camel :: JBang :: Plugin :: Edit
- Camel :: JBang :: Plugin :: Generate
- Camel :: JBang :: Plugin :: Kubernetes
- Camel :: JBang :: Plugin :: MCP
- Camel :: JBang :: Plugin :: Route Parser
- Camel :: JBang :: Plugin :: TUI
- Camel :: JBang :: Plugin :: Testing
- Camel :: JBang :: Plugin :: Validate
- Camel :: Kamelet Main
- Camel :: Launcher
- Camel :: Launcher :: Container
- Camel :: Micrometer :: Observability 2
- Camel :: Observability Services
- Camel :: OpenTelemetry (deprecated)
- Camel :: Opentelemetry 2
- Camel :: Telemetry :: Dev
- Camel :: YAML DSL
- Camel :: YAML DSL :: Deserializers
- Camel :: YAML DSL :: Maven Plugins
- Camel :: YAML DSL :: Validator
- Camel :: YAML DSL :: Validator Maven Plugin
</details>
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/29725065659)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24176: camel-cxfrs - Fix async producer never mapping HTTP errors to CxfOperationException [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24924:
URL: https://github.com/apache/camel/pull/24924#issuecomment-5019837366
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org