You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2017/02/14 19:31:03 UTC

[GitHub] flink pull request #3310: [FLINK-5798] [rpc] Let the RpcService provide a Sc...

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/3310

    [FLINK-5798] [rpc] Let the RpcService provide a ScheduledExecutorService

    This PR adds the getScheduledExecutorService method to the RpcService interface. So
    henceforth all RpcService implementations have to provide a ScheduledExecutorService
    implementation.
    
    Currently, we only support the AkkaRpcService. The AkkaRpcService returns a
    ScheduledExecutorService proxy which forwards the schedule calls to the ActorSystem's
    internal scheduler.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink rpcAddScheduledExecutorService

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3310.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3310
    
----
commit 639edf235ffee924e0fba56313cb51f825e3a46d
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-02-14T15:50:43Z

    [FLINK-5798] [rpc] Let the RpcService provide a ScheduledExecutorService
    
    This PR adds the getScheduledExecutorService method to the RpcService interface. So
    henceforth all RpcService implementations have to provide a ScheduledExecutorService
    implementation.
    
    Currently, we only support the AkkaRpcService. The AkkaRpcService returns a
    ScheduledExecutorService proxy which forwards the schedule calls to the ActorSystem's
    internal scheduler.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3310: [FLINK-5798] [rpc] Let the RpcService provide a Scheduled...

Posted by tillrohrmann <gi...@git.apache.org>.

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/3310
  
    Thanks for the review @StephanEwen. Merging the PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3310: [FLINK-5798] [rpc] Let the RpcService provide a Scheduled...

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3310
  
    Looks very good to me!
    +1 to merge this...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3310: [FLINK-5798] [rpc] Let the RpcService provide a Sc...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/3310


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---