You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/01/31 12:07:47 UTC

[GitHub] mik-laj commented on a change in pull request #4635: [AIRFLOW-XXX] Change default value for hive_tblproperties

mik-laj commented on a change in pull request #4635: [AIRFLOW-XXX] Change default value for hive_tblproperties 
URL: https://github.com/apache/airflow/pull/4635#discussion_r252641815
 
 

 ##########
 File path: airflow/operators/hive_to_druid.py
 ##########
 @@ -78,7 +78,7 @@ def __init__(
             target_partition_size=-1,
             query_granularity="NONE",
             segment_granularity="DAY",
-            hive_tblproperties=None,
+            hive_tblproperties=dict(),
 
 Review comment:
   https://stackoverflow.com/questions/26320899/why-is-the-empty-dictionary-a-dangerous-default-value-in-python

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services