[jira] [Commented] (ARTEMIS-1340) JMS test JMSQueueBrowserTest#testQueueBrowserInTxSessionLeavesOtherWorkUnaffected fails with the OpenWire protocol (activemq-client JMS library)

["Howard Gao (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16312449#comment-16312449 ] 

Howard Gao commented on ARTEMIS-1340:
-------------------------------------

The reason for the failure with openwire is that if a queue browser is created from a transactional (local) session, it will commit the transaction when the browser is done (either the last message is browsed or the browser is closed). 

I'd suggest we don't fix this as this is not a normal use case. A simple workaround would be to just use another session for the queue browser.



> JMS test JMSQueueBrowserTest#testQueueBrowserInTxSessionLeavesOtherWorkUnaffected fails with the OpenWire protocol (activemq-client JMS library)
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-1340
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1340
>             Project: ActiveMQ Artemis
>          Issue Type: Test
>          Components: Broker, OpenWire
>    Affects Versions: 2.3.0
>            Reporter: Jiri Daněk
>
> Consider test {{org.apache.activemq.artemis.tests.integration.amqp.JMSQueueBrowserTest#testQueueBrowserInTxSessionLeavesOtherWorkUnaffected}}. When it is modified to run with multiple JMS ConnectionFactories, then it passes with Core and AMQP, and fails with OpenWire.
> The location of fail is
> {noformat}
>       // Now check that all browser work did not affect the session transaction.
>       assertEquals(5, queueView.getMessageCount());
> {noformat}
> The error is
> {noformat}
> java.lang.AssertionError: 
> Expected :5
> Actual   :10
> {noformat}
> I tried placing a {{Thread.sleep(5000)}} before the check; the test still failed for the same reason, with the same error.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)