You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "dengwenqi123 (via GitHub)" <gi...@apache.org> on 2023/08/21 12:48:36 UTC
[GitHub] [nuttx] dengwenqi123 opened a new pull request, #10335: tools/refresh.sh: Add option to refresh custom board
dengwenqi123 opened a new pull request, #10335:
URL: https://github.com/apache/nuttx/pull/10335
This patch modify the script to update only the boards configs of an specific chip or only the boards of an specific architecture.
Examples:
refresh.sh add custom board verify
custom board:
$ ./tools/refresh.sh --silent /xxx/xxx/configs/ap
./tools/refresh.sh --silent ../../xxx/configs/ap
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #10335: tools/refresh.sh: Add option to refresh custom board
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #10335:
URL: https://github.com/apache/nuttx/pull/10335#discussion_r1301265069
##########
tools/refresh.sh:
##########
@@ -151,6 +152,14 @@ for CONFIG in ${CONFIGS}; do
fi
BOARDDIR=boards/*/*/$BOARDSUBDIR
+ if [ ! -d "$BOARDDIR" ]; then
+ CONFIGSUBDIR=`basename ${CONFIG}`
+ BOARDDIR=$(dirname `dirname ${CONFIG}`)
+ if [[ ! $CONFIG =~ ^/ ]];then
Review Comment:
if [ ! -d "$BOARDDIR" ]; then
##########
tools/refresh.sh:
##########
@@ -18,6 +18,7 @@
#
WD=`test -d ${0%/*} && cd ${0%/*}; pwd`
+excution_dir=`pwd`
Review Comment:
excution_dir->PWD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #10335: tools/refresh.sh: Add option to refresh custom board
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #10335:
URL: https://github.com/apache/nuttx/pull/10335#discussion_r1301309765
##########
tools/refresh.sh:
##########
@@ -18,6 +18,7 @@
#
WD=`test -d ${0%/*} && cd ${0%/*}; pwd`
+excution_dir=`pwd`
Review Comment:
CWD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #10335: tools/refresh.sh: Add option to refresh custom board
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #10335:
URL: https://github.com/apache/nuttx/pull/10335#discussion_r1301826383
##########
tools/refresh.sh:
##########
@@ -151,6 +152,14 @@ for CONFIG in ${CONFIGS}; do
fi
BOARDDIR=boards/*/*/$BOARDSUBDIR
Review Comment:
let's change to:
```
BOARDDIR=${CONFIG}
if [ ! -d $BOARDDIR ]; then
BOARDDIR="${CWD}/${BOARDDIR}"
fi
if [ -d $BOARDDIR ]; then
CONFIGSUBDIR=`basename ${CONFIG}`
BOARDDIR=$(dirname `dirname ${BOARDDIR}`)
else
BOARDDIR=boards/*/*/$BOARDSUBDIR
fi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #10335: tools/refresh.sh: Add option to refresh custom board
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #10335:
URL: https://github.com/apache/nuttx/pull/10335#issuecomment-1690448931
let's ignore the temp ci failure to merge this simple change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #10335: tools/refresh.sh: Add option to refresh custom board
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #10335:
URL: https://github.com/apache/nuttx/pull/10335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] dengwenqi123 commented on a diff in pull request #10335: tools/refresh.sh: Add option to refresh custom board
Posted by "dengwenqi123 (via GitHub)" <gi...@apache.org>.
dengwenqi123 commented on code in PR #10335:
URL: https://github.com/apache/nuttx/pull/10335#discussion_r1301156503
##########
tools/refresh.sh:
##########
@@ -278,4 +317,4 @@ for CONFIG in ${CONFIGS}; do
fi
done
-exit $diff
+exit $diff
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #10335: tools/refresh.sh: Add option to refresh custom board
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #10335:
URL: https://github.com/apache/nuttx/pull/10335#discussion_r1301826383
##########
tools/refresh.sh:
##########
@@ -151,6 +152,14 @@ for CONFIG in ${CONFIGS}; do
fi
BOARDDIR=boards/*/*/$BOARDSUBDIR
Review Comment:
let's change to:
```
BOARDDIR=${CONFIG}
if [ ! -d $BOARDDIR ]; then
BOARDDIR="${CWD}/${BOARDDIR}"
fi
if [ -d $BOARDDIR ]; then
CONFIGSUBDIR=`basename ${CONFIG}`
BOARDDIR=$(dirname `dirname ${BOARDDIR}`)
else
BOARDDIR=boards/*/*/$BOARDSUBDIR
fi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #10335: tools/refresh.sh: Add option to refresh custom board
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #10335:
URL: https://github.com/apache/nuttx/pull/10335#discussion_r1300542977
##########
tools/refresh.sh:
##########
@@ -278,4 +317,4 @@ for CONFIG in ${CONFIGS}; do
fi
done
-exit $diff
+exit $diff
Review Comment:
revert the change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #10335: tools/refresh.sh: Add option to refresh custom board
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #10335:
URL: https://github.com/apache/nuttx/pull/10335#discussion_r1301826383
##########
tools/refresh.sh:
##########
@@ -151,6 +152,14 @@ for CONFIG in ${CONFIGS}; do
fi
BOARDDIR=boards/*/*/$BOARDSUBDIR
Review Comment:
let's change to:
```
BOARDDIR=$(dirname `dirname ${CONFIG}`)
if [ ! -d $BOARDDIR ]; then
BOARDDIR="${CWD}/${BOARDDIR}"
fi
if [ -d $BOARDDIR ]; then
CONFIGSUBDIR=`basename ${CONFIG}`
else
BOARDDIR=boards/*/*/$BOARDSUBDIR
fi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org