[GitHub] [airflow] o-nikolas commented on a diff in pull request #28528: Fixes to how DebugExecutor handles sensors

[GitBox <gi...@apache.org>]

o-nikolas commented on code in PR #28528:
URL: https://github.com/apache/airflow/pull/28528#discussion_r1062796629


##########
airflow/ti_deps/deps/ready_to_reschedule.py:
##########
@@ -44,7 +45,8 @@ def _get_dep_statuses(self, ti, session, dep_context):
         from airflow.models.mappedoperator import MappedOperator
 
         is_mapped = isinstance(ti.task, MappedOperator)
-        if not is_mapped and not getattr(ti.task, "reschedule", False):
+        is_debug_executor = conf.get("core", "executor") == "DebugExecutor"

Review Comment:
   Oh no! This is definitely new executor coupling being added, we should not add this as it is.
   
   I apologize but I'm missing some context for this specific line change. Why do we need to know if this is the debug executor or not? Shouldn't we just need to know that the task is being rescheduled (by any executor)?
   
   > maybe we could also add "is_debug" as part of AIP-51?
   
   @potiuk this is covered by the single threaded case actually, which is more precisely what the issue is. Any single threaded executor needs to reschedule sensors otherwise the thread will be blocked when the sensor sleeps.
   
   See 2c here: https://github.com/apache/airflow/issues/27929



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org