[incubator-pinot] branch master updated: Make some things public (#7186)

[ja...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new a0ad49d  Make some things public (#7186)
a0ad49d is described below

commit a0ad49d4e0819731b54e6ab541541f1e2ed0aeaa
Author: Bilal Munir Mughal <bi...@users.noreply.github.com>
AuthorDate: Wed Jul 21 16:58:47 2021 -0700

    Make some things public (#7186)
    
    Making some classes and class methods for `pinot-java-client` public to be accessible for extending some end-to-end feature testing. E.g. we need create test scenarios to mock Pinot response with custom `ExecutionStats` and `ResultTableResultSet`. By making these public, we can also extend `AbstractResultSet` and make our custom response implementation for testing.
---
 .../src/main/java/org/apache/pinot/client/AbstractResultSet.java        | 2 +-
 .../src/main/java/org/apache/pinot/client/ExecutionStats.java           | 2 +-
 .../src/main/java/org/apache/pinot/client/ResultTableResultSet.java     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/AbstractResultSet.java b/pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/AbstractResultSet.java
index e1dbdd2..16d764b 100644
--- a/pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/AbstractResultSet.java
+++ b/pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/AbstractResultSet.java
@@ -21,7 +21,7 @@ package org.apache.pinot.client;
 /**
  * Shared implementation between the different ResultSets.
  */
-abstract class AbstractResultSet implements ResultSet {
+public abstract class AbstractResultSet implements ResultSet {
 
   @Override
   public String getColumnDataType(int columnIndex) {
diff --git a/pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/ExecutionStats.java b/pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/ExecutionStats.java
index f12ee37..77f76ed 100644
--- a/pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/ExecutionStats.java
+++ b/pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/ExecutionStats.java
@@ -51,7 +51,7 @@ public class ExecutionStats {
     this.brokerResponse = brokerResponse;
   }
 
-  static ExecutionStats fromJson(JsonNode json) {
+  public static ExecutionStats fromJson(JsonNode json) {
     return new ExecutionStats(json);
   }
 
diff --git a/pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/ResultTableResultSet.java b/pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/ResultTableResultSet.java
index a913622..681cf56 100644
--- a/pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/ResultTableResultSet.java
+++ b/pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/ResultTableResultSet.java
@@ -26,7 +26,7 @@ import java.util.List;
 /**
  * ResultSet which contains the ResultTable from the broker response of a sql query.
  */
-class ResultTableResultSet extends AbstractResultSet {
+public class ResultTableResultSet extends AbstractResultSet {
   private final JsonNode _rowsArray;
   private final JsonNode _columnNamesArray;
   private final JsonNode _columnDataTypesArray;

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org