[GitHub] [arrow] felipecrv commented on a diff in pull request #35750: GH-35749: [C++] Handle run-end encoded filters in compute kernels

["felipecrv (via GitHub)" <gi...@apache.org>]

felipecrv commented on code in PR #35750:
URL: https://github.com/apache/arrow/pull/35750#discussion_r1218545713


##########
cpp/src/arrow/compute/kernels/ree_util_internal.h:
##########
@@ -83,6 +83,18 @@ class ReadWriteValue<ArrowType, in_has_validity_buffer, out_has_validity_buffer,
     return valid;
   }
 
+  /// Pre-conditions guaranteed by the callers:
+  /// - i and j are valid indices into the values buffer
+  /// - the values in i and j are valid
+  bool CompareValuesAt(int64_t i, int64_t j) const {

Review Comment:
   Comparing values is commonly used when run-end encoding kernels. I would happily move it out of here if you have a suggestion. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org