[GitHub] [shardingsphere] sandynz commented on a change in pull request #14782: For #14733：PostgreSQL 14 bit data type are abnormal during full migration

[GitBox <gi...@apache.org>]

sandynz commented on a change in pull request #14782:
URL: https://github.com/apache/shardingsphere/pull/14782#discussion_r785267901



##########
File path: shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-dialect/shardingsphere-data-pipeline-postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/PostgreSQLInventoryDumper.java
##########
@@ -49,10 +52,26 @@ protected Object readValue(final ResultSet resultSet, final int index) throws SQ
         if (isPgMoneyType(resultSet, index)) {
             return resultSet.getBigDecimal(index);
         }
+        if (isPgBitType(resultSet, index)) {
+            PGobject pGobject = new PGobject();

Review comment:
       `pGobject` should be named to `result`

##########
File path: shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-dialect/shardingsphere-data-pipeline-postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/PostgreSQLInventoryDumper.java
##########
@@ -49,10 +52,26 @@ protected Object readValue(final ResultSet resultSet, final int index) throws SQ
         if (isPgMoneyType(resultSet, index)) {
             return resultSet.getBigDecimal(index);
         }
+        if (isPgBitType(resultSet, index)) {

Review comment:
       It's better to check sqlType (java.sql.Types) first (like `getObject` impl in PG driver), to reduce unnecessary string comparison.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org