[GitHub] [incubator-pinot] npawar commented on a change in pull request #4096: Add integration test for BrokerResourceValidationManager

[GitBox <gi...@apache.org>]

npawar commented on a change in pull request #4096: Add integration test for BrokerResourceValidationManager
URL: https://github.com/apache/incubator-pinot/pull/4096#discussion_r284053336
 
 

 ##########
 File path: pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java
 ##########
 @@ -453,6 +455,19 @@ public void setBrokerResourceValidationFrequencyInSeconds(int validationFrequenc
         Integer.toString(validationFrequencyInSeconds));
   }
 
+  public long getBrokerResourceValidationInitialDelayInSeconds() {
 
 Review comment:
   I think getLong(String key, long defaultValue) should be sufficient, and we won't have to check all this (similar to getRetentionManagerInitialDelay and getStatusCheckerInitialDelay and others)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org