You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "dragon-zhang (via GitHub)" <gi...@apache.org> on 2024/02/05 08:54:53 UTC
[PR] [ISSUE #4687] part2: RewritePlugin/ContextPathPlugin supports across application and plugin [shenyu]
dragon-zhang opened a new pull request, #5438:
URL: https://github.com/apache/shenyu/pull/5438
<!-- Describe your PR here; e.g. Fixes #issueNo -->
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [x] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [ ] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #4687] part2: RewritePlugin/ContextPathPlugin supports across application and plugin [shenyu]
Posted by "dragon-zhang (via GitHub)" <gi...@apache.org>.
dragon-zhang commented on PR #5438:
URL: https://github.com/apache/shenyu/pull/5438#issuecomment-1926493972
Still need init&upgrade sql.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #4687] part2: RewritePlugin/ContextPathPlugin supports across application and plugin [shenyu]
Posted by "loongs-zhang (via GitHub)" <gi...@apache.org>.
loongs-zhang merged PR #5438:
URL: https://github.com/apache/shenyu/pull/5438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #4687] part2: RewritePlugin/ContextPathPlugin supports across application and plugin [shenyu]
Posted by "dragon-zhang (via GitHub)" <gi...@apache.org>.
dragon-zhang commented on PR #5438:
URL: https://github.com/apache/shenyu/pull/5438#issuecomment-1931449910
> Still need init&upgrade sql.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #4687] part2: RewritePlugin/ContextPathPlugin supports across application and plugin [shenyu]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5438:
URL: https://github.com/apache/shenyu/pull/5438#issuecomment-1926574204
## [Codecov](https://app.codecov.io/gh/apache/shenyu/pull/5438?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `46 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`71cb378`)](https://app.codecov.io/gh/apache/shenyu/commit/71cb3787f77f978d1a15a3f885269d637556610c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 61.03% compared to head [(`2be37be`)](https://app.codecov.io/gh/apache/shenyu/pull/5438?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 60.92%.
| [Files](https://app.codecov.io/gh/apache/shenyu/pull/5438?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...rg/apache/shenyu/plugin/rewrite/RewritePlugin.java](https://app.codecov.io/gh/apache/shenyu/pull/5438?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vcmV3cml0ZS9SZXdyaXRlUGx1Z2luLmphdmE=) | 26.31% | [12 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/shenyu/pull/5438?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/shenyu/plugin/divide/DividePlugin.java](https://app.codecov.io/gh/apache/shenyu/pull/5438?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXByb3h5L3NoZW55dS1wbHVnaW4tZGl2aWRlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL2RpdmlkZS9EaXZpZGVQbHVnaW4uamF2YQ==) | 0.00% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/shenyu/pull/5438?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...to/convert/rule/impl/ContextMappingRuleHandle.java](https://app.codecov.io/gh/apache/shenyu/pull/5438?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9kdG8vY29udmVydC9ydWxlL2ltcGwvQ29udGV4dE1hcHBpbmdSdWxlSGFuZGxlLmphdmE=) | 12.50% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/shenyu/pull/5438?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../shenyu/plugin/context/path/ContextPathPlugin.java](https://app.codecov.io/gh/apache/shenyu/pull/5438?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWNvbnRleHQtcGF0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9jb250ZXh0L3BhdGgvQ29udGV4dFBhdGhQbHVnaW4uamF2YQ==) | 30.00% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/shenyu/pull/5438?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../shenyu/common/dto/convert/rule/RewriteHandle.java](https://app.codecov.io/gh/apache/shenyu/pull/5438?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9kdG8vY29udmVydC9ydWxlL1Jld3JpdGVIYW5kbGUuamF2YQ==) | 16.66% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/shenyu/pull/5438?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...u/plugin/base/condition/data/URIParameterData.java](https://app.codecov.io/gh/apache/shenyu/pull/5438?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vYmFzZS9jb25kaXRpb24vZGF0YS9VUklQYXJhbWV0ZXJEYXRhLmphdmE=) | 50.00% | [2 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/shenyu/pull/5438?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #5438 +/- ##
============================================
- Coverage 61.03% 60.92% -0.12%
+ Complexity 8647 8645 -2
============================================
Files 1258 1258
Lines 38375 38429 +54
Branches 3670 3682 +12
============================================
- Hits 23422 23412 -10
- Misses 12845 12896 +51
- Partials 2108 2121 +13
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/shenyu/pull/5438?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org