You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ap...@apache.org on 2018/01/23 23:21:21 UTC
hbase git commit: HBASE-19780 Remove execution phase and goal of
checkstyle plugin.
Repository: hbase
Updated Branches:
refs/heads/master d589b7238 -> 0b6422658
HBASE-19780 Remove execution phase and goal of checkstyle plugin.
We don't do checkstyle as part of default "mvn install" since it takes significant
amount of time (~90sec) and slows builds and development. We only need it for pre-commits.
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/0b642265
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/0b642265
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/0b642265
Branch: refs/heads/master
Commit: 0b6422658c6adff8e38d785b3cec4d2cf3b3bc93
Parents: d589b72
Author: Apekshit Sharma <ap...@apache.org>
Authored: Fri Jan 12 15:06:08 2018 -0800
Committer: Apekshit Sharma <ap...@apache.org>
Committed: Tue Jan 23 15:08:04 2018 -0800
----------------------------------------------------------------------
hbase-annotations/pom.xml | 15 ++-----
hbase-archetypes/pom.xml | 15 ++-----
hbase-build-support/hbase-error-prone/pom.xml | 15 ++-----
hbase-external-blockcache/pom.xml | 15 ++-----
hbase-hadoop-compat/pom.xml | 15 ++-----
hbase-metrics-api/pom.xml | 15 ++-----
hbase-metrics/pom.xml | 15 ++-----
hbase-protocol-shaded/pom.xml | 51 +++++++++-------------
hbase-protocol/pom.xml | 15 ++-----
hbase-replication/pom.xml | 15 ++-----
hbase-rsgroup/pom.xml | 15 ++-----
hbase-spark-it/pom.xml | 15 ++-----
hbase-spark/pom.xml | 15 ++-----
hbase-thrift/pom.xml | 15 ++-----
pom.xml | 26 ++---------
15 files changed, 64 insertions(+), 208 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/0b642265/hbase-annotations/pom.xml
----------------------------------------------------------------------
diff --git a/hbase-annotations/pom.xml b/hbase-annotations/pom.xml
index 86eb313..94c506b 100644
--- a/hbase-annotations/pom.xml
+++ b/hbase-annotations/pom.xml
@@ -36,18 +36,9 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
- <executions>
- <execution>
- <id>checkstyle</id>
- <phase>validate</phase>
- <goals>
- <goal>check</goal>
- </goals>
- <configuration>
- <failOnViolation>true</failOnViolation>
- </configuration>
- </execution>
- </executions>
+ <configuration>
+ <failOnViolation>true</failOnViolation>
+ </configuration>
</plugin>
</plugins>
</build>
http://git-wip-us.apache.org/repos/asf/hbase/blob/0b642265/hbase-archetypes/pom.xml
----------------------------------------------------------------------
diff --git a/hbase-archetypes/pom.xml b/hbase-archetypes/pom.xml
index 58ac89a..f33a216 100644
--- a/hbase-archetypes/pom.xml
+++ b/hbase-archetypes/pom.xml
@@ -81,18 +81,9 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
- <executions>
- <execution>
- <id>checkstyle</id>
- <phase>validate</phase>
- <goals>
- <goal>check</goal>
- </goals>
- <configuration>
- <failOnViolation>true</failOnViolation>
- </configuration>
- </execution>
- </executions>
+ <configuration>
+ <failOnViolation>true</failOnViolation>
+ </configuration>
</plugin>
</plugins>
</build>
http://git-wip-us.apache.org/repos/asf/hbase/blob/0b642265/hbase-build-support/hbase-error-prone/pom.xml
----------------------------------------------------------------------
diff --git a/hbase-build-support/hbase-error-prone/pom.xml b/hbase-build-support/hbase-error-prone/pom.xml
index b90d733..343bb3e 100644
--- a/hbase-build-support/hbase-error-prone/pom.xml
+++ b/hbase-build-support/hbase-error-prone/pom.xml
@@ -71,18 +71,9 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
- <executions>
- <execution>
- <id>checkstyle</id>
- <phase>validate</phase>
- <goals>
- <goal>check</goal>
- </goals>
- <configuration>
- <failOnViolation>true</failOnViolation>
- </configuration>
- </execution>
- </executions>
+ <configuration>
+ <failOnViolation>true</failOnViolation>
+ </configuration>
</plugin>
</plugins>
</build>
http://git-wip-us.apache.org/repos/asf/hbase/blob/0b642265/hbase-external-blockcache/pom.xml
----------------------------------------------------------------------
diff --git a/hbase-external-blockcache/pom.xml b/hbase-external-blockcache/pom.xml
index 8b048c5..ce79e1a 100644
--- a/hbase-external-blockcache/pom.xml
+++ b/hbase-external-blockcache/pom.xml
@@ -98,18 +98,9 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
- <executions>
- <execution>
- <id>checkstyle</id>
- <phase>validate</phase>
- <goals>
- <goal>check</goal>
- </goals>
- <configuration>
- <failOnViolation>true</failOnViolation>
- </configuration>
- </execution>
- </executions>
+ <configuration>
+ <failOnViolation>true</failOnViolation>
+ </configuration>
</plugin>
</plugins>
<pluginManagement>
http://git-wip-us.apache.org/repos/asf/hbase/blob/0b642265/hbase-hadoop-compat/pom.xml
----------------------------------------------------------------------
diff --git a/hbase-hadoop-compat/pom.xml b/hbase-hadoop-compat/pom.xml
index 512a466..da06e77 100644
--- a/hbase-hadoop-compat/pom.xml
+++ b/hbase-hadoop-compat/pom.xml
@@ -59,18 +59,9 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
- <executions>
- <execution>
- <id>checkstyle</id>
- <phase>validate</phase>
- <goals>
- <goal>check</goal>
- </goals>
- <configuration>
- <failOnViolation>true</failOnViolation>
- </configuration>
- </execution>
- </executions>
+ <configuration>
+ <failOnViolation>true</failOnViolation>
+ </configuration>
</plugin>
</plugins>
<pluginManagement>
http://git-wip-us.apache.org/repos/asf/hbase/blob/0b642265/hbase-metrics-api/pom.xml
----------------------------------------------------------------------
diff --git a/hbase-metrics-api/pom.xml b/hbase-metrics-api/pom.xml
index f2a89af..49098de 100644
--- a/hbase-metrics-api/pom.xml
+++ b/hbase-metrics-api/pom.xml
@@ -71,18 +71,9 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
- <executions>
- <execution>
- <id>checkstyle</id>
- <phase>validate</phase>
- <goals>
- <goal>check</goal>
- </goals>
- <configuration>
- <failOnViolation>true</failOnViolation>
- </configuration>
- </execution>
- </executions>
+ <configuration>
+ <failOnViolation>true</failOnViolation>
+ </configuration>
</plugin>
</plugins>
</build>
http://git-wip-us.apache.org/repos/asf/hbase/blob/0b642265/hbase-metrics/pom.xml
----------------------------------------------------------------------
diff --git a/hbase-metrics/pom.xml b/hbase-metrics/pom.xml
index b3ba39d..869020d 100644
--- a/hbase-metrics/pom.xml
+++ b/hbase-metrics/pom.xml
@@ -71,18 +71,9 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
- <executions>
- <execution>
- <id>checkstyle</id>
- <phase>validate</phase>
- <goals>
- <goal>check</goal>
- </goals>
- <configuration>
- <failOnViolation>true</failOnViolation>
- </configuration>
- </execution>
- </executions>
+ <configuration>
+ <failOnViolation>true</failOnViolation>
+ </configuration>
</plugin>
</plugins>
</build>
http://git-wip-us.apache.org/repos/asf/hbase/blob/0b642265/hbase-protocol-shaded/pom.xml
----------------------------------------------------------------------
diff --git a/hbase-protocol-shaded/pom.xml b/hbase-protocol-shaded/pom.xml
index 1da0a32..07ae2d9 100644
--- a/hbase-protocol-shaded/pom.xml
+++ b/hbase-protocol-shaded/pom.xml
@@ -58,7 +58,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
- </plugin>
+ </plugin>
<plugin>
<!--Make it so assembly:single does nothing in here-->
<artifactId>maven-assembly-plugin</artifactId>
@@ -108,26 +108,26 @@
we run mvn install. There is probably a better way of avoiding the
double interpolation but this is it for now.
-->
- <plugin>
- <groupId>com.google.code.maven-replacer-plugin</groupId>
- <artifactId>replacer</artifactId>
- <version>1.5.3</version>
- <executions>
- <execution>
+ <plugin>
+ <groupId>com.google.code.maven-replacer-plugin</groupId>
+ <artifactId>replacer</artifactId>
+ <version>1.5.3</version>
+ <executions>
+ <execution>
<phase>generate-sources</phase>
- <goals>
+ <goals>
<goal>replace</goal>
- </goals>
- </execution>
- </executions>
- <configuration>
- <basedir>${basedir}/target/generated-sources/</basedir>
- <includes>
- <include>**/*.java</include>
- </includes>
+ </goals>
+ </execution>
+ </executions>
+ <configuration>
+ <basedir>${basedir}/target/generated-sources/</basedir>
+ <includes>
+ <include>**/*.java</include>
+ </includes>
<replacements>
<replacement>
- <token>([^\.])com.google.protobuf</token>
+ <token>([^\.])com.google.protobuf</token>
<value>$1org.apache.hbase.thirdparty.com.google.protobuf</value>
</replacement>
<replacement>
@@ -140,7 +140,7 @@
<value>$1</value>
</replacement>
</replacements>
- </configuration>
+ </configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
@@ -190,18 +190,9 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
- <executions>
- <execution>
- <id>checkstyle</id>
- <phase>validate</phase>
- <goals>
- <goal>check</goal>
- </goals>
- <configuration>
- <failOnViolation>true</failOnViolation>
- </configuration>
- </execution>
- </executions>
+ <configuration>
+ <failOnViolation>true</failOnViolation>
+ </configuration>
</plugin>
</plugins>
<pluginManagement>
http://git-wip-us.apache.org/repos/asf/hbase/blob/0b642265/hbase-protocol/pom.xml
----------------------------------------------------------------------
diff --git a/hbase-protocol/pom.xml b/hbase-protocol/pom.xml
index ec7f66a..57c789c 100644
--- a/hbase-protocol/pom.xml
+++ b/hbase-protocol/pom.xml
@@ -115,18 +115,9 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
- <executions>
- <execution>
- <id>checkstyle</id>
- <phase>validate</phase>
- <goals>
- <goal>check</goal>
- </goals>
- <configuration>
- <failOnViolation>true</failOnViolation>
- </configuration>
- </execution>
- </executions>
+ <configuration>
+ <failOnViolation>true</failOnViolation>
+ </configuration>
</plugin>
</plugins>
<pluginManagement>
http://git-wip-us.apache.org/repos/asf/hbase/blob/0b642265/hbase-replication/pom.xml
----------------------------------------------------------------------
diff --git a/hbase-replication/pom.xml b/hbase-replication/pom.xml
index f44db12..6bcbf8d 100644
--- a/hbase-replication/pom.xml
+++ b/hbase-replication/pom.xml
@@ -72,18 +72,9 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
- <executions>
- <execution>
- <id>checkstyle</id>
- <phase>validate</phase>
- <goals>
- <goal>check</goal>
- </goals>
- <configuration>
- <failOnViolation>true</failOnViolation>
- </configuration>
- </execution>
- </executions>
+ <configuration>
+ <failOnViolation>true</failOnViolation>
+ </configuration>
</plugin>
</plugins>
<pluginManagement>
http://git-wip-us.apache.org/repos/asf/hbase/blob/0b642265/hbase-rsgroup/pom.xml
----------------------------------------------------------------------
diff --git a/hbase-rsgroup/pom.xml b/hbase-rsgroup/pom.xml
index 16c198b..0cde4c7 100644
--- a/hbase-rsgroup/pom.xml
+++ b/hbase-rsgroup/pom.xml
@@ -71,18 +71,9 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
- <executions>
- <execution>
- <id>checkstyle</id>
- <phase>validate</phase>
- <goals>
- <goal>check</goal>
- </goals>
- <configuration>
- <failOnViolation>true</failOnViolation>
- </configuration>
- </execution>
- </executions>
+ <configuration>
+ <failOnViolation>true</failOnViolation>
+ </configuration>
</plugin>
</plugins>
<pluginManagement>
http://git-wip-us.apache.org/repos/asf/hbase/blob/0b642265/hbase-spark-it/pom.xml
----------------------------------------------------------------------
diff --git a/hbase-spark-it/pom.xml b/hbase-spark-it/pom.xml
index ff6581f..d1bab94 100644
--- a/hbase-spark-it/pom.xml
+++ b/hbase-spark-it/pom.xml
@@ -181,18 +181,9 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
- <executions>
- <execution>
- <id>checkstyle</id>
- <phase>validate</phase>
- <goals>
- <goal>check</goal>
- </goals>
- <configuration>
- <failOnViolation>true</failOnViolation>
- </configuration>
- </execution>
- </executions>
+ <configuration>
+ <failOnViolation>true</failOnViolation>
+ </configuration>
</plugin>
</plugins>
</build>
http://git-wip-us.apache.org/repos/asf/hbase/blob/0b642265/hbase-spark/pom.xml
----------------------------------------------------------------------
diff --git a/hbase-spark/pom.xml b/hbase-spark/pom.xml
index 4554446..a3a41fd 100644
--- a/hbase-spark/pom.xml
+++ b/hbase-spark/pom.xml
@@ -709,18 +709,9 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
- <executions>
- <execution>
- <id>checkstyle</id>
- <phase>validate</phase>
- <goals>
- <goal>check</goal>
- </goals>
- <configuration>
- <failOnViolation>true</failOnViolation>
- </configuration>
- </execution>
- </executions>
+ <configuration>
+ <failOnViolation>true</failOnViolation>
+ </configuration>
</plugin>
</plugins>
</build>
http://git-wip-us.apache.org/repos/asf/hbase/blob/0b642265/hbase-thrift/pom.xml
----------------------------------------------------------------------
diff --git a/hbase-thrift/pom.xml b/hbase-thrift/pom.xml
index 5d582de..be8023b 100644
--- a/hbase-thrift/pom.xml
+++ b/hbase-thrift/pom.xml
@@ -148,18 +148,9 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
- <executions>
- <execution>
- <id>checkstyle</id>
- <phase>validate</phase>
- <goals>
- <goal>check</goal>
- </goals>
- <configuration>
- <failOnViolation>true</failOnViolation>
- </configuration>
- </execution>
- </executions>
+ <configuration>
+ <failOnViolation>true</failOnViolation>
+ </configuration>
</plugin>
</plugins>
<pluginManagement>
http://git-wip-us.apache.org/repos/asf/hbase/blob/0b642265/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index cb1d0bf..f5cceb5 100755
--- a/pom.xml
+++ b/pom.xml
@@ -941,6 +941,9 @@
</configuration>
</plugin>
<plugin>
+ <!-- Approach followed here is roughly the same as mentioned here:
+ https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/multi-module-config.html
+ -->
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<version>${maven.checkstyle.version}</version>
@@ -1178,23 +1181,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
- <dependencies>
- <dependency>
- <groupId>org.apache.hbase</groupId>
- <artifactId>hbase-checkstyle</artifactId>
- <version>${project.version}</version>
- </dependency>
- <dependency>
- <groupId>com.puppycrawl.tools</groupId>
- <artifactId>checkstyle</artifactId>
- <version>${checkstyle.version}</version>
- </dependency>
- </dependencies>
- <configuration>
- <configLocation>hbase/checkstyle.xml</configLocation>
- <suppressionsLocation>hbase/checkstyle-suppressions.xml</suppressionsLocation>
- <includeTestSourceDirectory>true</includeTestSourceDirectory>
- </configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
@@ -1547,7 +1533,7 @@
Default is the build start timestamp. Up on jenkins pass in the jenkins build id by setting
this parameter by invoking mvn with -Dbuild.id=$BUILD_ID-->
<build.id>${maven.build.timestamp}</build.id>
- </properties>
+ </properties>
<!-- Sorted by groups of dependencies then groupId and artifactId -->
<dependencyManagement>
<dependencies>
@@ -3644,12 +3630,8 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
- <version>${maven.checkstyle.version}</version>
<configuration>
<excludes>target/**</excludes>
- <configLocation>hbase/checkstyle.xml</configLocation>
- <suppressionsLocation>hbase/checkstyle-suppressions.xml</suppressionsLocation>
- <includeTestSourceDirectory>true</includeTestSourceDirectory>
</configuration>
</plugin>