[GitHub] flink pull request #2071: [FLINK-4018][streaming-connectors] Configurable id...

[rmetzger <gi...@git.apache.org>]

Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2071#discussion_r68386857
  
    --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumerThread.java ---
    @@ -105,6 +117,8 @@ public void run() {
     
     					break;
     				} else {
    +					Thread.sleep(idleMillisBetweenFetches);
    --- End diff --
    
    I'm not sure if its a good idea to introduce this waiting time by default.
    Imagine we are consuming slowly because downstream operations are expensive. Then, we would introduce an artificial slowdown (in latency and throughput). I would suggest to:
    - Set the value by default to 0
    - Only call sleep if the idle time is > 0.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---