You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Shwetha G S (JIRA)" <ji...@apache.org> on 2012/04/23 07:50:14 UTC
[jira] [Created] (OOZIE-818) CoordChangeXCommand deletes past
coordinator actions
Shwetha G S created OOZIE-818:
---------------------------------
Summary: CoordChangeXCommand deletes past coordinator actions
Key: OOZIE-818
URL: https://issues.apache.org/jira/browse/OOZIE-818
Project: Oozie
Issue Type: Bug
Reporter: Shwetha G S
Priority: Critical
CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months...), setting pause time can delete past coord actions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-818) CoordChangeXCommand deletes past
coordinator actions
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259447#comment-13259447 ]
jiraposter@reviews.apache.org commented on OOZIE-818:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4842/
-----------------------------------------------------------
Review request for oozie.
Summary
-------
CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months), setting pause time can delete past coord actions
This addresses bug OOZIE-818.
https://issues.apache.org/jira/browse/OOZIE-818
Diffs
-----
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1329080
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1329080
Diff: https://reviews.apache.org/r/4842/diff
Testing
-------
UT - TestCoordChangeXCommand
Thanks,
shwethags
> CoordChangeXCommand deletes past coordinator actions
> ----------------------------------------------------
>
> Key: OOZIE-818
> URL: https://issues.apache.org/jira/browse/OOZIE-818
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Priority: Critical
>
> CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months...), setting pause time can delete past coord actions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-818) CoordChangeXCommand deletes past
coordinator actions
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270309#comment-13270309 ]
jiraposter@reviews.apache.org commented on OOZIE-818:
-----------------------------------------------------
bq. On 2012-05-08 06:50:32, Alejandro Abdelnur wrote:
bq. > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java, line 210
bq. > <https://reviews.apache.org/r/4842/diff/2/?file=106729#file106729line210>
bq. >
bq. > this IF should also check that the action status is WAITING or READY
bq. >
bq. > if (!time-AFTER && (action WAITING || READY))
if there is an action with nominal time >= pause time and action is in RUNNING state, we will not delete the action and return SUCCESS(which implies oozie paused the coord at the given pause time). But the actions later than pause time will be running and coord is not actually paused. This is very confusing for the user.
We should throw an exception and fail the API in this case
- shwethags
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4842/#review7673
-----------------------------------------------------------
On 2012-05-04 07:40:58, shwethags wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4842/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-04 07:40:58)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months), setting pause time can delete past coord actions
bq.
bq.
bq. This addresses bug OOZIE-818.
bq. https://issues.apache.org/jira/browse/OOZIE-818
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1329080
bq. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1329080
bq. trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1329080
bq.
bq. Diff: https://reviews.apache.org/r/4842/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. UT - TestCoordChangeXCommand
bq.
bq.
bq. Thanks,
bq.
bq. shwethags
bq.
bq.
> CoordChangeXCommand deletes past coordinator actions
> ----------------------------------------------------
>
> Key: OOZIE-818
> URL: https://issues.apache.org/jira/browse/OOZIE-818
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Shwetha G S
> Priority: Critical
>
> CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months...), setting pause time can delete past coord actions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-818) CoordChangeXCommand deletes past
coordinator actions
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268888#comment-13268888 ]
jiraposter@reviews.apache.org commented on OOZIE-818:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4842/#review7591
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/4842/#comment16796>
i have ask for this check, still not sure it is doing the correct thing, i have to verify this.
the idea is that we should not delete any action that is already running (it could be a race condition where this command and an action activation are in 2 threads.
- Alejandro
On 2012-05-04 07:40:58, shwethags wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4842/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-04 07:40:58)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months), setting pause time can delete past coord actions
bq.
bq.
bq. This addresses bug OOZIE-818.
bq. https://issues.apache.org/jira/browse/OOZIE-818
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1329080
bq. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1329080
bq. trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1329080
bq.
bq. Diff: https://reviews.apache.org/r/4842/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. UT - TestCoordChangeXCommand
bq.
bq.
bq. Thanks,
bq.
bq. shwethags
bq.
bq.
> CoordChangeXCommand deletes past coordinator actions
> ----------------------------------------------------
>
> Key: OOZIE-818
> URL: https://issues.apache.org/jira/browse/OOZIE-818
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Shwetha G S
> Priority: Critical
>
> CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months...), setting pause time can delete past coord actions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-818) CoordChangeXCommand deletes past
coordinator actions
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272203#comment-13272203 ]
jiraposter@reviews.apache.org commented on OOZIE-818:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4842/
-----------------------------------------------------------
(Updated 2012-05-10 09:09:35.854462)
Review request for oozie.
Changes
-------
Fixed 2 bugs in coord change:
1. checkEndTime() was not using coord timeunit to compute actual last action time
2. if coord change sets end time > actual last action time, but end time < coord last action time, then doneMaterialization is never called and coord state remains in RUNNING state forever
Summary
-------
CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months), setting pause time can delete past coord actions
This addresses bug OOZIE-818.
https://issues.apache.org/jira/browse/OOZIE-818
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1335944
trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1335944
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1335944
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java 1335944
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1335944
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionRemoveJPAExecutor.java 1335944
Diff: https://reviews.apache.org/r/4842/diff
Testing
-------
UT - TestCoordChangeXCommand
Thanks,
shwethags
> CoordChangeXCommand deletes past coordinator actions
> ----------------------------------------------------
>
> Key: OOZIE-818
> URL: https://issues.apache.org/jira/browse/OOZIE-818
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Shwetha G S
> Priority: Critical
>
> CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months...), setting pause time can delete past coord actions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-818) CoordChangeXCommand deletes past
coordinator actions
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276905#comment-13276905 ]
jiraposter@reviews.apache.org commented on OOZIE-818:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4842/#review7935
-----------------------------------------------------------
Ship it!
Shwetha, gr8 job, thxs for your patience! it took me a while because I wanted to ensure we would not run into a race-condition/deadlock while deleting coord actions. it is not possible because coordinator commands lock on the coordinator job id.
I'll commit this to trunk, would you please upload the final patch to JIRA and grant license rights?
- Alejandro
On 2012-05-12 11:36:34, shwethags wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4842/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-12 11:36:34)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months), setting pause time can delete past coord actions
bq.
bq.
bq. This addresses bug OOZIE-818.
bq. https://issues.apache.org/jira/browse/OOZIE-818
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1337043
bq. trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1337043
bq. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1337043
bq. trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java 1337043
bq. trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1337043
bq. trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionRemoveJPAExecutor.java 1337043
bq.
bq. Diff: https://reviews.apache.org/r/4842/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. UT - TestCoordChangeXCommand
bq.
bq.
bq. Thanks,
bq.
bq. shwethags
bq.
bq.
> CoordChangeXCommand deletes past coordinator actions
> ----------------------------------------------------
>
> Key: OOZIE-818
> URL: https://issues.apache.org/jira/browse/OOZIE-818
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Shwetha G S
> Priority: Critical
> Fix For: trunk
>
>
> CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months...), setting pause time can delete past coord actions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-818) CoordChangeXCommand deletes past
coordinator actions
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270539#comment-13270539 ]
jiraposter@reviews.apache.org commented on OOZIE-818:
-----------------------------------------------------
bq. On 2012-05-08 06:50:32, Alejandro Abdelnur wrote:
bq. > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java, line 242
bq. > <https://reviews.apache.org/r/4842/diff/2/?file=106729#file106729line242>
bq. >
bq. > we should remove this IF/exception here. see comment above where the check would go. we don't want to throw an exception we just want to make sure we don't delete and action that is already in progress.
Shwetha, good point I was missing that. This means the change has to fail, would you mind reworking your patch to throw the exception in a check following line 210 outside of the delete? It seems it belongs there more than within the delete method.
THX
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4842/#review7673
-----------------------------------------------------------
On 2012-05-04 07:40:58, shwethags wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4842/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-04 07:40:58)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months), setting pause time can delete past coord actions
bq.
bq.
bq. This addresses bug OOZIE-818.
bq. https://issues.apache.org/jira/browse/OOZIE-818
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1329080
bq. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1329080
bq. trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1329080
bq.
bq. Diff: https://reviews.apache.org/r/4842/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. UT - TestCoordChangeXCommand
bq.
bq.
bq. Thanks,
bq.
bq. shwethags
bq.
bq.
> CoordChangeXCommand deletes past coordinator actions
> ----------------------------------------------------
>
> Key: OOZIE-818
> URL: https://issues.apache.org/jira/browse/OOZIE-818
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Shwetha G S
> Priority: Critical
>
> CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months...), setting pause time can delete past coord actions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-818) CoordChangeXCommand deletes past
coordinator actions
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271208#comment-13271208 ]
jiraposter@reviews.apache.org commented on OOZIE-818:
-----------------------------------------------------
bq. On 2012-05-08 06:50:32, Alejandro Abdelnur wrote:
bq. > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java, line 242
bq. > <https://reviews.apache.org/r/4842/diff/2/?file=106729#file106729line242>
bq. >
bq. > we should remove this IF/exception here. see comment above where the check would go. we don't want to throw an exception we just want to make sure we don't delete and action that is already in progress.
bq.
bq. Alejandro Abdelnur wrote:
bq. Shwetha, good point I was missing that. This means the change has to fail, would you mind reworking your patch to throw the exception in a check following line 210 outside of the delete? It seems it belongs there more than within the delete method.
bq.
bq. THX
I have updated the diff by moving action status check to processLookaheadActions. But even this will not guard against race condition. Consider this:
thr1- check action status
thr2 - make action running
thr1 - delete action
and we will end up deleting running action!
This check should go in the sql
- shwethags
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4842/#review7673
-----------------------------------------------------------
On 2012-05-09 07:59:18, shwethags wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4842/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-09 07:59:18)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months), setting pause time can delete past coord actions
bq.
bq.
bq. This addresses bug OOZIE-818.
bq. https://issues.apache.org/jira/browse/OOZIE-818
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1335944
bq. trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1335944
bq. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1335944
bq. trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionByActionNumberJPAExecutor.java 1335944
bq. trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1335944
bq. trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionByActionNumberJPAExecutor.java 1335944
bq.
bq. Diff: https://reviews.apache.org/r/4842/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. UT - TestCoordChangeXCommand
bq.
bq.
bq. Thanks,
bq.
bq. shwethags
bq.
bq.
> CoordChangeXCommand deletes past coordinator actions
> ----------------------------------------------------
>
> Key: OOZIE-818
> URL: https://issues.apache.org/jira/browse/OOZIE-818
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Shwetha G S
> Priority: Critical
>
> CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months...), setting pause time can delete past coord actions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-818) CoordChangeXCommand deletes past
coordinator actions
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273942#comment-13273942 ]
jiraposter@reviews.apache.org commented on OOZIE-818:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4842/
-----------------------------------------------------------
(Updated 2012-05-12 11:36:34.408443)
Review request for oozie.
Changes
-------
fixed testcase failure - Reverted query in CoordinatorActionBean
Summary
-------
CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months), setting pause time can delete past coord actions
This addresses bug OOZIE-818.
https://issues.apache.org/jira/browse/OOZIE-818
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1337043
trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1337043
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1337043
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java 1337043
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1337043
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionRemoveJPAExecutor.java 1337043
Diff: https://reviews.apache.org/r/4842/diff
Testing
-------
UT - TestCoordChangeXCommand
Thanks,
shwethags
> CoordChangeXCommand deletes past coordinator actions
> ----------------------------------------------------
>
> Key: OOZIE-818
> URL: https://issues.apache.org/jira/browse/OOZIE-818
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Shwetha G S
> Priority: Critical
>
> CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months...), setting pause time can delete past coord actions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-818) CoordChangeXCommand deletes past
coordinator actions
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268852#comment-13268852 ]
jiraposter@reviews.apache.org commented on OOZIE-818:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4842/#review7589
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/4842/#comment16792>
can you please add {} in this if.
although if has one statement , we use {} as standard.
secondly, what is the reason of this extra check?
- Mohammad
On 2012-05-04 07:40:58, shwethags wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4842/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-04 07:40:58)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months), setting pause time can delete past coord actions
bq.
bq.
bq. This addresses bug OOZIE-818.
bq. https://issues.apache.org/jira/browse/OOZIE-818
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1329080
bq. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1329080
bq. trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1329080
bq.
bq. Diff: https://reviews.apache.org/r/4842/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. UT - TestCoordChangeXCommand
bq.
bq.
bq. Thanks,
bq.
bq. shwethags
bq.
bq.
> CoordChangeXCommand deletes past coordinator actions
> ----------------------------------------------------
>
> Key: OOZIE-818
> URL: https://issues.apache.org/jira/browse/OOZIE-818
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Shwetha G S
> Priority: Critical
>
> CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months...), setting pause time can delete past coord actions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-818) CoordChangeXCommand deletes past
coordinator actions
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270268#comment-13270268 ]
jiraposter@reviews.apache.org commented on OOZIE-818:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4842/#review7673
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/4842/#comment16899>
this IF should also check that the action status is WAITING or READY
if (!time-AFTER && (action WAITING || READY))
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/4842/#comment16901>
we should remove this IF/exception here. see comment above where the check would go. we don't want to throw an exception we just want to make sure we don't delete and action that is already in progress.
- Alejandro
On 2012-05-04 07:40:58, shwethags wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4842/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-04 07:40:58)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months), setting pause time can delete past coord actions
bq.
bq.
bq. This addresses bug OOZIE-818.
bq. https://issues.apache.org/jira/browse/OOZIE-818
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1329080
bq. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1329080
bq. trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1329080
bq.
bq. Diff: https://reviews.apache.org/r/4842/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. UT - TestCoordChangeXCommand
bq.
bq.
bq. Thanks,
bq.
bq. shwethags
bq.
bq.
> CoordChangeXCommand deletes past coordinator actions
> ----------------------------------------------------
>
> Key: OOZIE-818
> URL: https://issues.apache.org/jira/browse/OOZIE-818
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Shwetha G S
> Priority: Critical
>
> CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months...), setting pause time can delete past coord actions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-818) CoordChangeXCommand deletes past
coordinator actions
Posted by "Shwetha G S (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273943#comment-13273943 ]
Shwetha G S commented on OOZIE-818:
-----------------------------------
Fixes 3 issues in CoordChangeXCommand:
1. timeunit was not used while calculating previous coord action time in processLookaheadActions. This caused past actions to be deleted
2. timeunit was not used while calculating last action time in checkEndTime. This caused wrong validation
3. doneMaterialization was never set after coord change. When endTime was changed such that actual last action time < endTime <= coordJob.lastActionTime, coord never moves to terminal status(always remains in RUNNING state)
For the patch committed in trunk with this JIRA ID OOZIE-818 (also available under the same JIRA ID in Apache ReviewBoard system), I grant license to ASF for inclusion in ASF works (as per the Apache License ยง5)
> CoordChangeXCommand deletes past coordinator actions
> ----------------------------------------------------
>
> Key: OOZIE-818
> URL: https://issues.apache.org/jira/browse/OOZIE-818
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Shwetha G S
> Priority: Critical
>
> CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months...), setting pause time can delete past coord actions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-818) CoordChangeXCommand deletes past
coordinator actions
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272474#comment-13272474 ]
jiraposter@reviews.apache.org commented on OOZIE-818:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4842/#review7775
-----------------------------------------------------------
I like the approach, minor corrections through out the patch.
I've applied the patch and run into 2 issues:
* NIT: patch is done at trunk/core level, it should be done a trunk/ level
* Test errors:
Results :
Failed tests: testCoordActionDelete(org.apache.oozie.command.coord.TestCoordChangeXCommand): Error code should be E1022
Tests in error:
testCoordChangePauseTime(org.apache.oozie.command.coord.TestCoordChangeXCommand): E0603: SQL error in operation [java.lang.ClassCastException: [Ljava.lang.Object; cannot be cast to java.lang.String], {1}
Tests run: 4, Failures: 1, Errors: 1, Skipped: 0
Once this is taken care it is should ready for +1
Thanks for all the work.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/4842/#comment17079>
getLastActionTime() seems abetter name, 'actual' may give some connotation to when the action is running and actually this is the nominal time of the action.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/4842/#comment17077>
trailing spaces
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/4842/#comment17078>
trailing spaces
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java
<https://reviews.apache.org/r/4842/#comment17080>
trailing spaces
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java
<https://reviews.apache.org/r/4842/#comment17081>
trailing spaces
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionRemoveJPAExecutor.java
<https://reviews.apache.org/r/4842/#comment17082>
trailing spaces
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionRemoveJPAExecutor.java
<https://reviews.apache.org/r/4842/#comment17083>
trailing spaces
- Alejandro
On 2012-05-10 09:09:35, shwethags wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4842/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-10 09:09:35)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months), setting pause time can delete past coord actions
bq.
bq.
bq. This addresses bug OOZIE-818.
bq. https://issues.apache.org/jira/browse/OOZIE-818
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1335944
bq. trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1335944
bq. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1335944
bq. trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java 1335944
bq. trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1335944
bq. trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionRemoveJPAExecutor.java 1335944
bq.
bq. Diff: https://reviews.apache.org/r/4842/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. UT - TestCoordChangeXCommand
bq.
bq.
bq. Thanks,
bq.
bq. shwethags
bq.
bq.
> CoordChangeXCommand deletes past coordinator actions
> ----------------------------------------------------
>
> Key: OOZIE-818
> URL: https://issues.apache.org/jira/browse/OOZIE-818
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Shwetha G S
> Priority: Critical
>
> CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months...), setting pause time can delete past coord actions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-818) CoordChangeXCommand deletes past
coordinator actions
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271902#comment-13271902 ]
jiraposter@reviews.apache.org commented on OOZIE-818:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4842/#review7747
-----------------------------------------------------------
regarding the race condition scenario you mentioned, you are correct.
I wonder what would be the correct way of doing it?
* collect all action IDs to delete, obtain (oozie lock service) lock for them, check status of all actions, then delete them, if lock cannot be acquired or status does not match anymore, rollback. (But we should do this as part of another JIRA)
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/4842/#comment17049>
do we really need the loadAction/deleteAction methods or can we do this inline above?
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionByActionNumberJPAExecutor.java
<https://reviews.apache.org/r/4842/#comment17050>
This executor is missleading, it is returning a CoordinatorAction which only has it status set.
Why not make it return the action status instead? (i know, this was not fully done in the JIRA, but his is nasty)
- Alejandro
On 2012-05-09 07:59:18, shwethags wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4842/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-09 07:59:18)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months), setting pause time can delete past coord actions
bq.
bq.
bq. This addresses bug OOZIE-818.
bq. https://issues.apache.org/jira/browse/OOZIE-818
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1335944
bq. trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1335944
bq. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1335944
bq. trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionByActionNumberJPAExecutor.java 1335944
bq. trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1335944
bq. trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionByActionNumberJPAExecutor.java 1335944
bq.
bq. Diff: https://reviews.apache.org/r/4842/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. UT - TestCoordChangeXCommand
bq.
bq.
bq. Thanks,
bq.
bq. shwethags
bq.
bq.
> CoordChangeXCommand deletes past coordinator actions
> ----------------------------------------------------
>
> Key: OOZIE-818
> URL: https://issues.apache.org/jira/browse/OOZIE-818
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Shwetha G S
> Priority: Critical
>
> CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months...), setting pause time can delete past coord actions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-818) CoordChangeXCommand deletes past
coordinator actions
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273427#comment-13273427 ]
jiraposter@reviews.apache.org commented on OOZIE-818:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4842/#review7804
-----------------------------------------------------------
Shwetha,
I'm getting the following failure when running the testcases:
Tests in error:
testCoordChangePauseTime(org.apache.oozie.command.coord.TestCoordChangeXCommand): E0603: SQL error in operation [java.lang.ClassCastException: [Ljava.lang.Object; cannot be cast to java.lang.String], {1}
- Alejandro
On 2012-05-11 07:34:47, shwethags wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4842/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-11 07:34:47)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months), setting pause time can delete past coord actions
bq.
bq.
bq. This addresses bug OOZIE-818.
bq. https://issues.apache.org/jira/browse/OOZIE-818
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1337043
bq. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1337043
bq. trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java 1337043
bq. trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1337043
bq. trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionRemoveJPAExecutor.java 1337043
bq. trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1337043
bq.
bq. Diff: https://reviews.apache.org/r/4842/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. UT - TestCoordChangeXCommand
bq.
bq.
bq. Thanks,
bq.
bq. shwethags
bq.
bq.
> CoordChangeXCommand deletes past coordinator actions
> ----------------------------------------------------
>
> Key: OOZIE-818
> URL: https://issues.apache.org/jira/browse/OOZIE-818
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Shwetha G S
> Priority: Critical
>
> CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months...), setting pause time can delete past coord actions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OOZIE-818) CoordChangeXCommand deletes past
coordinator actions
Posted by "Shwetha G S (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shwetha G S reassigned OOZIE-818:
---------------------------------
Assignee: Shwetha G S
> CoordChangeXCommand deletes past coordinator actions
> ----------------------------------------------------
>
> Key: OOZIE-818
> URL: https://issues.apache.org/jira/browse/OOZIE-818
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Shwetha G S
> Priority: Critical
>
> CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months...), setting pause time can delete past coord actions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-818) CoordChangeXCommand deletes past
coordinator actions
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273103#comment-13273103 ]
jiraposter@reviews.apache.org commented on OOZIE-818:
-----------------------------------------------------
bq. On 2012-05-10 16:44:25, Alejandro Abdelnur wrote:
bq. > I like the approach, minor corrections through out the patch.
bq. >
bq. > I've applied the patch and run into 2 issues:
bq. >
bq. > * NIT: patch is done at trunk/core level, it should be done a trunk/ level
bq. >
bq. > * Test errors:
bq. >
bq. >
bq. > Results :
bq. >
bq. > Failed tests: testCoordActionDelete(org.apache.oozie.command.coord.TestCoordChangeXCommand): Error code should be E1022
bq. >
bq. > Tests in error:
bq. > testCoordChangePauseTime(org.apache.oozie.command.coord.TestCoordChangeXCommand): E0603: SQL error in operation [java.lang.ClassCastException: [Ljava.lang.Object; cannot be cast to java.lang.String], {1}
bq. >
bq. > Tests run: 4, Failures: 1, Errors: 1, Skipped: 0
bq. >
bq. >
bq. > Once this is taken care it is should ready for +1
bq. >
bq. > Thanks for all the work.
Test error was because of some typo. Fixed
Removed all trailing spaces
bq. On 2012-05-10 16:44:25, Alejandro Abdelnur wrote:
bq. > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java, line 151
bq. > <https://reviews.apache.org/r/4842/diff/5/?file=108315#file108315line151>
bq. >
bq. > getLastActionTime() seems abetter name, 'actual' may give some connotation to when the action is running and actually this is the nominal time of the action.
Changed. The reason i made it getActualLastActionTime is because coordJob.getLastActionTime() actually points to one instance after the last action time. Its confusing!
- shwethags
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4842/#review7775
-----------------------------------------------------------
On 2012-05-10 09:09:35, shwethags wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4842/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-10 09:09:35)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months), setting pause time can delete past coord actions
bq.
bq.
bq. This addresses bug OOZIE-818.
bq. https://issues.apache.org/jira/browse/OOZIE-818
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1335944
bq. trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1335944
bq. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1335944
bq. trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java 1335944
bq. trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1335944
bq. trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionRemoveJPAExecutor.java 1335944
bq.
bq. Diff: https://reviews.apache.org/r/4842/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. UT - TestCoordChangeXCommand
bq.
bq.
bq. Thanks,
bq.
bq. shwethags
bq.
bq.
> CoordChangeXCommand deletes past coordinator actions
> ----------------------------------------------------
>
> Key: OOZIE-818
> URL: https://issues.apache.org/jira/browse/OOZIE-818
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Shwetha G S
> Priority: Critical
>
> CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months...), setting pause time can delete past coord actions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-818) CoordChangeXCommand deletes past
coordinator actions
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273940#comment-13273940 ]
jiraposter@reviews.apache.org commented on OOZIE-818:
-----------------------------------------------------
bq. On 2012-05-11 17:11:21, Alejandro Abdelnur wrote:
bq. > Shwetha,
bq. >
bq. > I'm getting the following failure when running the testcases:
bq. >
bq. >
bq. > Tests in error:
bq. > testCoordChangePauseTime(org.apache.oozie.command.coord.TestCoordChangeXCommand): E0603: SQL error in operation [java.lang.ClassCastException: [Ljava.lang.Object; cannot be cast to java.lang.String], {1}
bq. >
bq. >
Sorry, remnants of previous change! I thought I ran the testcases.. Fixed now
- shwethags
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4842/#review7804
-----------------------------------------------------------
On 2012-05-11 07:34:47, shwethags wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4842/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-11 07:34:47)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months), setting pause time can delete past coord actions
bq.
bq.
bq. This addresses bug OOZIE-818.
bq. https://issues.apache.org/jira/browse/OOZIE-818
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1337043
bq. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1337043
bq. trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java 1337043
bq. trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1337043
bq. trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionRemoveJPAExecutor.java 1337043
bq. trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1337043
bq.
bq. Diff: https://reviews.apache.org/r/4842/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. UT - TestCoordChangeXCommand
bq.
bq.
bq. Thanks,
bq.
bq. shwethags
bq.
bq.
> CoordChangeXCommand deletes past coordinator actions
> ----------------------------------------------------
>
> Key: OOZIE-818
> URL: https://issues.apache.org/jira/browse/OOZIE-818
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Shwetha G S
> Priority: Critical
>
> CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months...), setting pause time can delete past coord actions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-818) CoordChangeXCommand deletes past
coordinator actions
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267013#comment-13267013 ]
jiraposter@reviews.apache.org commented on OOZIE-818:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4842/#review7491
-----------------------------------------------------------
other than my prev coments, patch looks good
- Alejandro
On 2012-04-23 08:07:07, shwethags wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4842/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-23 08:07:07)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months), setting pause time can delete past coord actions
bq.
bq.
bq. This addresses bug OOZIE-818.
bq. https://issues.apache.org/jira/browse/OOZIE-818
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1329080
bq. trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1329080
bq.
bq. Diff: https://reviews.apache.org/r/4842/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. UT - TestCoordChangeXCommand
bq.
bq.
bq. Thanks,
bq.
bq. shwethags
bq.
bq.
> CoordChangeXCommand deletes past coordinator actions
> ----------------------------------------------------
>
> Key: OOZIE-818
> URL: https://issues.apache.org/jira/browse/OOZIE-818
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Shwetha G S
> Priority: Critical
>
> CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months...), setting pause time can delete past coord actions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OOZIE-818) CoordChangeXCommand deletes past
coordinator actions
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur resolved OOZIE-818.
--------------------------------------
Resolution: Fixed
Fix Version/s: trunk
Thanks Shwetha. Committed to trunk
> CoordChangeXCommand deletes past coordinator actions
> ----------------------------------------------------
>
> Key: OOZIE-818
> URL: https://issues.apache.org/jira/browse/OOZIE-818
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Shwetha G S
> Priority: Critical
> Fix For: trunk
>
>
> CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months...), setting pause time can delete past coord actions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-818) CoordChangeXCommand deletes past
coordinator actions
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273104#comment-13273104 ]
jiraposter@reviews.apache.org commented on OOZIE-818:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4842/
-----------------------------------------------------------
(Updated 2012-05-11 07:34:47.689638)
Review request for oozie.
Changes
-------
Incorporated review comments. Diff from trunk.
Summary
-------
CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months), setting pause time can delete past coord actions
This addresses bug OOZIE-818.
https://issues.apache.org/jira/browse/OOZIE-818
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1337043
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1337043
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java 1337043
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1337043
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionRemoveJPAExecutor.java 1337043
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1337043
Diff: https://reviews.apache.org/r/4842/diff
Testing
-------
UT - TestCoordChangeXCommand
Thanks,
shwethags
> CoordChangeXCommand deletes past coordinator actions
> ----------------------------------------------------
>
> Key: OOZIE-818
> URL: https://issues.apache.org/jira/browse/OOZIE-818
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Shwetha G S
> Priority: Critical
>
> CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months...), setting pause time can delete past coord actions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-818) CoordChangeXCommand deletes past
coordinator actions
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272153#comment-13272153 ]
jiraposter@reviews.apache.org commented on OOZIE-818:
-----------------------------------------------------
bq. On 2012-05-09 22:49:25, Alejandro Abdelnur wrote:
bq. > regarding the race condition scenario you mentioned, you are correct.
bq. >
bq. > I wonder what would be the correct way of doing it?
bq. >
bq. > * collect all action IDs to delete, obtain (oozie lock service) lock for them, check status of all actions, then delete them, if lock cannot be acquired or status does not match anymore, rollback. (But we should do this as part of another JIRA)
bq. >
I have added a patch where the status check is done as part of delete sql. This will work correctly for CoordChangeXCommand. But to solve the whole race condition, even CoordActionReadyXCommand also has to be fixed.
As of now, CoordActionReadyXCommand loads list of ready actions and then iterates through the actions calling CoordActionStartXCommand and update status to SUBMITTED. Instead change CoordActionReadyXCommand to first update status of all REDAY actions to SUBMITTED in one sql(update status = SUBMITTED where jobid = <coordid> and status = READY with limit) and then iterate through SUBMITTED actions and call CoordActionStartXCommand. Fixing CoordActionReadyXCommand can be taken up in another jira.
Can we close this jira for just CoordChangeXCommand?
bq. On 2012-05-09 22:49:25, Alejandro Abdelnur wrote:
bq. > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java, line 244
bq. > <https://reviews.apache.org/r/4842/diff/3/?file=108016#file108016line244>
bq. >
bq. > do we really need the loadAction/deleteAction methods or can we do this inline above?
Not really required. But if I make it inline, processLookaheadActions looks bad
- shwethags
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4842/#review7747
-----------------------------------------------------------
On 2012-05-10 06:41:33, shwethags wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4842/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-10 06:41:33)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months), setting pause time can delete past coord actions
bq.
bq.
bq. This addresses bug OOZIE-818.
bq. https://issues.apache.org/jira/browse/OOZIE-818
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1335944
bq. trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1335944
bq. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1335944
bq. trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java 1335944
bq. trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1335944
bq. trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionRemoveJPAExecutor.java 1335944
bq.
bq. Diff: https://reviews.apache.org/r/4842/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. UT - TestCoordChangeXCommand
bq.
bq.
bq. Thanks,
bq.
bq. shwethags
bq.
bq.
> CoordChangeXCommand deletes past coordinator actions
> ----------------------------------------------------
>
> Key: OOZIE-818
> URL: https://issues.apache.org/jira/browse/OOZIE-818
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Shwetha G S
> Priority: Critical
>
> CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months...), setting pause time can delete past coord actions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-818) CoordChangeXCommand deletes past
coordinator actions
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268192#comment-13268192 ]
jiraposter@reviews.apache.org commented on OOZIE-818:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4842/
-----------------------------------------------------------
(Updated 2012-05-04 07:40:58.398433)
Review request for oozie.
Changes
-------
Added status check before coord action delete
Summary
-------
CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months), setting pause time can delete past coord actions
This addresses bug OOZIE-818.
https://issues.apache.org/jira/browse/OOZIE-818
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1329080
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1329080
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1329080
Diff: https://reviews.apache.org/r/4842/diff
Testing
-------
UT - TestCoordChangeXCommand
Thanks,
shwethags
> CoordChangeXCommand deletes past coordinator actions
> ----------------------------------------------------
>
> Key: OOZIE-818
> URL: https://issues.apache.org/jira/browse/OOZIE-818
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Shwetha G S
> Priority: Critical
>
> CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months...), setting pause time can delete past coord actions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-818) CoordChangeXCommand deletes past
coordinator actions
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271207#comment-13271207 ]
jiraposter@reviews.apache.org commented on OOZIE-818:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4842/
-----------------------------------------------------------
(Updated 2012-05-09 07:59:18.957939)
Review request for oozie.
Changes
-------
Moved coord action status check to processLookaheadActions
Turns out CoordJobGetActionByActionNumberJPAExecutor doesn't return action status anymore. So, added it back
Summary
-------
CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months), setting pause time can delete past coord actions
This addresses bug OOZIE-818.
https://issues.apache.org/jira/browse/OOZIE-818
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1335944
trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1335944
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1335944
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionByActionNumberJPAExecutor.java 1335944
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1335944
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionByActionNumberJPAExecutor.java 1335944
Diff: https://reviews.apache.org/r/4842/diff
Testing
-------
UT - TestCoordChangeXCommand
Thanks,
shwethags
> CoordChangeXCommand deletes past coordinator actions
> ----------------------------------------------------
>
> Key: OOZIE-818
> URL: https://issues.apache.org/jira/browse/OOZIE-818
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Shwetha G S
> Priority: Critical
>
> CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months...), setting pause time can delete past coord actions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-818) CoordChangeXCommand deletes past
coordinator actions
Posted by "Shwetha G S (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shwetha G S updated OOZIE-818:
------------------------------
Attachment: OOZIE-818.patch
Final patch
> CoordChangeXCommand deletes past coordinator actions
> ----------------------------------------------------
>
> Key: OOZIE-818
> URL: https://issues.apache.org/jira/browse/OOZIE-818
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Shwetha G S
> Priority: Critical
> Fix For: trunk
>
> Attachments: OOZIE-818.patch
>
>
> CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months...), setting pause time can delete past coord actions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-818) CoordChangeXCommand deletes past
coordinator actions
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272136#comment-13272136 ]
jiraposter@reviews.apache.org commented on OOZIE-818:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4842/
-----------------------------------------------------------
(Updated 2012-05-10 06:41:33.964025)
Review request for oozie.
Changes
-------
Moved status check as part of delete sql
Summary
-------
CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months), setting pause time can delete past coord actions
This addresses bug OOZIE-818.
https://issues.apache.org/jira/browse/OOZIE-818
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1335944
trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1335944
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1335944
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java 1335944
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1335944
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionRemoveJPAExecutor.java 1335944
Diff: https://reviews.apache.org/r/4842/diff
Testing
-------
UT - TestCoordChangeXCommand
Thanks,
shwethags
> CoordChangeXCommand deletes past coordinator actions
> ----------------------------------------------------
>
> Key: OOZIE-818
> URL: https://issues.apache.org/jira/browse/OOZIE-818
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Shwetha G S
> Priority: Critical
>
> CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months...), setting pause time can delete past coord actions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-818) CoordChangeXCommand deletes past
coordinator actions
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267012#comment-13267012 ]
jiraposter@reviews.apache.org commented on OOZIE-818:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4842/#review7490
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/4842/#comment16585>
remove trailing tab/spaces
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/4842/#comment16586>
we should not delete actions if it is already running, that one should stay. while extremely unlikely, we should do that check
- Alejandro
On 2012-04-23 08:07:07, shwethags wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4842/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-23 08:07:07)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months), setting pause time can delete past coord actions
bq.
bq.
bq. This addresses bug OOZIE-818.
bq. https://issues.apache.org/jira/browse/OOZIE-818
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 1329080
bq. trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1329080
bq.
bq. Diff: https://reviews.apache.org/r/4842/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. UT - TestCoordChangeXCommand
bq.
bq.
bq. Thanks,
bq.
bq. shwethags
bq.
bq.
> CoordChangeXCommand deletes past coordinator actions
> ----------------------------------------------------
>
> Key: OOZIE-818
> URL: https://issues.apache.org/jira/browse/OOZIE-818
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Shwetha G S
> Priority: Critical
>
> CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit while calculating the action times. So, if the frequency is non-minutes(hours, days, months...), setting pause time can delete past coord actions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira