You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/03/11 18:15:58 UTC

[GitHub] [kylin] hit-lacus opened a new pull request #1161: KYLIN-4425 Refactor diagnosis module

hit-lacus opened a new pull request #1161: KYLIN-4425 Refactor diagnosis module
URL: https://github.com/apache/kylin/pull/1161
 
 
   ## Proposed changes
   
   Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
   
   ## Types of changes
   
   What types of changes does your code introduce to Kylin?
   _Put an `x` in the boxes that apply_
   
   - [ ] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
   
   - [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
   - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
   - [ ] Compiling and unit tests pass locally with my changes
   - [ ] I have added tests that prove my fix is effective or that my feature works
   - [ ] I have added necessary documentation (if appropriate)
   - [ ] Any dependent changes have been merged
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] hit-lacus edited a comment on issue #1161: KYLIN-4425 Refactor diagnosis module

Posted by GitBox <gi...@apache.org>.
hit-lacus edited a comment on issue #1161: KYLIN-4425 Refactor diagnosis module
URL: https://github.com/apache/kylin/pull/1161#issuecomment-598151823
 
 
   Manual test passed in 
   - [x] CDH 5.6
   - [x] HDP 2.4
   - [x] HDP 3.0

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] hit-lacus edited a comment on issue #1161: KYLIN-4425 Refactor diagnosis module

Posted by GitBox <gi...@apache.org>.
hit-lacus edited a comment on issue #1161: KYLIN-4425 Refactor diagnosis module
URL: https://github.com/apache/kylin/pull/1161#issuecomment-598151823
 
 
   Manual test passed in 
   - [x] CDH 5.6
   - [x] HDP 2.4
   - [ ] HDP 3.0

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] coveralls commented on issue #1161: KYLIN-4425 Refactor diagnosis module

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1161: KYLIN-4425 Refactor diagnosis module
URL: https://github.com/apache/kylin/pull/1161#issuecomment-598098825
 
 
   ## Pull Request Test Coverage Report for [Build 5758](https://coveralls.io/builds/29298044)
   
   * **33** of **303**   **(10.89%)**  changed or added relevant lines in **14** files are covered.
   * **4** unchanged lines in **2** files lost coverage.
   * Overall coverage decreased (**-0.04%**) to **27.474%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java](https://coveralls.io/builds/29298044/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java#L1551) | 0 | 1 | 0.0%
   | [server-base/src/main/java/org/apache/kylin/rest/service/DiagnosisService.java](https://coveralls.io/builds/29298044/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FDiagnosisService.java#L101) | 0 | 2 | 0.0%
   | [tool/src/main/java/org/apache/kylin/tool/extractor/KylinLogExtractor.java](https://coveralls.io/builds/29298044/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2Fextractor%2FKylinLogExtractor.java#L85) | 0 | 2 | 0.0%
   | [tool/src/main/java/org/apache/kylin/tool/extractor/CubeMetaExtractor.java](https://coveralls.io/builds/29298044/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2Fextractor%2FCubeMetaExtractor.java#L303) | 25 | 29 | 86.21%
   | [tool/src/main/java/org/apache/kylin/tool/extractor/MrJobInfoExtractor.java](https://coveralls.io/builds/29298044/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2Fextractor%2FMrJobInfoExtractor.java#L88) | 0 | 4 | 0.0%
   | [tool/src/main/java/org/apache/kylin/tool/extractor/ClientEnvExtractor.java](https://coveralls.io/builds/29298044/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2Fextractor%2FClientEnvExtractor.java#L79) | 6 | 13 | 46.15%
   | [tool/src/main/java/org/apache/kylin/tool/extractor/HadoopConfExtractor.java](https://coveralls.io/builds/29298044/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2Fextractor%2FHadoopConfExtractor.java#L43) | 0 | 8 | 0.0%
   | [tool/src/main/java/org/apache/kylin/tool/extractor/JStackExtractor.java](https://coveralls.io/builds/29298044/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2Fextractor%2FJStackExtractor.java#L37) | 0 | 15 | 0.0%
   | [tool/src/main/java/org/apache/kylin/tool/JobDiagnosisInfoCLI.java](https://coveralls.io/builds/29298044/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2FJobDiagnosisInfoCLI.java#L134) | 0 | 20 | 0.0%
   | [tool/src/main/java/org/apache/kylin/tool/DiagnosisInfoCLI.java](https://coveralls.io/builds/29298044/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2FDiagnosisInfoCLI.java#L153) | 0 | 22 | 0.0%
   <!-- | **Total:** | **33** | **303** | **10.89%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [tool/src/main/java/org/apache/kylin/tool/DiagnosisInfoCLI.java](https://coveralls.io/builds/29298044/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2FDiagnosisInfoCLI.java#L290) | 1 | 0% |
   | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/29298044/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 3 | 78.42% |
   <!-- | **Total:** | **4** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29298044/badge)](https://coveralls.io/builds/29298044) |
   | :-- | --: |
   | Change from base [Build 5753](https://coveralls.io/builds/29295116): |  -0.04% |
   | Covered Lines: | 24312 |
   | Relevant Lines: | 88490 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] hit-lacus commented on issue #1161: KYLIN-4425 Refactor diagnosis module

Posted by GitBox <gi...@apache.org>.
hit-lacus commented on issue #1161: KYLIN-4425 Refactor diagnosis module
URL: https://github.com/apache/kylin/pull/1161#issuecomment-598047853
 
 
   Test and doc will updated soon.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] hit-lacus edited a comment on issue #1161: KYLIN-4425 Refactor diagnosis module

Posted by GitBox <gi...@apache.org>.
hit-lacus edited a comment on issue #1161: KYLIN-4425 Refactor diagnosis module
URL: https://github.com/apache/kylin/pull/1161#issuecomment-598151823
 
 
   Manual test passed in 
   - [x] CDH 5.6
   - [ ] HDP 2.4
   - [ ] HDP 3.0

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] hit-lacus edited a comment on issue #1161: KYLIN-4425 Refactor diagnosis module

Posted by GitBox <gi...@apache.org>.
hit-lacus edited a comment on issue #1161: KYLIN-4425 Refactor diagnosis module
URL: https://github.com/apache/kylin/pull/1161#issuecomment-598151823
 
 
   Manual test passed in 
   - [x] CDH 5.6
   - [ ] CDH 6.1
   - [ ] HDP 2.4
   - [ ] HDP 3.0

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io commented on issue #1161: KYLIN-4425 Refactor diagnosis module

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1161: KYLIN-4425 Refactor diagnosis module
URL: https://github.com/apache/kylin/pull/1161#issuecomment-598029527
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/1161?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@16924ef`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `10.56%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1161/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/1161?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff            @@
   ##             master   #1161   +/-   ##
   ========================================
     Coverage          ?     25%           
     Complexity        ?    6249           
   ========================================
     Files             ?    1449           
     Lines             ?   88495           
     Branches          ?   12375           
   ========================================
     Hits              ?   22130           
     Misses            ?   64191           
     Partials          ?    2174
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1161?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...in/java/org/apache/kylin/common/util/ToolUtil.java](https://codecov.io/gh/apache/kylin/pull/1161/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL1Rvb2xVdGlsLmphdmE=) | `10.63% <ø> (ø)` | `2 <0> (?)` | |
   | [.../java/org/apache/kylin/common/util/HadoopUtil.java](https://codecov.io/gh/apache/kylin/pull/1161/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0hhZG9vcFV0aWwuamF2YQ==) | `14.56% <ø> (ø)` | `10 <0> (?)` | |
   | [...org/apache/kylin/tool/extractor/HiveConfigCLI.java](https://codecov.io/gh/apache/kylin/pull/1161/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9leHRyYWN0b3IvSGl2ZUNvbmZpZ0NMSS5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | |
   | [...che/kylin/tool/extractor/JobInstanceExtractor.java](https://codecov.io/gh/apache/kylin/pull/1161/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9leHRyYWN0b3IvSm9iSW5zdGFuY2VFeHRyYWN0b3IuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (?)` | |
   | [...n/java/org/apache/kylin/tool/DiagnosisInfoCLI.java](https://codecov.io/gh/apache/kylin/pull/1161/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9EaWFnbm9zaXNJbmZvQ0xJLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...pache/kylin/tool/extractor/MrJobInfoExtractor.java](https://codecov.io/gh/apache/kylin/pull/1161/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9leHRyYWN0b3IvTXJKb2JJbmZvRXh0cmFjdG9yLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...ache/kylin/tool/extractor/HBaseUsageExtractor.java](https://codecov.io/gh/apache/kylin/pull/1161/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9leHRyYWN0b3IvSEJhc2VVc2FnZUV4dHJhY3Rvci5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...apache/kylin/tool/extractor/KylinLogExtractor.java](https://codecov.io/gh/apache/kylin/pull/1161/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9leHRyYWN0b3IvS3lsaW5Mb2dFeHRyYWN0b3IuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...he/kylin/tool/extractor/SparkEnvInfoExtractor.java](https://codecov.io/gh/apache/kylin/pull/1161/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9leHRyYWN0b3IvU3BhcmtFbnZJbmZvRXh0cmFjdG9yLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/1161/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `12.26% <0%> (ø)` | `44 <0> (?)` | |
   | ... and [8 more](https://codecov.io/gh/apache/kylin/pull/1161/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1161?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1161?src=pr&el=footer). Last update [16924ef...1b351e6](https://codecov.io/gh/apache/kylin/pull/1161?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io edited a comment on issue #1161: KYLIN-4425 Refactor diagnosis module

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1161: KYLIN-4425 Refactor diagnosis module
URL: https://github.com/apache/kylin/pull/1161#issuecomment-598029527
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/1161?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@16924ef`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `10.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1161/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/1161?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff            @@
   ##             master   #1161   +/-   ##
   ========================================
     Coverage          ?     25%           
     Complexity        ?    6250           
   ========================================
     Files             ?    1449           
     Lines             ?   88490           
     Branches          ?   12373           
   ========================================
     Hits              ?   22125           
     Misses            ?   64188           
     Partials          ?    2177
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1161?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...in/java/org/apache/kylin/common/util/ToolUtil.java](https://codecov.io/gh/apache/kylin/pull/1161/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL1Rvb2xVdGlsLmphdmE=) | `10.63% <ø> (ø)` | `2 <0> (?)` | |
   | [.../java/org/apache/kylin/common/util/HadoopUtil.java](https://codecov.io/gh/apache/kylin/pull/1161/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0hhZG9vcFV0aWwuamF2YQ==) | `14.56% <ø> (ø)` | `10 <0> (?)` | |
   | [...org/apache/kylin/tool/extractor/HiveConfigCLI.java](https://codecov.io/gh/apache/kylin/pull/1161/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9leHRyYWN0b3IvSGl2ZUNvbmZpZ0NMSS5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | |
   | [...che/kylin/tool/extractor/JobInstanceExtractor.java](https://codecov.io/gh/apache/kylin/pull/1161/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9leHRyYWN0b3IvSm9iSW5zdGFuY2VFeHRyYWN0b3IuamF2YQ==) | `0% <ø> (ø)` | `0 <0> (?)` | |
   | [...n/java/org/apache/kylin/tool/DiagnosisInfoCLI.java](https://codecov.io/gh/apache/kylin/pull/1161/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9EaWFnbm9zaXNJbmZvQ0xJLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...pache/kylin/tool/extractor/MrJobInfoExtractor.java](https://codecov.io/gh/apache/kylin/pull/1161/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9leHRyYWN0b3IvTXJKb2JJbmZvRXh0cmFjdG9yLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...ache/kylin/tool/extractor/HBaseUsageExtractor.java](https://codecov.io/gh/apache/kylin/pull/1161/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9leHRyYWN0b3IvSEJhc2VVc2FnZUV4dHJhY3Rvci5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...apache/kylin/tool/extractor/KylinLogExtractor.java](https://codecov.io/gh/apache/kylin/pull/1161/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9leHRyYWN0b3IvS3lsaW5Mb2dFeHRyYWN0b3IuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...he/kylin/tool/extractor/SparkEnvInfoExtractor.java](https://codecov.io/gh/apache/kylin/pull/1161/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9leHRyYWN0b3IvU3BhcmtFbnZJbmZvRXh0cmFjdG9yLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/1161/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `12.26% <0%> (ø)` | `44 <0> (?)` | |
   | ... and [8 more](https://codecov.io/gh/apache/kylin/pull/1161/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1161?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1161?src=pr&el=footer). Last update [16924ef...1de3889](https://codecov.io/gh/apache/kylin/pull/1161?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] hit-lacus commented on issue #1161: KYLIN-4425 Refactor diagnosis module

Posted by GitBox <gi...@apache.org>.
hit-lacus commented on issue #1161: KYLIN-4425 Refactor diagnosis module
URL: https://github.com/apache/kylin/pull/1161#issuecomment-598122125
 
 
   This is the documentation : https://cwiki.apache.org/confluence/display/KYLIN/DiagnosisTool .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] shaofengshi merged pull request #1161: KYLIN-4425 Refactor diagnosis module

Posted by GitBox <gi...@apache.org>.
shaofengshi merged pull request #1161: KYLIN-4425 Refactor diagnosis module
URL: https://github.com/apache/kylin/pull/1161
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] hit-lacus commented on issue #1161: KYLIN-4425 Refactor diagnosis module

Posted by GitBox <gi...@apache.org>.
hit-lacus commented on issue #1161: KYLIN-4425 Refactor diagnosis module
URL: https://github.com/apache/kylin/pull/1161#issuecomment-598151823
 
 
   Manual test passed in 
   - [ ] CDH 5.6
   - [ ] CDH 6.1
   - [ ] HDP 2.4
   - [ ] HDP 3.0

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services