You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "allisonwang-db (via GitHub)" <gi...@apache.org> on 2023/07/17 22:09:16 UTC
[GitHub] [spark] allisonwang-db commented on a diff in pull request #42027: [SPARK-44413][PYTHON] Clarify error for unsupported arg data type in …
allisonwang-db commented on code in PR #42027:
URL: https://github.com/apache/spark/pull/42027#discussion_r1265949390
##########
python/pyspark/sql/tests/test_utils.py:
##########
@@ -648,17 +649,25 @@ def test_assert_error_pandas_df(self):
self.check_error(
exception=pe.exception,
- error_class="UNSUPPORTED_DATA_TYPE",
- message_parameters={"data_type": pd.DataFrame},
+ error_class="INVALID_TYPE_DF_EQUALITY_ARG",
+ message_parameters={
+ "expected_type": DataFrame,
+ "arg_name": "df",
+ "actual_type": pd.DataFrame,
Review Comment:
Just curious, what will the error message look like in this case? Is it clear that the method expects a pyspark dataframe instead of a pandas dataframe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org