You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org> on 2019/08/28 21:14:24 UTC

[Impala-ASF-CR] IMPALA-7975(continued): Improve supportability of the automatic invalidate feature.

Anurag Mantripragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14159


Change subject: IMPALA-7975(continued): Improve supportability of the automatic invalidate feature.
......................................................................

IMPALA-7975(continued): Improve supportability of the automatic
invalidate feature.

This work was done by Sharanitha Harish.

This commit adds support to display the metric last-synced-event-id
as /metrics#events page whereas previously it was displayed
only on the /events page.

Testing:
Added tests toMetaStoreEventsProcessorTest to verify:
1. If the metric updated as it should when new events were processed.
2. If the metric was not set when the event processor was not active.

Change-Id: I6c468f2c3b456399ed67196ee27a9908f7376974
---
M be/src/util/event-metrics.cc
M be/src/util/event-metrics.h
M common/thrift/JniCatalog.thrift
M common/thrift/metrics.json
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
6 files changed, 33 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/14159/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c468f2c3b456399ed67196ee27a9908f7376974
Gerrit-Change-Number: 14159
Gerrit-PatchSet: 1
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>

[Impala-ASF-CR] IMPALA-7975(continued): Improve supportability of the automatic invalidate feature.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14159 )

Change subject: IMPALA-7975(continued): Improve supportability of the automatic invalidate feature.
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/4425/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/14159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c468f2c3b456399ed67196ee27a9908f7376974
Gerrit-Change-Number: 14159
Gerrit-PatchSet: 1
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Aug 2019 21:54:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7975(continued): Improve supportability of the automatic invalidate feature.

Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has abandoned this change. ( http://gerrit.cloudera.org:8080/14159 )

Change subject: IMPALA-7975(continued): Improve supportability of the automatic invalidate feature.
......................................................................


Abandoned

Duplicate
-- 
To view, visit http://gerrit.cloudera.org:8080/14159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I6c468f2c3b456399ed67196ee27a9908f7376974
Gerrit-Change-Number: 14159
Gerrit-PatchSet: 1
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>