You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by zsxwing <gi...@git.apache.org> on 2017/04/26 20:42:41 UTC

[GitHub] spark pull request #17765: [SPARK-20464][SS] Add a job group and description...

Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17765#discussion_r113557507
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala ---
    @@ -825,6 +833,11 @@ class StreamExecution(
         }
       }
     
    +  private def getBatchDescriptionString: String = {
    +    val batchDescription = if (currentBatchId < 0) "init" else currentBatchId.toString
    +    Option(name).map(_ + " ").getOrElse("") +
    +      s"[batch = $batchDescription, id = $id, runId = $runId]"
    --- End diff --
    
    The description looks good to me. @marmbrus what do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org