[shardingsphere] branch master updated: Deprecate CountInstanceRulesHandler (#18582)

[pa...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

panjuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 693051a0617 Deprecate CountInstanceRulesHandler (#18582)
693051a0617 is described below

commit 693051a061749210a1ad2b77c8446304e417bdc5
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Sat Jun 25 16:40:41 2022 +0800

    Deprecate CountInstanceRulesHandler (#18582)
---
 .../statement/ral/common/queryable/CountInstanceRulesStatement.java    | 3 +++
 .../text/distsql/ral/common/queryable/CountInstanceRulesHandler.java   | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/shardingsphere-distsql/shardingsphere-distsql-statement/src/main/java/org/apache/shardingsphere/distsql/parser/statement/ral/common/queryable/CountInstanceRulesStatement.java b/shardingsphere-distsql/shardingsphere-distsql-statement/src/main/java/org/apache/shardingsphere/distsql/parser/statement/ral/common/queryable/CountInstanceRulesStatement.java
index f333b8b3cc6..dd05372bf4a 100644
--- a/shardingsphere-distsql/shardingsphere-distsql-statement/src/main/java/org/apache/shardingsphere/distsql/parser/statement/ral/common/queryable/CountInstanceRulesStatement.java
+++ b/shardingsphere-distsql/shardingsphere-distsql-statement/src/main/java/org/apache/shardingsphere/distsql/parser/statement/ral/common/queryable/CountInstanceRulesStatement.java
@@ -21,6 +21,9 @@ import org.apache.shardingsphere.distsql.parser.statement.ral.QueryableRALStatem
 
 /**
  * Count instance rules statement.
+ * 
+ * @deprecated The class CountInstanceRulesHandler is deprecated, the entry SQL statement should be deprecated too.
  */
+@Deprecated
 public final class CountInstanceRulesStatement extends QueryableRALStatement {
 }
diff --git a/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/distsql/ral/common/queryable/CountInstanceRulesHandler.java b/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/distsql/ral/common/queryable/CountInstanceRulesHandler.java
index 60d89b21ff6..453a847ec4c 100644
--- a/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/distsql/ral/common/queryable/CountInstanceRulesHandler.java
+++ b/shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/distsql/ral/common/queryable/CountInstanceRulesHandler.java
@@ -41,7 +41,10 @@ import java.util.function.Supplier;
 
 /**
  * Count instance rules handler.
+ * 
+ * @deprecated This class breaks the pluggable design, nobody need to know all dynamic plugins. We should split the count logic push down to concrete rule. 
  */
+@Deprecated
 public final class CountInstanceRulesHandler extends QueryableRALBackendHandler<CountInstanceRulesStatement> {
     
     private static final String SINGLE_TABLE = "single_table";