You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by vkorukanti <gi...@git.apache.org> on 2015/12/15 01:14:35 UTC
[GitHub] drill pull request: DRILL-4198: Enhance StoragePlugin interface to...
GitHub user vkorukanti opened a pull request:
https://github.com/apache/drill/pull/300
DRILL-4198: Enhance StoragePlugin interface to expose logical space r…
…ules for planning purpose
Also move Hive partition pruning rules to logical storage plugin rulesets.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vkorukanti/drill logical_st
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/300.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #300
----
commit 8cec3401afb83245181daa0ec6a4e7e78b3ed038
Author: vkorukanti <ve...@gmail.com>
Date: 2015-12-15T00:02:55Z
DRILL-4198: Enhance StoragePlugin interface to expose logical space rules for planning purpose
Also move Hive partition pruning rules to logical storage plugin rulesets.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4198: Enhance StoragePlugin interface to...
Posted by vkorukanti <gi...@git.apache.org>.
Github user vkorukanti commented on the pull request:
https://github.com/apache/drill/pull/300#issuecomment-164601256
@jinfengni Could you please review the patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4198: Enhance StoragePlugin interface to...
Posted by jinfengni <gi...@git.apache.org>.
Github user jinfengni commented on the pull request:
https://github.com/apache/drill/pull/300#issuecomment-164609559
+1. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4198: Enhance StoragePlugin interface to...
Posted by jinfengni <gi...@git.apache.org>.
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/300#discussion_r47582011
--- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveStoragePlugin.java ---
@@ -91,20 +91,24 @@ public void registerSchemas(SchemaConfig schemaConfig, SchemaPlus parent) throws
}
@Override
- public Set<StoragePluginOptimizerRule> getOptimizerRules(OptimizerRulesContext optimizerRulesContext) {
+ public Set<StoragePluginOptimizerRule> getLogicalOptimizerRules(OptimizerRulesContext optimizerContext) {
final String defaultPartitionValue = HiveUtilities.getDefaultPartitionValue(config.getHiveConfigOverride());
ImmutableSet.Builder<StoragePluginOptimizerRule> ruleBuilder = ImmutableSet.builder();
- ruleBuilder.add(HivePushPartitionFilterIntoScan.getFilterOnProject(optimizerRulesContext, defaultPartitionValue));
- ruleBuilder.add(HivePushPartitionFilterIntoScan.getFilterOnScan(optimizerRulesContext, defaultPartitionValue));
+ ruleBuilder.add(HivePushPartitionFilterIntoScan.getFilterOnProject(optimizerContext, defaultPartitionValue));
+ ruleBuilder.add(HivePushPartitionFilterIntoScan.getFilterOnScan(optimizerContext, defaultPartitionValue));
+ return ruleBuilder.build();
+ }
+
+ @Override
+ public Set<StoragePluginOptimizerRule> getPhysicalOptimizerRules(OptimizerRulesContext optimizerRulesContext) {
if(optimizerRulesContext.getPlannerSettings().getOptions()
.getOption(ExecConstants.HIVE_OPTIMIZE_SCAN_WITH_NATIVE_READERS).bool_val) {
- ruleBuilder.add(ConvertHiveParquetScanToDrillParquetScan.INSTANCE);
+ ImmutableSet.of(ConvertHiveParquetScanToDrillParquetScan.INSTANCE);
--- End diff --
return ImmutableSet.of(ConvertHiveParquetScanToDrillParquetScan.INSTANCE) ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-4198: Enhance StoragePlugin interface to...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/300
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---