You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Dave Lerman (JIRA)" <ji...@apache.org> on 2009/09/04 22:34:57 UTC

[jira] Created: (HIVE-816) MetastoreClient not being cached

MetastoreClient not being cached
--------------------------------

                 Key: HIVE-816
                 URL: https://issues.apache.org/jira/browse/HIVE-816
             Project: Hadoop Hive
          Issue Type: Bug
          Components: Metastore
    Affects Versions: 0.3.0
            Reporter: Dave Lerman
            Priority: Minor


In org.apache.hadoop.hive.ql.metadata.Hive.getMSC(), we create a new MetaStoreClient on every call because the result is not getting properly cached in the threadLocal:

{code}
  private IMetaStoreClient getMSC() throws MetaException {
    IMetaStoreClient msc = threadLocalMSC.get();
    if(msc == null) {
      msc = this.createMetaStoreClient();
      // THERE SHOULD BE A threadLocalMSC.set here!
    }
    return msc;
  }
{code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-816) MetastoreClient not being cached

Posted by "Dave Lerman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Lerman updated HIVE-816:
-----------------------------

    Status: Patch Available  (was: Open)

> MetastoreClient not being cached
> --------------------------------
>
>                 Key: HIVE-816
>                 URL: https://issues.apache.org/jira/browse/HIVE-816
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Metastore
>    Affects Versions: 0.3.0
>            Reporter: Dave Lerman
>            Priority: Minor
>
> In org.apache.hadoop.hive.ql.metadata.Hive.getMSC(), we create a new MetaStoreClient on every call because the result is not getting properly cached in the threadLocal:
> {code}
>   private IMetaStoreClient getMSC() throws MetaException {
>     IMetaStoreClient msc = threadLocalMSC.get();
>     if(msc == null) {
>       msc = this.createMetaStoreClient();
>       // THERE SHOULD BE A threadLocalMSC.set here!
>     }
>     return msc;
>   }
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-816) MetastoreClient not being cached

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated HIVE-816:
----------------------------

       Resolution: Fixed
    Fix Version/s: 0.5.0
                   0.4.0
                   0.3.1
     Release Note: HIVE-816. Cache MetastoreClient. (Dave Lerman via zshao)
     Hadoop Flags: [Reviewed]
           Status: Resolved  (was: Patch Available)

Committed to trunk, branch-0.4, branch-0.3. Thanks Dave!

> MetastoreClient not being cached
> --------------------------------
>
>                 Key: HIVE-816
>                 URL: https://issues.apache.org/jira/browse/HIVE-816
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Metastore
>    Affects Versions: 0.3.0
>            Reporter: Dave Lerman
>            Assignee: Dave Lerman
>            Priority: Minor
>             Fix For: 0.3.1, 0.4.0, 0.5.0
>
>         Attachments: HIVE-816.patch
>
>
> In org.apache.hadoop.hive.ql.metadata.Hive.getMSC(), we create a new MetaStoreClient on every call because the result is not getting properly cached in the threadLocal:
> {code}
>   private IMetaStoreClient getMSC() throws MetaException {
>     IMetaStoreClient msc = threadLocalMSC.get();
>     if(msc == null) {
>       msc = this.createMetaStoreClient();
>       // THERE SHOULD BE A threadLocalMSC.set here!
>     }
>     return msc;
>   }
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-816) MetastoreClient not being cached

Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carl Steinbach updated HIVE-816:
--------------------------------

    Fix Version/s:     (was: 0.3.1)
                       (was: 0.5.0)

> MetastoreClient not being cached
> --------------------------------
>
>                 Key: HIVE-816
>                 URL: https://issues.apache.org/jira/browse/HIVE-816
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Metastore
>    Affects Versions: 0.3.0
>            Reporter: Dave Lerman
>            Assignee: Dave Lerman
>            Priority: Minor
>             Fix For: 0.4.0
>
>         Attachments: HIVE-816.patch
>
>
> In org.apache.hadoop.hive.ql.metadata.Hive.getMSC(), we create a new MetaStoreClient on every call because the result is not getting properly cached in the threadLocal:
> {code}
>   private IMetaStoreClient getMSC() throws MetaException {
>     IMetaStoreClient msc = threadLocalMSC.get();
>     if(msc == null) {
>       msc = this.createMetaStoreClient();
>       // THERE SHOULD BE A threadLocalMSC.set here!
>     }
>     return msc;
>   }
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-816) MetastoreClient not being cached

Posted by "Dave Lerman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Lerman updated HIVE-816:
-----------------------------

    Attachment: HIVE-816.patch

> MetastoreClient not being cached
> --------------------------------
>
>                 Key: HIVE-816
>                 URL: https://issues.apache.org/jira/browse/HIVE-816
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Metastore
>    Affects Versions: 0.3.0
>            Reporter: Dave Lerman
>            Priority: Minor
>         Attachments: HIVE-816.patch
>
>
> In org.apache.hadoop.hive.ql.metadata.Hive.getMSC(), we create a new MetaStoreClient on every call because the result is not getting properly cached in the threadLocal:
> {code}
>   private IMetaStoreClient getMSC() throws MetaException {
>     IMetaStoreClient msc = threadLocalMSC.get();
>     if(msc == null) {
>       msc = this.createMetaStoreClient();
>       // THERE SHOULD BE A threadLocalMSC.set here!
>     }
>     return msc;
>   }
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-816) MetastoreClient not being cached

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751608#action_12751608 ] 

Zheng Shao commented on HIVE-816:
---------------------------------

+1. Will test and commit.


> MetastoreClient not being cached
> --------------------------------
>
>                 Key: HIVE-816
>                 URL: https://issues.apache.org/jira/browse/HIVE-816
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Metastore
>    Affects Versions: 0.3.0
>            Reporter: Dave Lerman
>            Assignee: Dave Lerman
>            Priority: Minor
>         Attachments: HIVE-816.patch
>
>
> In org.apache.hadoop.hive.ql.metadata.Hive.getMSC(), we create a new MetaStoreClient on every call because the result is not getting properly cached in the threadLocal:
> {code}
>   private IMetaStoreClient getMSC() throws MetaException {
>     IMetaStoreClient msc = threadLocalMSC.get();
>     if(msc == null) {
>       msc = this.createMetaStoreClient();
>       // THERE SHOULD BE A threadLocalMSC.set here!
>     }
>     return msc;
>   }
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HIVE-816) MetastoreClient not being cached

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao reassigned HIVE-816:
-------------------------------

    Assignee: Dave Lerman

> MetastoreClient not being cached
> --------------------------------
>
>                 Key: HIVE-816
>                 URL: https://issues.apache.org/jira/browse/HIVE-816
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Metastore
>    Affects Versions: 0.3.0
>            Reporter: Dave Lerman
>            Assignee: Dave Lerman
>            Priority: Minor
>         Attachments: HIVE-816.patch
>
>
> In org.apache.hadoop.hive.ql.metadata.Hive.getMSC(), we create a new MetaStoreClient on every call because the result is not getting properly cached in the threadLocal:
> {code}
>   private IMetaStoreClient getMSC() throws MetaException {
>     IMetaStoreClient msc = threadLocalMSC.get();
>     if(msc == null) {
>       msc = this.createMetaStoreClient();
>       // THERE SHOULD BE A threadLocalMSC.set here!
>     }
>     return msc;
>   }
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.